Changeset 4137 for branches/3.3-HiveMigration/sources/HeuristicLab.Hive/HeuristicLab.Hive.Server.Core/3.3/Facades

Timestamp:

08/03/10 13:42:10 (14 years ago)

Author:

cneumuel

Message:

use no transactions in read-only service calls to avoid dead-locks (#1092)

Location:

branches/3.3-HiveMigration/sources/HeuristicLab.Hive/HeuristicLab.Hive.Server.Core/3.3/Facades

Files:

• ExecutionEngineFacade.cs (modified) (2 diffs)
• ServerConsoleFacade.cs (modified) (14 diffs)

branches/3.3-HiveMigration/sources/HeuristicLab.Hive/HeuristicLab.Hive.Server.Core/3.3/Facades/ExecutionEngineFacade.cs

@@ -59 +59 @@
 
     public ResponseObject<SerializedJob> GetLastSerializedResult(Guid jobId, bool requested, bool snapshot) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         return jobManager.GetLastSerializedJobResultOf(jobId, requested, snapshot);
       }
@@ -65 +65 @@
 
     public ResponseObject<JobDto> GetJobById(Guid jobId) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         return jobManager.GetJobById(jobId);
       }

branches/3.3-HiveMigration/sources/HeuristicLab.Hive/HeuristicLab.Hive.Server.Core/3.3/Facades/ServerConsoleFacade.cs

@@ -49 +49 @@
 
     public Response Login(string username, string password) {
-      using (contextFactory.GetContext()) {
-        Response resp = new Response();
-
-        sessionID = secMan.Login(username, password);
-        if (sessionID == Guid.Empty) {
-          resp.Success = false;
-          resp.StatusMessage = ApplicationConstants.RESPONSE_SERVERCONSOLE_LOGIN_FAILED;
-        } else {
-          resp.Success = true;
-          resp.StatusMessage =
-            ApplicationConstants.RESPONSE_SERVERCONSOLE_LOGIN_SUCCESS;
-        }
-        return resp;
-      }
+      Response resp = new Response();
+
+      sessionID = secMan.Login(username, password);
+      if (sessionID == Guid.Empty) {
+        resp.Success = false;
+        resp.StatusMessage = ApplicationConstants.RESPONSE_SERVERCONSOLE_LOGIN_FAILED;
+      } else {
+        resp.Success = true;
+        resp.StatusMessage =
+          ApplicationConstants.RESPONSE_SERVERCONSOLE_LOGIN_SUCCESS;
+      }
+      return resp;
     }
 
 
     public ResponseList<ClientDto> GetAllClients() {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessClients", sessionID, Guid.Empty);
         return clientManager.GetAllClients();
@@ -74 +72 @@
 
     public ResponseList<ClientGroupDto> GetAllClientGroups() {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         //secMan.Authorize("AccessClientGroup", sessionID, Guid.Empty);
         return clientManager.GetAllClientGroups();
@@ -81 +79 @@
 
     public ResponseList<UpTimeStatisticsDto> GetAllUpTimeStatistics() {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessStatistics", sessionID, Guid.Empty);
         return clientManager.GetAllUpTimeStatistics();
@@ -108 +106 @@
 
     public ResponseList<JobDto> GetAllJobs() {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessJobs", sessionID, Guid.Empty);
         return jobManager.GetAllJobs();
@@ -115 +113 @@
 
     public ResponseList<JobDto> GetAllJobsWithFilter(State jobState, int offset, int count) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessJobs", sessionID, Guid.Empty);
         return jobManager.GetAllJobsWithFilter(jobState, offset, count);
@@ -122 +120 @@
 
     public ResponseObject<JobDto> GetJobById(Guid jobId) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessJobs", sessionID, jobId);
         return jobManager.GetJobById(jobId);
@@ -129 +127 @@
 
     public ResponseObject<JobDto> GetJobByIdWithDetails(Guid jobId) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessJobs", sessionID, jobId);
         return jobManager.GetJobByIdWithDetails(jobId);
@@ -143 +141 @@
 
     public ResponseObject<JobDto> GetLastJobResultOf(Guid jobId) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessJobResults", sessionID, jobId);
         return jobManager.GetLastJobResultOf(jobId);
@@ -150 +148 @@
 
     public ResponseObject<SerializedJob> GetLastSerializedJobResultOf(Guid jobId, bool requested, bool snapshot) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessJobResults", sessionID, jobId);
         return jobManager.GetLastSerializedJobResultOf(jobId, requested, snapshot);
@@ -157 +155 @@
 
     public ResponseList<JobResult> GetAllJobResults(Guid jobId) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessJobResults", sessionID, jobId);
         return jobManager.GetAllJobResults(jobId);
@@ -185 +183 @@
 
     public ResponseObject<ClientGroupDtoList> GetAllGroupsOfResource(Guid resourceId) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessUserGroup", sessionID, Guid.Empty);
         return clientManager.GetAllGroupsOfResource(resourceId);
@@ -199 +197 @@
 
     public ResponseList<ProjectDto> GetAllProjects() {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessProjects", sessionID, Guid.Empty);
         return jobManager.GetAllProjects();
@@ -227 +225 @@
 
     public ResponseList<JobDto> GetJobsByProject(Guid projectId) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         secMan.Authorize("AccessJobs", sessionID, Guid.Empty);
         return jobManager.GetJobsByProject(projectId);
@@ -234 +232 @@
 
     public ResponseList<AppointmentDto> GetUptimeCalendarForResource(Guid guid) {
-      using (contextFactory.GetContext()) {
+      using (contextFactory.GetContext(false)) {
         return clientManager.GetUptimeCalendarForResource(guid);
       }