Changeset 4007 for branches/HeuristicLab.Services.Authentication Prototype/Service

Timestamp:

07/07/10 01:48:02 (14 years ago)

Author:

dkahn

Message:

#1061 Moved a paging into a dedicated method to prevent redundancy

File:

• branches/HeuristicLab.Services.Authentication Prototype/Service/Provider/HeuristicLabMembershipProvider.cs (modified) (2 diffs)

branches/HeuristicLab.Services.Authentication Prototype/Service/Provider/HeuristicLabMembershipProvider.cs

@@ -245 +245 @@
     public override MembershipUserCollection FindUsersByEmail(string emailToMatch, int pageIndex, int pageSize, out int totalRecords) {
       throw new NotImplementedException();
-    }
+      totalRecords = 0;
+      using (DataClassesDataContext db = DatabaseUtil.createDataClassesDataContext()) {
+        // don't test db - throw an exception instead if something wents wrong
+        // bail out if there are no records
+        if (0 == (totalRecords = db.HeuristicLabUsers.Count<HeuristicLabUser>())) return new MembershipUserCollection();
+
+        MembershipUserCollection userCollection = new MembershipUserCollection();
+
+      }
+    }
+
 
     public override MembershipUserCollection FindUsersByName(string usernameToMatch, int pageIndex, int pageSize, out int totalRecords) {
@@ -252 +262 @@
 
     public override MembershipUserCollection GetAllUsers(int pageIndex, int pageSize, out int totalRecords) {
-      totalRecords = 0;
-      using (DataClassesDataContext db = DatabaseUtil.createDataClassesDataContext()) {
-        if (db == null) {
-          totalRecords = 0;
-          return new MembershipUserCollection();
-        }
-
-        // bail out if there are no records
-        if (0 == (totalRecords = db.HeuristicLabUsers.Count<HeuristicLabUser>())) return new MembershipUserCollection();
-
-        MembershipUserCollection userCollection = new MembershipUserCollection();
-        int skip = (pageIndex == 0) ? 0 : (pageIndex * pageSize);
-
-        // .OrderBy(usr=>usr.UserName)
+      using (DataClassesDataContext db = DatabaseUtil.createDataClassesDataContext()) {
+        // orderby u.UserName 
         // skipped ordering for now as the default comparator seems to be wrong
-        foreach (HeuristicLabUser u in db.HeuristicLabUsers.Skip(skip).Take(pageSize)) {
-          userCollection.Add(u.getMembershipUser(this.Name));
-        }
-        return userCollection;
-      }
-    }
+        IQueryable<HeuristicLabUser> users = (from u in db.HeuristicLabUsers select u);
+        return PagedCollection(users, pageIndex, pageSize, out totalRecords);
+      }
+    }
+
+    /// <summary>
+    /// Helper method that takes an IQueriable object and returns a paged part of it
+    /// </summary>
+    /// <param name="querySource"></param>
+    /// <param name="pageIndex"></param>
+    /// <param name="pageSize"></param>
+    /// <param name="totalRecords"></param>
+    /// <returns></returns>
+    private MembershipUserCollection PagedCollection(IQueryable<HeuristicLabUser> querySource, int pageIndex, int pageSize, out int totalRecords) {
+      totalRecords = querySource.Count();
+      MembershipUserCollection userCollection = new MembershipUserCollection();
+      int skip = (pageIndex == 0) ? 0 : (pageIndex * pageSize);
+      foreach (HeuristicLabUser u in querySource.Skip(skip).Take(pageSize)) {
+        userCollection.Add(u.getMembershipUser(this.Name));
+      }
+      return userCollection;
+    }
+
     /// <summary>
     /// not jet implemented returns 0 as default