Changeset 4006 for branches/HeuristicLab.Services.Authentication Prototype/Service/Provider

Timestamp:

07/07/10 01:03:47 (14 years ago)

Author:

dkahn

Message:

#1061 Implemented GetAllUsers with unit test. Returning an ordered collection is still to be done

File:

• branches/HeuristicLab.Services.Authentication Prototype/Service/Provider/HeuristicLabMembershipProvider.cs (modified) (3 diffs)

branches/HeuristicLab.Services.Authentication Prototype/Service/Provider/HeuristicLabMembershipProvider.cs

@@ -125 +125 @@
       }
     }
-
-
 
     public override bool ChangePassword(string username, string oldPassword, string newPassword) {
@@ -253 +251 @@
     }
 
-    // not for production use - fab and dkhan are currently working on that
     public override MembershipUserCollection GetAllUsers(int pageIndex, int pageSize, out int totalRecords) {
       totalRecords = 0;
@@ -266 +263 @@
 
         MembershipUserCollection userCollection = new MembershipUserCollection();
-        int skip = (pageIndex == 0) ? 0 : (pageIndex * pageSize) - 1;
-
-        var users = from u in db.HeuristicLabUsers select u;
-
-        foreach (HeuristicLabUser u in users) {
-
-          // this leads to a npe
-          if (u != null) {
-            userCollection.Add(u.getMembershipUser(this.Name));
-          }
+        int skip = (pageIndex == 0) ? 0 : (pageIndex * pageSize);
+
+        // .OrderBy(usr=>usr.UserName)
+        // skipped ordering for now as the default comparator seems to be wrong
+        foreach (HeuristicLabUser u in db.HeuristicLabUsers.Skip(skip).Take(pageSize)) {
+          userCollection.Add(u.getMembershipUser(this.Name));
         }
         return userCollection;