Changeset 4004

Timestamp:

07/06/10 17:14:42 (14 years ago)

Author:

bfarka

Message:

fixed min passwordlength test #1046

Location:

branches/HeuristicLab.Services.Authentication Prototype

Files:

• Service/Provider/HeuristicLabMembershipProvider.cs (modified) (6 diffs)
• UnitTests/HeuristicLabMembershipProviderTest.cs (modified) (2 diffs)

branches/HeuristicLab.Services.Authentication Prototype/Service/Provider/HeuristicLabMembershipProvider.cs

@@ -24 +24 @@
     private int pMaxInvalidPasswordAttempts;
     private int pPasswordAttemptWindow;
-    private int pMinRequiredPasswordLength;
+    private int pMinRequiredPasswordLength = 5;
     private MembershipPasswordFormat pPasswordFormat = MembershipPasswordFormat.Clear;
 
@@ -134 +134 @@
           return false;
         }
+
+        if (newPassword.Length < MinRequiredPasswordLength) {
+          return false;
+        }
+
         try {
           // try to get user
@@ -144 +149 @@
           }
           return false;
-          
-          
+
+
         }
         catch (Exception) {
@@ -184 +189 @@
             return null;
           }
+          if (password.Length < MinRequiredPasswordLength) {
+            status = MembershipCreateStatus.InvalidPassword;
+            return null;
+          }
 
           // create new user
@@ -271 +280 @@
       }
     }
-
+    /// <summary>
+    /// not jet implemented returns 0 as default
+    /// </summary>
+    /// <returns></returns>
     public override int GetNumberOfUsersOnline() {
-      throw new NotImplementedException();
+      return 0;
     }
 
@@ -299 +311 @@
     }
 
-    public bool LockUser(string userName)
-    {
-        using (DataClassesDataContext db = DatabaseUtil.createDataClassesDataContext())
-        {
-            // check database connection
-            if (db == null)
-            {
-                return false;
-            }
-            try
-            {
-                // try to get user
-                HeuristicLabUser u =
-                  db.HeuristicLabUsers.Single<HeuristicLabUser>(x => x.UserName == userName);
-
-                // unlock user
-                u.Locked = true;
-                db.SubmitChanges();
-                return true;
-            }
-            catch (Exception)
-            {
-                return false;
-            }
-        }
-    }
-
-    public override bool UnlockUser(string userName)
-    {
-        using (DataClassesDataContext db = DatabaseUtil.createDataClassesDataContext())
-        {
-            // check database connection
-            if (db == null)
-            {
-                return false;
-            }
-            try
-            {
-                // try to get user
-                HeuristicLabUser u =
-                  db.HeuristicLabUsers.Single<HeuristicLabUser>(x => x.UserName == userName);
-
-                // unlock user
-                u.Locked = false;
-                db.SubmitChanges();
-                return true;
-            }
-            catch (Exception)
-            {
-                return false;
-            }
-        }
+    public bool LockUser(string userName) {
+      using (DataClassesDataContext db = DatabaseUtil.createDataClassesDataContext()) {
+        // check database connection
+        if (db == null) {
+          return false;
+        }
+        try {
+          // try to get user
+          HeuristicLabUser u =
+            db.HeuristicLabUsers.Single<HeuristicLabUser>(x => x.UserName == userName);
+
+          // unlock user
+          u.Locked = true;
+          db.SubmitChanges();
+          return true;
+        }
+        catch (Exception) {
+          return false;
+        }
+      }
+    }
+
+    public override bool UnlockUser(string userName) {
+      using (DataClassesDataContext db = DatabaseUtil.createDataClassesDataContext()) {
+        // check database connection
+        if (db == null) {
+          return false;
+        }
+        try {
+          // try to get user
+          HeuristicLabUser u =
+            db.HeuristicLabUsers.Single<HeuristicLabUser>(x => x.UserName == userName);
+
+          // unlock user
+          u.Locked = false;
+          db.SubmitChanges();
+          return true;
+        }
+        catch (Exception) {
+          return false;
+        }
+      }
     }
 

branches/HeuristicLab.Services.Authentication Prototype/UnitTests/HeuristicLabMembershipProviderTest.cs

@@ -123 +123 @@
     public void MinRequiredPasswordLengthTest() {
       MembershipProvider target = Membership.Provider;  // TODO: Initialize to an appropriate value
-      int actual;
-      actual = target.MinRequiredPasswordLength;
-      Assert.Inconclusive("Verify the correctness of this test method.");
+     
+      MembershipCreateStatus status;
+      target.CreateUser("username", "", "mail", "question", "answer", true, null,out status);
+      Assert.AreEqual(status, MembershipCreateStatus.InvalidPassword);
+      target.CreateUser("username", "testusername", "mail", "question", "answer", true, null, out status);
+      Assert.AreEqual(status, MembershipCreateStatus.Success);
+      Assert.IsFalse(target.ChangePassword("username", "testusername", ""));
+      Assert.IsTrue(target.ChangePassword("username", "testusername", "foofoofoo"));
     }
 
@@ -334 +339 @@
       actual = target.GetNumberOfUsersOnline();
       Assert.AreEqual(expected, actual);
-      Assert.Inconclusive("Verify the correctness of this test method.");
     }