Changeset 4000

Timestamp:

07/06/10 13:48:48 (14 years ago)

Author:

mholper

Message:

implemented last Method HeuristicLabRoleProvider.DeleteRole and UnitTest (#1046)
--> HeuristicLabRoleProvider finished now, all HeuristicLabRoleProviderTest passed (#1077)

Location:

branches/HeuristicLab.Services.Authentication Prototype

Files:

• Service/Provider/HeuristicLabRoleProvider.cs (modified) (3 diffs)
• UnitTests/HeuristicLabRoleProviderTest.cs (modified) (4 diffs)

branches/HeuristicLab.Services.Authentication Prototype/Service/Provider/HeuristicLabRoleProvider.cs

@@ -54 +54 @@
     }
 
+    //
+    // RoleProvider.DeleteRole
+    //
     public override bool DeleteRole(string roleName, bool throwOnPopulatedRole) {
-      throw new NotImplementedException();
+      String[] roleArray = new String[1];
+      roleArray[0] = roleName;
+      Persistence.DataClassesDataContext db = DatabaseUtil.createDataClassesDataContext();
+
+      if (!RoleExists(roleName)) {
+        return false;
+        //throw new Exception("Role does not exist.");
+      }
+
+      if (throwOnPopulatedRole && GetUsersInRole(roleName).Length > 0) {
+        return false;
+        //throw new ProviderException("Cannot delete a populated role.");
+      }
+
+      RemoveUsersFromRoles(GetUsersInRole(roleName), roleArray);
+
+      Persistence.HeuristicLabRole role = db.HeuristicLabRole.Single(r => r.RoleName == roleName);
+      db.HeuristicLabRole.DeleteOnSubmit(role);
+      db.Dispose();
+
+      return true;
     }
 
@@ -107 +130 @@
         Persistence.HeuristicLabRole role = context.HeuristicLabRole.Single(r => r.RoleName == roleName);
         foreach (Persistence.HeuristicLabUserRole roleUser in role.HeuristicLabUserRoles) {
-          if(!userList.Contains(roleUser.HeuristicLabUser.UserName))
+          if (!userList.Contains(roleUser.HeuristicLabUser.UserName))
             userList.Add(roleUser.HeuristicLabUser.UserName);
         }
@@ -153 +176 @@
     }
   }
-}
+}//HeuristicLabRoleProvider

branches/HeuristicLab.Services.Authentication Prototype/UnitTests/HeuristicLabRoleProviderTest.cs

@@ -94 +94 @@
       //and add all these users to groups admin and users
       AddUsersToRolesTest();
-      HeuristicLabRoleProvider target = new HeuristicLabRoleProvider(); 
+      HeuristicLabRoleProvider target = new HeuristicLabRoleProvider();
       string[] users = new string[2];
       string[] roles = new string[1];
@@ -278 +278 @@
     [TestMethod()]
     public void DeleteRoleTest() {
-      HeuristicLabRoleProvider target = new HeuristicLabRoleProvider(); // TODO: Initialize to an appropriate value
-      string roleName = string.Empty; // TODO: Initialize to an appropriate value
-      bool throwOnPopulatedRole = false; // TODO: Initialize to an appropriate value
-      bool expected = false; // TODO: Initialize to an appropriate value
-      bool actual;
-      actual = target.DeleteRole(roleName, throwOnPopulatedRole);
-      Assert.AreEqual(expected, actual);
-      Assert.Inconclusive("Verify the correctness of this test method.");
+
+      //creates users dkhan,hmayer,bfarka (with AddUsersToRolesTest())
+      //and add all these users to groups admin and users
+      AddUsersToRolesTest();
+      HeuristicLabRoleProvider target = new HeuristicLabRoleProvider();
+      string[] users = new string[2];
+      string[] roles = new string[1];
+
+      //remove hmayer from role admin
+      users[0] = "hmayr";
+      roles[0] = "admin";
+
+      //before removing, check if all three users exits correctly in admin group
+      Assert.IsTrue((target.GetRolesForUser("hmayr").ToList()).Contains(roles[0]));
+      Assert.IsTrue((target.GetRolesForUser("dkhan").ToList()).Contains(roles[0]));
+      Assert.IsTrue((target.GetRolesForUser("bfarka").ToList()).Contains(roles[0]));
+
+      //try to delete Role admin (with user hmayr from  admin group exists)
+      Assert.IsFalse(target.DeleteRole(roles[0], true));
+
+      Assert.IsTrue(target.IsUserInRole(users[0], roles[0]));
+
+      //final populateRole if false
+      //try to delete Role admin (with user hmayr from  admin group exists)
+      Assert.IsTrue(target.DeleteRole(roles[0], false));
+      Assert.IsFalse(target.IsUserInRole(users[0], roles[0]));
+      Assert.IsFalse((target.GetRolesForUser("hmayr").ToList()).Contains(roles[0]));
     }
 
@@ -351 +370 @@
       try {
         Persistence.HeuristicLabRole role = new Persistence.HeuristicLabRole();
-        role.RoleName ="role1";
+        role.RoleName = "role1";
         Persistence.HeuristicLabRole role1 = new Persistence.HeuristicLabRole();
-        role1.RoleName ="role1";
+        role1.RoleName = "role1";
         db.HeuristicLabRole.InsertOnSubmit(role);
         db.HeuristicLabRole.InsertOnSubmit(role1);
@@ -364 +383 @@
     }
   }
-
- 
-
-
-
-}
+} //HeuristicLabRoleProviderTest