Changeset 297

Timestamp:

06/05/08 12:09:22 (16 years ago)

Author:

gkronber

Message:

• fixed "off by one" bug when determining the number of badChildren needed from the successRatioLimit.
• fixed a bug in the calculation of the current successRatio. (used number of good Children in the last generation instead of the total number of good children

(ticket #142)

File:

• trunk/sources/HeuristicLab.Selection.OffspringSelection/OffspringSelector.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Selection.OffspringSelection/OffspringSelector.cs

@@ -106 +106 @@
           // only keep the child if we have not filled up the pool or if we reached the
           // selection pressure limit in which case we have to keep more lucky losers than usual
-          if ((1 - successRatioLimit) * parents.SubScopes.Count >= badChildren.Count ||
+          if ((1 - successRatioLimit) * parents.SubScopes.Count > badChildren.Count ||
             selectionPressure.Data >= selectionPressureLimit) {
             badChildren.Add(child);
@@ -116 +116 @@
       // calculate actual selection pressure and success ratio
       selectionPressure.Data += (goodCount + badCount) / ((double)parents.SubScopes.Count);
-      successRatio.Data = goodCount / ((double)parents.SubScopes.Count);
+      successRatio.Data = goodChildren.Count / ((double)parents.SubScopes.Count);
 
       // check if enough children have been generated