Changeset 2876 for trunk/sources

Timestamp:

02/26/10 16:38:19 (15 years ago)

Author:

epitzer

Message:

Ignore assemblies that fail to load during type discovery in configuration services (#548)

File:

• trunk/sources/HeuristicLab.Persistence/3.3/Core/ConfigurationService.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Persistence/3.3/Core/ConfigurationService.cs

@@ -98 +98 @@
       Assembly defaultAssembly = Assembly.GetExecutingAssembly();
       DiscoverFrom(defaultAssembly);
-      foreach (Assembly a in AppDomain.CurrentDomain.GetAssemblies())
-        if (a != defaultAssembly)
-          DiscoverFrom(a);
+      try {
+        foreach (Assembly a in AppDomain.CurrentDomain.GetAssemblies())
+          if (a != defaultAssembly)
+            DiscoverFrom(a);
+      } catch (AppDomainUnloadedException x) {
+        Logger.Warn("could not get list of assemblies, AppDomain has already been unloaded", x);
+      }
       SortCompositeSerializers();
     }
@@ -115 +119 @@
 
     protected void DiscoverFrom(Assembly a) {
-      foreach (Type t in a.GetTypes()) {
-        if (t.GetInterface(typeof(IPrimitiveSerializer).FullName) != null) {
-          try {
-            IPrimitiveSerializer primitiveSerializer =
-              (IPrimitiveSerializer)Activator.CreateInstance(t, true);
-            if (!PrimitiveSerializers.ContainsKey(primitiveSerializer.SerialDataType)) {
-              PrimitiveSerializers.Add(primitiveSerializer.SerialDataType, new List<IPrimitiveSerializer>());
+      try {
+        foreach (Type t in a.GetTypes()) {
+          if (t.GetInterface(typeof(IPrimitiveSerializer).FullName) != null) {
+            try {
+              IPrimitiveSerializer primitiveSerializer =
+                (IPrimitiveSerializer)Activator.CreateInstance(t, true);
+              if (!PrimitiveSerializers.ContainsKey(primitiveSerializer.SerialDataType)) {
+                PrimitiveSerializers.Add(primitiveSerializer.SerialDataType, new List<IPrimitiveSerializer>());
+              }
+              PrimitiveSerializers[primitiveSerializer.SerialDataType].Add(primitiveSerializer);
+              Logger.Debug(String.Format("discovered primitive serializer {0} ({1} -> {2})",
+                t.VersionInvariantName(),
+                primitiveSerializer.SourceType.AssemblyQualifiedName,
+                primitiveSerializer.SerialDataType.AssemblyQualifiedName));
+            } catch (MissingMethodException e) {
+              Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
+            } catch (ArgumentException e) {
+              Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
             }
-            PrimitiveSerializers[primitiveSerializer.SerialDataType].Add(primitiveSerializer);
-            Logger.Debug(String.Format("discovered primitive serializer {0} ({1} -> {2})",
-              t.VersionInvariantName(),
-              primitiveSerializer.SourceType.AssemblyQualifiedName,
-              primitiveSerializer.SerialDataType.AssemblyQualifiedName));
-          } catch (MissingMethodException e) {
-            Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
-          } catch (ArgumentException e) {
-            Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
+          }
+          if (t.GetInterface(typeof(ICompositeSerializer).FullName) != null) {
+            try {
+              CompositeSerializers.Add((ICompositeSerializer)Activator.CreateInstance(t, true));
+              Logger.Debug("discovered composite serializer " + t.AssemblyQualifiedName);
+            } catch (MissingMethodException e) {
+              Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
+            } catch (ArgumentException e) {
+              Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
+            }
+          }
+          if (t.GetInterface(typeof(IFormat).FullName) != null) {
+            try {
+              IFormat format = (IFormat)Activator.CreateInstance(t, true);
+              Formats.Add(format);
+              Logger.Debug(String.Format("discovered format {0} ({2}) with serial data {1}.",
+                format.Name,
+                format.SerialDataType,
+                t.AssemblyQualifiedName));
+            } catch (MissingMethodException e) {
+              Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
+            } catch (ArgumentException e) {
+              Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
+            }
           }
         }
-        if (t.GetInterface(typeof(ICompositeSerializer).FullName) != null) {
-          try {
-            CompositeSerializers.Add((ICompositeSerializer)Activator.CreateInstance(t, true));
-            Logger.Debug("discovered composite serializer " + t.AssemblyQualifiedName);
-          } catch (MissingMethodException e) {
-            Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
-          } catch (ArgumentException e) {
-            Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
-          }
-        }
-        if (t.GetInterface(typeof(IFormat).FullName) != null) {
-          try {
-            IFormat format = (IFormat)Activator.CreateInstance(t, true);
-            Formats.Add(format);
-            Logger.Debug(String.Format("discovered format {0} ({2}) with serial data {1}.",
-              format.Name,
-              format.SerialDataType,
-              t.AssemblyQualifiedName));
-          } catch (MissingMethodException e) {
-            Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
-          } catch (ArgumentException e) {
-            Logger.Warn("Could not instantiate " + t.AssemblyQualifiedName, e);
-          }
-        }
+      } catch (ReflectionTypeLoadException e) {
+        Logger.Warn("could not analyse assembly: " + a.FullName, e);
       }
     }