Changeset 241

Timestamp:

05/13/08 18:58:34 (16 years ago)

Author:

gkronber

Message:

Stability improvement.
also makes debugging easier (related to #149). Should be merged into the trunk after testing.

• added exception handling in PluginManager to graciously unload AppDomains when an uncaught exception is occurred
• added exception handling in the starter-form to display an error message-box

Location:

trunk/sources

Files:

• HeuristicLab.PluginInfrastructure/PluginManager.cs (modified) (1 diff)
• HeuristicLab/MainForm.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.PluginInfrastructure/PluginManager.cs

@@ -103 +103 @@
       setup.PrivateBinPath = pluginDir;
       AppDomain applicationDomain = AppDomain.CreateDomain(appInfo.Name + " AppDomain", null, setup);
-
-      Runner remoteRunner = (Runner)applicationDomain.CreateInstanceAndUnwrap("HeuristicLab.PluginInfrastructure", "HeuristicLab.PluginInfrastructure.Runner");
-      NotifyListeners(PluginManagerAction.Initializing, "All plugins");
-      remoteRunner.LoadPlugins(remoteLoader.ActivePlugins);
-      NotifyListeners(PluginManagerAction.Initialized, "All plugins");
-      remoteRunner.Run(appInfo);
-
-      AppDomain.Unload(applicationDomain);
+      try {
+        Runner remoteRunner = (Runner)applicationDomain.CreateInstanceAndUnwrap("HeuristicLab.PluginInfrastructure", "HeuristicLab.PluginInfrastructure.Runner");
+        NotifyListeners(PluginManagerAction.Initializing, "All plugins");
+        remoteRunner.LoadPlugins(remoteLoader.ActivePlugins);
+        NotifyListeners(PluginManagerAction.Initialized, "All plugins");
+        remoteRunner.Run(appInfo);
+      } catch(Exception ex) {
+        // can't handle exception here -> rethrow 
+        throw new ApplicationException("Exception in "+appInfo.Name, ex);
+      } finally {
+        // make sure domain is unloaded in all cases
+        AppDomain.Unload(applicationDomain);
+      }
     }
 

trunk/sources/HeuristicLab/MainForm.cs

@@ -94 +94 @@
           PluginManager.Manager.Action += new PluginManagerActionEventHandler(splashScreen.Manager_Action);
           Thread t = new Thread(delegate() {
-            PluginManager.Manager.Run(app);
+            try {
+              PluginManager.Manager.Run(app);
+            } catch(Exception ex) {
+              ShowErrorMessageBox(ex);
+            }
           });
           t.SetApartmentState(ApartmentState.STA); // needed for the AdvancedOptimizationFrontent
@@ -122 +126 @@
     }
 
+    public void ShowErrorMessageBox(Exception ex) {
+      MessageBox.Show(BuildErrorMessage(ex),
+                      "Error - " + ex.GetType().Name,
+                      MessageBoxButtons.OK,
+                      MessageBoxIcon.Error);
+    }
+    private string BuildErrorMessage(Exception ex) {
+      StringBuilder sb = new StringBuilder();
+      sb.Append("Sorry, but something went wrong!\n\n" + ex.Message + "\n\n" + ex.StackTrace);
+
+      while(ex.InnerException != null) {
+        ex = ex.InnerException;
+        sb.Append("\n\n-----\n\n" + ex.Message + "\n\n" + ex.StackTrace);
+      }
+      return sb.ToString();
+    }
   }
 }