Changeset 2368 for trunk/sources/HeuristicLab.Modeling/3.2

Timestamp:

09/17/09 13:32:19 (15 years ago)

Author:

gkronber

Message:

Fixed a bug in the variable impact calculation operators. #750.

Location:

trunk/sources/HeuristicLab.Modeling/3.2

Files:

• VariableEvaluationImpactCalculator.cs (modified) (1 diff)
• VariableQualityImpactCalculator.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Modeling/3.2/VariableEvaluationImpactCalculator.cs

@@ -97 +97 @@
       foreach (string variableName in variables) {
         if (variableName != targetVariableName) {
-          mean = dataset.GetMean(variableName, start, end);
-          oldValues = dirtyDataset.ReplaceVariableValues(variableName, Enumerable.Repeat(mean, end - start), start, end);
-          newValues = predictor.Predict(dirtyDataset, start, end);
-          evaluationImpacts[variableName] = 1 - CalculateVAF(referenceValues, newValues);
-          dirtyDataset.ReplaceVariableValues(variableName, oldValues, start, end);
+          if (dataset.CountMissingValues(variableName, start, end) < (end - start) && dataset.GetRange(variableName, start, end) > 0.0) {
+            mean = dataset.GetMean(variableName, start, end);
+            oldValues = dirtyDataset.ReplaceVariableValues(variableName, Enumerable.Repeat(mean, end - start), start, end);
+            newValues = predictor.Predict(dirtyDataset, start, end);
+            evaluationImpacts[variableName] = 1 - CalculateVAF(referenceValues, newValues);
+            dirtyDataset.ReplaceVariableValues(variableName, oldValues, start, end);
+          } else {
+            evaluationImpacts[variableName] = 0.0;
+          }
         }
       }

trunk/sources/HeuristicLab.Modeling/3.2/VariableQualityImpactCalculator.cs

@@ -99 +99 @@
 
       foreach (string variableName in variables) {
-        if (variableName != targetVariableName) {
+        if (dataset.CountMissingValues(variableName, start, end) < (end - start) &&
+          dataset.GetRange(variableName, start, end) > 0.0 &&
+          variableName != targetVariableName) {
           mean = dataset.GetMean(variableName, start, end);
           oldValues = dirtyDataset.ReplaceVariableValues(variableName, Enumerable.Repeat(mean, end - start), start, end);
@@ -106 +108 @@
           evaluationImpacts[variableName] = newMSE / oldMSE;
           dirtyDataset.ReplaceVariableValues(variableName, oldValues, start, end);
+        } else {
+          evaluationImpacts[variableName] = 1.0;
         }
       }