Changeset 2123

Timestamp:

06/28/09 16:15:10 (15 years ago)

Author:

svonolfe

Message:

Avoided possible race conditions when streaming data from/into the DB (#680)

Location:

trunk/sources

Files:

• HeuristicLab.DataAccess.ADOHelper/3.2/Session.cs (modified) (2 diffs)
• HeuristicLab.DataAccess.ADOHelper/3.2/Transaction.cs (modified) (2 diffs)
• HeuristicLab.DataAccess.ADOHelper/3.2/VarBinaryStream.cs (modified) (1 diff)
• HeuristicLab.DataAccess/3.2/Interfaces/ISession.cs (modified) (1 diff)
• HeuristicLab.Hive.Server.Core/3.2/ClientCommunicator.cs (modified) (1 diff)

trunk/sources/HeuristicLab.DataAccess.ADOHelper/3.2/Session.cs

@@ -84 +84 @@
     }
 
-    public ITransaction BeginTransaction() {
+    public ITransaction BeginTransaction(TransactionIsolationLevel isolationLevel) {
       CheckThread();
 
       if (transaction == null) {
-         transaction = new Transaction(this);
-         transaction.Connection = Connection;
+        transaction = new Transaction(this, isolationLevel);
+        transaction.Connection = Connection;
       }
 
@@ -95 +95 @@
 
       return transaction;
+    }
+
+    public ITransaction BeginTransaction() {
+      return BeginTransaction(TransactionIsolationLevel.Default);
     }
 

trunk/sources/HeuristicLab.DataAccess.ADOHelper/3.2/Transaction.cs

@@ -36 +36 @@
     private int usageCounter = 0;
 
-    public Transaction(Session session) {
+    private TransactionIsolationLevel isolationLevel;
+
+    public Transaction(Session session, TransactionIsolationLevel isolationLevel) {
       this.session = session;
+      this.isolationLevel = isolationLevel;
     }
 
@@ -53 +56 @@
             value.Open();
 
-          transaction = value.BeginTransaction(IsolationLevel.ReadCommitted);
+          if (isolationLevel == TransactionIsolationLevel.Default)
+            transaction = value.BeginTransaction(IsolationLevel.ReadCommitted);
+          else if (isolationLevel == TransactionIsolationLevel.ReadUncommitted)
+            transaction = value.BeginTransaction(IsolationLevel.ReadUncommitted);
+          else if (isolationLevel == TransactionIsolationLevel.ReadCommitted)
+            transaction = value.BeginTransaction(IsolationLevel.ReadCommitted);
+          else if (isolationLevel == TransactionIsolationLevel.RepeatableRead)
+            transaction = value.BeginTransaction(IsolationLevel.RepeatableRead);
+          else if (isolationLevel == TransactionIsolationLevel.Serializable)
+            transaction = value.BeginTransaction(IsolationLevel.Serializable);
+          else
+            transaction = value.BeginTransaction(IsolationLevel.ReadCommitted);
         }
       }

trunk/sources/HeuristicLab.DataAccess.ADOHelper/3.2/VarBinaryStream.cs

@@ -168 +168 @@
       } else {
         _ownedConnection = false;
-        _ownedTransaction = false;
 
         if (transaction != null) {
           _transaction = transaction;
+
+          _ownedTransaction = false;
+
+          if (_transaction.IsolationLevel != IsolationLevel.RepeatableRead &&
+              _transaction.IsolationLevel != IsolationLevel.Serializable) {
+            throw new ArgumentException("Transaction level must be at least repeatable read");
+          }
+        } else {
+          _transaction =
+            _connection.BeginTransaction(
+          IsolationLevel.RepeatableRead)
+            as SqlTransaction;
+
+          _ownedTransaction = true;
         }
       }

trunk/sources/HeuristicLab.DataAccess/3.2/Interfaces/ISession.cs

@@ -25 +25 @@
 
 namespace HeuristicLab.DataAccess.Interfaces {
+  public enum TransactionIsolationLevel {
+    Default, ReadUncommitted, ReadCommitted, RepeatableRead, Serializable
+  };
+
   public interface ISession {
     ISessionFactory Factory { get; }
-    
+
+    ITransaction BeginTransaction(TransactionIsolationLevel isolationLevel);
+
     ITransaction BeginTransaction();
 

trunk/sources/HeuristicLab.Hive.Server.Core/3.2/ClientCommunicator.cs

@@ -480 +480 @@
           (JobResult)formatter.Deserialize(stream);
 
-        tx = session.BeginTransaction();
+        //important - repeatable read isolation level is required here, 
+        //otherwise race conditions could occur when writing the stream into the DB
+        tx = session.BeginTransaction(
+          TransactionIsolationLevel.RepeatableRead);
 
         ResponseResultReceived response =