Changeset 2106 for trunk/sources/HeuristicLab.Persistence

Timestamp:

06/25/09 16:45:09 (16 years ago)

Author:

epitzer

Message:

Collect all exceptions during serialization and continue as far as possible. Throw a collected exception in th end. (#678)

Location:

trunk/sources/HeuristicLab.Persistence

Files:

• 3.3/Core/PersistenceException.cs (modified) (2 diffs)
• 3.3/Core/Serializer.cs (modified) (5 diffs)
• UnitTests/UseCases.cs (modified) (1 diff)

trunk/sources/HeuristicLab.Persistence/3.3/Core/PersistenceException.cs

@@ -4 +4 @@
 using HeuristicLab.Persistence.Core.Tokens;
 using HeuristicLab.Persistence.Default.CompositeSerializers.Storable;
+using System.Text;
 
 namespace HeuristicLab.Persistence.Core {
@@ -12 +13 @@
     public PersistenceException(string message) : base(message) { }
     public PersistenceException(string message, Exception innerException) :  base(message, innerException) { }
+    public PersistenceException(string message, IEnumerable<Exception> innerExceptions)
+      : base(message) {
+      int i = 0;
+      foreach (var x in innerExceptions) {
+        i += 1;
+        this.Data.Add("Inner Exception " + i, x);
+      }
+    }
+    public override string ToString() {
+      var sb = new StringBuilder()
+        .Append(base.ToString())
+        .Append('\n');
+      foreach (Exception x in Data.Values) {
+        sb.Append(x.ToString()).Append('\n');
+      }
+      return sb.ToString();
+    }
   }
   

trunk/sources/HeuristicLab.Persistence/3.3/Core/Serializer.cs

@@ -34 +34 @@
     private readonly Dictionary<Type, int> typeCache;
     private readonly Configuration configuration;
+    private readonly bool isTestRun;
+    private readonly List<Exception> exceptions;
 
     public List<TypeMapping> TypeCache {
@@ -78 +80 @@
       this(obj, configuration, "ROOT") { }
 
-    public Serializer(object obj, Configuration configuration, string rootName) {
+    public Serializer(object obj, Configuration configuration, string rootName)
+      : this(obj, configuration, rootName, false) { }
+
+    public Serializer(object obj, Configuration configuration, string rootName, bool isTestRun) {
+    
       this.obj = obj;
       this.rootName = rootName;
@@ -84 +90 @@
       obj2id = new Dictionary<object, int>(new ReferenceEqualityComparer()) { { new object(), 0 } };
       typeCache = new Dictionary<Type, int>();
+      this.isTestRun = isTestRun;
+      this.exceptions = new List<Exception>();
     }
 
@@ -91 +99 @@
 
     public IEnumerator<ISerializationToken> GetEnumerator() {
-      return Serialize(new DataMemberAccessor(rootName, null, () => obj, null));
+      var enumerator = Serialize(new DataMemberAccessor(rootName, null, () => obj, null));
+      if (isTestRun) {
+        return AddExceptionCompiler(enumerator);
+      } else {
+        return enumerator;
+      }
+    }
+
+    public IEnumerator<ISerializationToken> AddExceptionCompiler(IEnumerator<ISerializationToken> enumerator) {
+      while (enumerator.MoveNext())
+        yield return enumerator.Current;
+      if (exceptions.Count == 1)
+        throw exceptions[0];
+      if (exceptions.Count > 1)
+        throw new PersistenceException("Multiple exceptions during serialization", exceptions);
     }
 
@@ -109 +131 @@
         obj2id.Add(value, (int)id);
       }
-      IPrimitiveSerializer primitiveSerializer = configuration.GetPrimitiveSerializer(type);
-      if (primitiveSerializer != null)
-        return PrimitiveEnumerator(accessor.Name, typeId, primitiveSerializer.Format(value), id);
-      ICompositeSerializer compositeSerializer = configuration.GetCompositeSerializer(type);
-      if (compositeSerializer != null)
-        return CompositeEnumerator(accessor.Name, compositeSerializer.Decompose(value), id, typeId, compositeSerializer.CreateMetaInfo(value));
-      throw new PersistenceException(
-          String.Format(
-          "No suitable method for serializing values of type \"{0}\" found\r\n" +
-          "primitive serializers:\r\n{1}\r\n" +
-          "composite serializers:\r\n{2}",
-          value.GetType().VersionInvariantName(),
-          string.Join("\r\n", configuration.PrimitiveSerializers.Select(f => f.GetType().VersionInvariantName()).ToArray()),
-          string.Join("\r\n", configuration.CompositeSerializers.Select(d => d.GetType().VersionInvariantName()).ToArray())
-          ));
-
+      try {
+        IPrimitiveSerializer primitiveSerializer = configuration.GetPrimitiveSerializer(type);
+        if (primitiveSerializer != null)
+          return PrimitiveEnumerator(accessor.Name, typeId, primitiveSerializer.Format(value), id);
+        ICompositeSerializer compositeSerializer = configuration.GetCompositeSerializer(type);
+        if (compositeSerializer != null)
+          return CompositeEnumerator(accessor.Name, compositeSerializer.Decompose(value), id, typeId, compositeSerializer.CreateMetaInfo(value));
+        throw new PersistenceException(
+            String.Format(
+            "No suitable method for serializing values of type \"{0}\" found\r\n" +
+            "primitive serializers:\r\n{1}\r\n" +
+            "composite serializers:\r\n{2}",
+            value.GetType().VersionInvariantName(),
+            string.Join("\r\n", configuration.PrimitiveSerializers.Select(f => f.GetType().VersionInvariantName()).ToArray()),
+            string.Join("\r\n", configuration.CompositeSerializers.Select(d => d.GetType().VersionInvariantName()).ToArray())
+            ));
+      } catch (Exception x) {
+        if (isTestRun) {
+          exceptions.Add(x);
+          return new List<ISerializationToken>().GetEnumerator();
+        } else {
+          throw x;
+        }
+      }
     }
 

trunk/sources/HeuristicLab.Persistence/UnitTests/UseCases.cs

@@ -506 +506 @@
 
     [TestMethod]
+    public void TestMultipleFailure() {
+      List<NonSerializable> l = new List<NonSerializable>();
+      l.Add(new NonSerializable());
+      l.Add(new NonSerializable());
+      l.Add(new NonSerializable());
+      try {
+        Serializer s = new Serializer(l,
+          ConfigurationService.Instance.GetConfiguration(new XmlFormat()),
+          "ROOT", true);
+        StringBuilder tokens = new StringBuilder();
+        foreach (var token in s) {
+          tokens.Append(token.ToString());
+        }
+        Assert.Fail("Exception expected");
+      } catch (PersistenceException px) {
+        Assert.AreEqual(3, px.Data.Count);
+      }
+    }
+
+    [TestMethod]
     public void TestAssemblyVersionCheck() {
       IntWrapper i = new IntWrapper(1);