Changeset 2093

Timestamp:

06/25/09 12:41:40 (15 years ago)

Author:

mbecirov

Message:

#586: Fixed access on projects that causes a null-reference.

File:

• trunk/sources/HeuristicLab.Hive.Server.Core/3.2/Authorization/HivePermissionManager.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Hive.Server.Core/3.2/Authorization/HivePermissionManager.cs

@@ -51 +51 @@
       p = policyCollection[policyName].GetPermissionByContext("Project");
       //check if user has 'xxx.Project' permission
-      if (p != null)
-        //TODO: Test auf NULL von Project!  
-        if (CheckPermission(sessionID, p.Id, jobManager.GetJobById(entityID).Obj.Project.Id)) return;
-
+      if ((p != null) && (entityID!=Guid.Empty))
+      {
+          ResponseObject<Job> job = jobManager.GetJobById(entityID);
+          if (job.Obj.Project != null)
+              if (CheckPermission(sessionID, p.Id, jobManager.GetJobById(entityID).Obj.Project.Id)) return;
+      }
       //check if this policy has a permission with 'OWNER' scope defined
       p = policyCollection[policyName].GetPermissionByContext("User");
@@ -60 +62 @@
       if (p != null)
         if (CheckPermission(sessionID, p.Id, jobManager.GetJobById(entityID).Obj.UserId)) return;
+
       //throw an exception when user access fails
       //throw new PermissionException(policyName);