Changeset 2082 for trunk/sources/HeuristicLab.DataAccess.ADOHelper

Timestamp:

06/23/09 11:35:41 (16 years ago)

Author:

svonolfe

Message:

Avoid out of memory exceptions related to job objects (#372)

File:

• trunk/sources/HeuristicLab.DataAccess.ADOHelper/3.2/DataAdapterBase.cs (modified) (7 diffs)

trunk/sources/HeuristicLab.DataAccess.ADOHelper/3.2/DataAdapterBase.cs

@@ -82 +82 @@
 
     protected delegate IEnumerable<RowT> Selector();
+    protected delegate object TransactionalAction();
 
     protected ObjT Convert(RowT row, ObjT obj) {
@@ -109 +110 @@
 
     protected ObjT FindSingle(Selector selector) {
-      ITransaction trans =
-       session.GetCurrentTransaction();
-      bool transactionExists = trans != null;
-      if (!transactionExists) {
-        trans = session.BeginTransaction();
-      }
-
-      try {
-        RowT row = FindSingleRow(selector);
-
-        ObjT result;
-        if (row != null) {
-          ObjT obj = new ObjT();
-          obj = Convert(row, obj);
-
-          result = obj;
-        } else {
-          result = default(ObjT);
-        }
-
-        return result;
-      }
-      finally {
-        if (!transactionExists && trans != null) {
-          trans.Commit();
-        }
-      }
+      return 
+        (ObjT)doInTransaction(
+         delegate() {
+          RowT row = FindSingleRow(selector);
+
+          ObjT result;
+          if (row != null) {
+            ObjT obj = new ObjT();
+            obj = Convert(row, obj);
+
+            result = obj;
+          } else {
+            result = default(ObjT);
+          }
+
+          return result;
+        });
     }
 
     private ICollection<ObjT> FindMultiple(Selector selector, 
       int from, int size) {
-      ITransaction trans =
-       session.GetCurrentTransaction();
-      bool transactionExists = trans != null;
-      if (!transactionExists) {
-        trans = session.BeginTransaction();
-      }
-
-      try {
-        IEnumerable<RowT> found =
-          selector();
-
-        if (from > 0 && size > 0)
-          found = found.Skip<RowT>(from).Take<RowT>(size);
-
-        IList<ObjT> result =
-          new List<ObjT>();
-
-        foreach (RowT row in found) {
-          ObjT obj = new ObjT();
-          obj = Convert(row, obj);
-          if (obj != null)
-            result.Add(obj);
-        }
-
-        return result;
-      }
-      finally {
-        if (!transactionExists && trans != null) {
-          trans.Commit();
-        }
-      }     
+      return (ICollection<ObjT>)doInTransaction(
+        delegate() {
+          IEnumerable<RowT> found =
+            selector();
+
+          if (from > 0 && size > 0)
+            found = found.Skip<RowT>(from).Take<RowT>(size);
+
+          IList<ObjT> result =
+            new List<ObjT>();
+
+          foreach (RowT row in found) {
+            ObjT obj = new ObjT();
+            obj = Convert(row, obj);
+            if (obj != null)
+              result.Add(obj);
+          }
+
+          return result;
+        });   
     }
 
@@ -185 +165 @@
     }
 
-    protected virtual void doUpdate(ObjT obj) {
-      if (obj != null) {
-        RowT row = null;
-
-        if (obj.Id != Guid.Empty) {
-          row = GetRowById(obj.Id);
-        } else {
-          obj.Id = Guid.NewGuid();
-        }
-
-        if (row == null) {
-          row = dataAdapter.InsertNewRow(obj);
-        }
-
-        ConvertObj(obj, row);
-        dataAdapter.UpdateRow(row);
-      }
-    }
-
-    public void Update(ObjT obj) {
+    protected object doInTransaction(TransactionalAction action) {
       ITransaction trans =
         session.GetCurrentTransaction();
@@ -213 +174 @@
 
       try {
-        doUpdate(obj);
+        bool result = (bool)action();
+
+        if (!transactionExists && trans != null) {
+            trans.Commit();
+        }
+
+        return result;
+      }
+      catch (Exception e) {
+        if (!transactionExists && trans != null) {
+          trans.Rollback();
+        }
+
+        throw e;
+      }
+    }
+
+    protected virtual void doUpdate(ObjT obj) {
+      if (obj != null) {
+        RowT row = null;
+
+        if (obj.Id != Guid.Empty) {
+          row = GetRowById(obj.Id);
+        } else {
+          obj.Id = Guid.NewGuid();
+        }
+
+        if (row == null) {
+          row = dataAdapter.InsertNewRow(obj);
+        }
+
+        ConvertObj(obj, row);
+        dataAdapter.UpdateRow(row);
+      }
+    }
+
+    public void Update(ObjT obj) {
+      try {
+        doInTransaction(
+          delegate() {
+            doUpdate(obj);
+            return true;
+          });        
       }
       catch (DBConcurrencyException ex) {
@@ -234 +237 @@
         //otherwise: row was deleted in the meantime - nothing to do
       }
-      finally {
-        if (!transactionExists && trans != null) {
-          trans.Commit();
-        }
-      }
     }
 
@@ -282 +280 @@
 
     public bool Delete(ObjT obj) {
-      ITransaction trans =
-        session.GetCurrentTransaction();
-      bool transactionExists = trans != null;
-      if (!transactionExists) {
-        trans = session.BeginTransaction();
-      }
-
       try {
-        return doDelete(obj);
+        return (bool)doInTransaction(
+          delegate() {
+            return doDelete(obj);
+          });
       }
       catch (DBConcurrencyException) {
@@ -303 +297 @@
         }
       }
-      finally {
-        if (!transactionExists && trans != null) {
-          trans.Commit();
-        }
-      }  
     }
   }