Free cookie consent management tool by TermsFeed Policy Generator

Changeset 18057


Ignore:
Timestamp:
09/20/21 17:20:22 (3 years ago)
Author:
dpiringe
Message:

#3026

  • fixed a bug with dynamic casting in EnumTypeConverter
  • reworked RegressionProblemDataConverter
    • the target type is now: ValueParameter<IRegressionProblemData>
    • removed all dynamic/reflection code
    • reduced a lot of complexity
    • now it works with different variables (the Variable symbol bug should be fixed)
Location:
branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/EnumTypeConverter.cs

    r18043 r18057  
    1212      (t.IsGenericType && t.GetGenericTypeDefinition() == typeof(EnumValue<>));
    1313
    14     public override void Inject(IItem item, IJsonItem data, IJsonItemConverter root) =>
    15       ((dynamic)item).Value = Enum.Parse(
    16         item.GetType().GenericTypeArguments.First(), 
     14    public override void Inject(IItem item, IJsonItem data, IJsonItemConverter root) {
     15      ((dynamic)item).Value = (dynamic)Enum.Parse(
     16        item.GetType().GenericTypeArguments.First(),
    1717        ((StringJsonItem)data).Value);
     18    }
     19     
    1820   
    1921    public override IJsonItem Extract(IItem value, IJsonItemConverter root) {

  • branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/RegressionProblemDataConverter.cs

    r18056 r18057  
    11using System;
    2 using System.Collections;
    32using System.Collections.Generic;
    43using System.Linq;
    5 using System.Reflection;
    64using HeuristicLab.Core;
    75using HeuristicLab.Data;
    … …  
    1210  public class RegressionProblemDataConverter : BaseConverter {
    1311    #region Constants
    14     private const BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance;
    1512    private const string TestPartition = "TestPartition";
    1613    private const string TrainingPartition = "TrainingPartition";
    … …  
    1815    private const string AllowedInputVariables = "AllowedInputVariables";
    1916    private const string Dataset = "Dataset";
    20     private const string VariableValues = "variableValues";
    21     private const string VariableNames = "variableNames";
    22     private const string InputVariables = "InputVariables";
    23     private const string VariableRanges = "VariableRanges";
    24     private const string Rows = "rows";
    25     private const string Value = "value";
    26     private const string Parameters = "parameters";
    27     private const string CheckedItemList = "CheckedItemList";
    2817    #endregion
    2918
    30     public override int Priority => 20;//20;
     19    public override int Priority => 20;
    3120
    3221    public override bool CanConvertType(Type t) => t == typeof(ValueParameter<IRegressionProblemData>);
    33       //HEAL.Attic.Mapper.StaticCache.GetType(new Guid("EE612297-B1AF-42D2-BF21-AF9A2D42791C")).IsAssignableFrom(t); // IRegressionProblemData
    3422
    3523    public override void Inject(IItem item, IJsonItem data, IJsonItemConverter root) {
    36 
    37       var tmp = item as IRegressionProblemData; //ModifiableDataset
    38       //tmp.InputVariables
    39      
    40 
    41       dynamic regressionProblemData = (dynamic)item;
     24      var parameter = item as ValueParameter<IRegressionProblemData>;
    4225
    4326      DoubleMatrixJsonItem dataset = null;
    … …  
    4730      StringArrayJsonItem allowedInputVariables = null;
    4831
    49       // search first for the items (cache them, because the
    50       // order is important for injection)
     32      // get all child items
    5133      foreach (var child in data.Children) {
    5234        if (child.Path.EndsWith(Dataset))
    … …  
    7254      }
    7355
    74       // inject the value of the items
    75       SetDataset(regressionProblemData, dataset);
    76       SetTargetVariable(regressionProblemData, targetVariable);
    77       SetAllowedInputVariables(regressionProblemData, allowedInputVariables, dataset);
    78       SetTestPartition(regressionProblemData, testPartition);
    79       SetTrainingPartition(regressionProblemData, trainingPartition);
    80       SetVariableRanges(regressionProblemData, dataset);
     56      // create the new problemData object
     57      var problemData = new RegressionProblemData(
     58        new Dataset(dataset.ColumnNames, dataset.Value),
     59        allowedInputVariables.Value,
     60        targetVariable.Value);
     61
     62      // set the new problemData
     63      parameter.Value = problemData;
    8164    }
    8265
    8366    public override IJsonItem Extract(IItem value, IJsonItemConverter root) {
     67      var parameter = value as ValueParameter<IRegressionProblemData>;
     68      var problemData = parameter.Value;
     69
    8470      IJsonItem item = new EmptyJsonItem() {
    85         Name = value.ItemName,
    86         Description = value.ItemDescription
     71        Name = parameter.Name,
     72        Description = problemData.ItemDescription
    8773      };
    8874
    89       IJsonItem ds = GetDataset(value);
    90       if(ds != null)
    91         item.AddChildren(ds);
     75      item.AddChildren(GetDataset(parameter.Value.Dataset));
     76      item.AddChildren(GetTestPartition(problemData.TestPartition));
     77      item.AddChildren(GetTrainingPartition(problemData.TrainingPartition));
     78      item.AddChildren(GetTargetVariable(problemData.TargetVariable, problemData.Dataset.VariableNames));
     79      item.AddChildren(GetAllowedInputVariables(problemData.AllowedInputVariables, problemData.Dataset.VariableNames));
    9280
    93       item.AddChildren(GetTestPartition(value));
    94       item.AddChildren(GetTrainingPartition(value));
    95       item.AddChildren(GetTargetVariable(value));
    96       item.AddChildren(GetAllowedInputVariables(value));
    9781      return item;
    9882    }
    9983
    100     #region Inject Helper
    101     private void SetDataset(dynamic regressionProblemData, DoubleMatrixJsonItem item) {
    102       if (item != null) {
    103         var dictTmp = new Dictionary<string, IList>();
    104         int c = 0;
    105         foreach (var col in item.ColumnNames) {
    106           dictTmp.Add(col, new List<double>(item.Value[c]));
    107           ++c;
    108         }
     84    #region Extract Helper
     85    private IJsonItem GetDataset(IDataset dataset) {
     86      int variableCount = dataset.VariableNames.Count();
     87      var matrix = new double[variableCount][];
     88      int count = 0;
    10989
    110         object dataset = (object)regressionProblemData.Dataset;
    111         var rows = dataset.GetType().GetField(Rows, flags);
    112         rows.SetValue(dataset, item.Value[0].Length);
    113 
    114         var variableNames = dataset.GetType().GetField(VariableNames, flags);
    115         variableNames.SetValue(dataset, item.ColumnNames);
    116 
    117         var dataInfo = dataset.GetType().GetField(VariableValues, flags);
    118         dataInfo.SetValue(dataset, dictTmp);
    119       }
    120     }
    121 
    122     private void SetTestPartition(dynamic regressionProblemData, IntRangeJsonItem item) {
    123       if (item != null) {
    124         regressionProblemData.TestPartition.Start = item.MinValue;
    125         regressionProblemData.TestPartition.End = item.MaxValue;
    126       }
    127     }
    128 
    129     private void SetTrainingPartition(dynamic regressionProblemData, IntRangeJsonItem item) {
    130       if (item != null) {
    131         regressionProblemData.TrainingPartition.Start = item.MinValue;
    132         regressionProblemData.TrainingPartition.End = item.MaxValue;
    133       }
    134     }
    135 
    136     private void SetTargetVariable(dynamic regressionProblemData, StringJsonItem item) {
    137       if (item != null) {
    138         var param = (IConstrainedValueParameter<StringValue>)regressionProblemData.TargetVariableParameter;
    139         StringValue v = param.Value;
    140         FieldInfo fi = v.GetType().GetField(Value, flags);
    141         fi.SetValue(v, item.Value);
    142       }
    143     }
    144 
    145     private void SetAllowedInputVariables(dynamic regressionProblemData, StringArrayJsonItem item, IMatrixJsonItem matrix) {
    146       if (item != null && regressionProblemData is IParameterizedItem p) {
    147        
    148         var regProbDataType = ((ParameterizedNamedItem)regressionProblemData).GetType(); //RegressionProblemData
    149 
    150         var parameterizedNamedItemType = regProbDataType.BaseType.BaseType;
    151 
    152         // reset parameter
    153         var parametersInfo = parameterizedNamedItemType.GetField(Parameters, flags);
    154         ParameterCollection col = (ParameterCollection)parametersInfo.GetValue((object)regressionProblemData);
    155         var oldParam = (FixedValueParameter<ReadOnlyCheckedItemList<StringValue>>)col[InputVariables];
    156         var value = oldParam.Value;
    157         PropertyInfo listInfo = value.GetType().GetProperty(CheckedItemList, flags);
    158         CheckedItemList<StringValue> checkedItemList = (CheckedItemList<StringValue>)listInfo.GetValue(value);
    159         checkedItemList.Clear();
    160 
    161         // add list items and set their check state (based on allowed input variables)
    162         foreach(var i in matrix.ColumnNames) {
    163           bool isChecked = false;
    164           foreach(var x in item.Value)
    165             isChecked = isChecked || (x == i);
    166           checkedItemList.Add(new StringValue(i).AsReadOnly(), isChecked);
    167         }
    168       }
    169     }
    170 
    171     private void SetVariableRanges(dynamic regressionProblemData, DoubleMatrixJsonItem item) {
    172       if (item != null) {
    173         IntervalCollection variableRanges = (IntervalCollection)regressionProblemData.VariableRanges;
    174 
    175         foreach(var kvp in variableRanges.GetDictionary()) {
    176           variableRanges.DeleteInterval(kvp.Key);
    177         }
    178        
    179         int count = 0;
    180         foreach (var column in item.ColumnNames) {
    181           var doubleValuesForColumn = item.Value[count];
    182           if (doubleValuesForColumn.Any(x => double.IsNaN(x))) // add a NaN interval if any NaN value exists
    183             variableRanges.AddInterval(column, new Interval(double.NaN, double.NaN));
    184           else
    185             variableRanges.AddInterval(column, new Interval(doubleValuesForColumn.Min(), doubleValuesForColumn.Max()));
     90      foreach(var variable in dataset.VariableNames) {
     91        if(count < variableCount) {
     92          matrix[count] = dataset.GetDoubleValues(variable).ToArray();
    18693          count++;
    18794        }
    18895      }
     96
     97      return new DoubleMatrixJsonItem() {
     98        Name = Dataset,
     99        Value = matrix,
     100        ColumnNames = dataset.ColumnNames,
     101        Minimum = double.MinValue,
     102        Maximum = double.MaxValue
     103      };
    189104    }
    190105
    191     private void SetShapeConstraints() {
    192       // TODO
    193     }
    194     #endregion
    195 
    196     #region Extract Helper
    197     private IJsonItem GetDataset(IItem item) {
    198       dynamic val = (dynamic)item;
    199       object dataset = (object)val.Dataset;
    200       FieldInfo dataInfo = dataset.GetType().GetField(VariableValues, flags);
    201 
    202       if (dataInfo.GetValue(dataset) is Dictionary<string, IList> dict) {
    203         IEnumerator it = dict.Values.First()?.GetEnumerator();
    204 
    205         if(it != null) {
    206           if(it.MoveNext() && it.Current is double) {
    207             CreateMatrix(dict, out IList<string> columnNames, out double[][] mat);
    208             return new DoubleMatrixJsonItem() {
    209               Name = Dataset,
    210               Value = mat,
    211               ColumnNames = columnNames,
    212               Minimum = double.MinValue,
    213               Maximum = double.MaxValue
    214             };
    215           } else if(it.Current is int) {
    216             CreateMatrix(dict, out IList<string> columnNames, out int[][] mat);
    217             return new IntMatrixJsonItem() {
    218               Name = Dataset,
    219               Value = mat,
    220               ColumnNames = columnNames,
    221               Minimum = int.MinValue,
    222               Maximum = int.MaxValue
    223             };
    224           } else if (it.Current is bool) {
    225             CreateMatrix(dict, out IList<string> columnNames, out bool[][] mat);
    226             return new BoolMatrixJsonItem() {
    227               Name = Dataset,
    228               Value = mat,
    229               ColumnNames = columnNames
    230             };
    231           }
    232         }
    233       }
    234       return null;
    235     }
    236    
    237     private void CreateMatrix<T>(Dictionary<string, IList> dict, out IList<string> columnNames, out T[][] matrix) {
    238       int cols = dict.Count, rows = 0, c = 0;
    239       columnNames = new List<string>();
    240       matrix = new T[cols][];
    241       foreach (var x in dict) {
    242         rows = Math.Max(rows, x.Value.Count);
    243         columnNames.Add(x.Key);
    244 
    245         matrix[c] = new T[rows];
    246 
    247         int r = 0;
    248         foreach (var cellValue in x.Value) {
    249           try {
    250             matrix[c][r] = (T)cellValue;
    251           } catch (Exception e) {
    252             throw new AggregateException($"The cell value '{cellValue}' in row {r} cannot be converted to {typeof(T).FullName}.", e);
    253           }
    254           ++r;
    255         }
    256         ++c;
    257       }
    258     }
    259 
    260     private IJsonItem GetTestPartition(IItem item) {
    261       dynamic val = (dynamic)item;
    262       var trainingPartition = (IntRange)val.TrainingPartition;
    263       var testPartition = (IntRange)val.TestPartition;
    264       return new IntRangeJsonItem() {
     106    private IJsonItem GetTestPartition(IntRange testPartition) =>
     107      new IntRangeJsonItem() {
    265108        Name = TestPartition,
    266109        MinValue = testPartition.Start,
    267110        MaxValue = testPartition.End,
    268111        Minimum = 0,
    269         Maximum = int.MaxValue //Math.Max(testPartition.End, trainingPartition.End)
     112        Maximum = int.MaxValue
    270113      };
    271     }
    272114
    273     private IJsonItem GetTrainingPartition(IItem item) {
    274       dynamic val = (dynamic)item;
    275       var trainingPartition = (IntRange)val.TrainingPartition;
    276       var testPartition = (IntRange)val.TestPartition;
    277       return new IntRangeJsonItem() {
     115    private IJsonItem GetTrainingPartition(IntRange trainingPartition) =>
     116      new IntRangeJsonItem() {
    278117        Name = TrainingPartition,
    279118        MinValue = trainingPartition.Start,
    280119        MaxValue = trainingPartition.End,
    281120        Minimum = 0,
    282         Maximum = int.MaxValue //Math.Max(testPartition.End, trainingPartition.End)
     121        Maximum = int.MaxValue
    283122      };
    284     }
    285123
    286124
    287     private IJsonItem GetTargetVariable(IItem item) {
    288       var vars = (IEnumerable<StringValue>)((dynamic)item).InputVariables;
    289       return new StringJsonItem() {
     125    private IJsonItem GetTargetVariable(string targetVariable, IEnumerable<string> variables) =>
     126      new StringJsonItem() {
    290127        Name = TargetVariable,
    291         Value = (string)((dynamic)item).TargetVariable,
    292         ConcreteRestrictedItems = vars.Select(x => x.Value)
     128        Value = targetVariable,
     129        ConcreteRestrictedItems = variables
    293130      };
    294     }
    295131
    296     private IJsonItem GetAllowedInputVariables(IItem item) {
    297       var vars = (IEnumerable<StringValue>)((dynamic)item).InputVariables;
    298       return new StringArrayJsonItem() {
     132    private IJsonItem GetAllowedInputVariables(IEnumerable<string> allowedVariables, IEnumerable<string> variables) =>
     133      new StringArrayJsonItem() {
    299134        Name = AllowedInputVariables,
    300         Value = ((IEnumerable<string>)((dynamic)item).AllowedInputVariables).ToArray(),
    301         ConcreteRestrictedItems = vars.Select(x => x.Value)
     135        Value = allowedVariables.ToArray(),
     136        ConcreteRestrictedItems = variables
    302137      };
    303     }
    304138    #endregion
    305139  }
Note: See TracChangeset for help on using the changeset viewer.