Changeset 17781

Timestamp:

11/18/20 10:58:03 (4 years ago)

Author:

jkarder

Message:

#3089: explicitly fail on ReflectionTypeLoadException and BadImageFormatException

Location:

trunk/HeuristicLab.Tests

Files:

• HeuristicLab-3.3/PluginDependenciesTest.cs (modified) (1 diff)
• HeuristicLab.Persistence.Attic/PersistenceConsistencyChecks.cs (modified) (2 diffs)

trunk/HeuristicLab.Tests/HeuristicLab-3.3/PluginDependenciesTest.cs

@@ -39 +39 @@
     [ClassInitialize]
     public static void MyClassInitialize(TestContext testContext) {
-      loadedPlugins = PluginLoader.Assemblies.Where(PluginLoader.IsPluginAssembly).ToDictionary(a => a, GetPluginFromAssembly);
+      try {
+        loadedPlugins = PluginLoader.Assemblies.Where(PluginLoader.IsPluginAssembly).ToDictionary(a => a, GetPluginFromAssembly);
+      } catch (BadImageFormatException e) {
+        var message = string.Join(Environment.NewLine, "Could not load all types. Check if test process architecture is set to x64.", string.Empty, "Exception:", e);
+        Assert.Fail(message);
+      }
+
       pluginNames = loadedPlugins.ToDictionary(a => a.Key.GetName().FullName, a => GetPluginName(a.Value));
 

trunk/HeuristicLab.Tests/HeuristicLab.Persistence.Attic/PersistenceConsistencyChecks.cs

@@ -2 +2 @@
 using System.Collections.Generic;
 using System.Linq;
+using System.Reflection;
 using HEAL.Attic;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
@@ -16 +17 @@
       var dict = new Dictionary<Guid, string>();
       var duplicates = new Dictionary<string, string>();
-      // using AppDomain instead of ApplicationManager so that NonDiscoverableTypes are also checked
-      foreach (Type type in AppDomain.CurrentDomain.GetAssemblies().SelectMany(x => x.GetTypes())) {
-        var attr = StorableTypeAttribute.GetStorableTypeAttribute(type);
-        if (attr == null)
-          continue;
 
-        foreach (var guid in attr.Guids) {
-          if (!dict.ContainsKey(guid)) {
-            dict.Add(guid, type.FullName);
-          } else {
-            duplicates.Add(type.FullName, dict[guid]);
+      try {
+        // using AppDomain instead of ApplicationManager so that NonDiscoverableTypes are also checked
+        foreach (Type type in AppDomain.CurrentDomain.GetAssemblies().SelectMany(x => x.GetTypes())) {
+          var attr = StorableTypeAttribute.GetStorableTypeAttribute(type);
+          if (attr == null)
+            continue;
+
+          foreach (var guid in attr.Guids) {
+            if (!dict.ContainsKey(guid)) {
+              dict.Add(guid, type.FullName);
+            } else {
+              duplicates.Add(type.FullName, dict[guid]);
+            }
           }
         }
+      } catch (ReflectionTypeLoadException e) {
+        var loaderExeptions = string.Join("-----" + Environment.NewLine, e.LoaderExceptions.Select(x => x.ToString()));
+        var message = string.Join(Environment.NewLine, "Could not load all types. Check if test process architecture is set to x64.",
+          string.Empty, "Exception:", e, string.Empty, "LoaderExceptions:", loaderExeptions);
+        Assert.Fail(message);
       }