Changeset 17694 for branches/2521_ProblemRefactoring/HeuristicLab.Parameters

Timestamp:

07/23/20 14:18:19 (4 years ago)

Author:

abeham

Message:

#2521: fixed encoding change of JSSP, added tostring and itemimage change to ValueChanged event of ReferenceParameter

File:

• branches/2521_ProblemRefactoring/HeuristicLab.Parameters/3.3/ReferenceParameter.cs (modified) (4 diffs)

branches/2521_ProblemRefactoring/HeuristicLab.Parameters/3.3/ReferenceParameter.cs

@@ -110 +110 @@
     }
 
+    // TODO: Remove
+    //protected void ChangeReference(IValueParameter newReference, bool retainData) {
+    //  IItem oldValue = Value;
+    //  var oldRef = ReferencedParameter;
+    //  oldRef.ToStringChanged -= (o, e) => OnToStringChanged();
+    //  oldRef.ItemImageChanged -= (o, e) => OnItemImageChanged();
+    //  if (valueChanged != null) oldRef.ValueChanged -= OnReferencedParameterValueChanged;
+    //  newReference.ToStringChanged += (o, e) => OnToStringChanged();
+    //  newReference.ItemImageChanged += (o, e) => OnItemImageChanged();
+    //  if (valueChanged != null) newReference.ValueChanged += OnReferencedParameterValueChanged;
+    //  ReferencedParameter = newReference;
+    //  oldRef.Value = (IItem)oldValue.Clone(); // This is problematic, e.g. FixedValueParameter !!! But necessary, otherwise the value holds reference to the old parameter
+    //  if (retainData) Value = oldValue;
+    //}
+
 
     #region event handlers
@@ -128 +143 @@
     private void OnReferencedParameterValueChanged(object sender, EventArgs args) {
       valueChanged?.Invoke(this, args); // note "this", not "sender" as sender would be the referenced parameter
+      OnItemImageChanged();
+      OnToStringChanged();
     }
 
@@ -166 +183 @@
       return new ReferenceParameter<T>(this, cloner);
     }
+
+    // TODO: Remove
+    //public void ChangeReference(IValueParameter<T> newParameter, bool retainData) {
+    //  base.ChangeReference(newParameter, retainData);
+    //}
   }
 
@@ -193 +215 @@
       return new ReferenceParameter<T, U>(this, cloner);
     }
+
+    // TODO: Remove
+    //public void ChangeReference(IValueParameter<U> newParameter, bool retainData) {
+    //  base.ChangeReference(newParameter, retainData);
+    //}
   }
 }