Changeset 17315 for branches/2521_ProblemRefactoring/HeuristicLab.Data/3.3

Timestamp:

10/04/19 14:23:08 (5 years ago)

Author:

abeham

Message:

#2521: reverted r17309

Location:

branches/2521_ProblemRefactoring/HeuristicLab.Data/3.3

Files:

• BoolArray.cs (modified) (2 diffs)
• StringConvertibleArray.cs (modified) (2 diffs)
• ValueTypeArray.cs (modified) (1 diff)

branches/2521_ProblemRefactoring/HeuristicLab.Data/3.3/BoolArray.cs

@@ -20 +20 @@
 #endregion
 
-using System.Collections.Generic;
 using System.Text;
 using HEAL.Attic;
@@ -38 +37 @@
     public BoolArray(int length) : base(length) { }
     public BoolArray(bool[] elements, bool @readonly = false) : base(elements, @readonly) { }
-    public BoolArray(IReadOnlyList<bool> elements) : base(elements) { }
 
     public override IDeepCloneable Clone(Cloner cloner) {

branches/2521_ProblemRefactoring/HeuristicLab.Data/3.3/StringConvertibleArray.cs

@@ -22 +22 @@
 #endregion
 
-using System.Collections.Generic;
 using HEAL.Attic;
 using HeuristicLab.Common;
@@ -39 +38 @@
     protected StringConvertibleArray(int length) : base(length) { }
     protected StringConvertibleArray(T[] elements, bool @readonly = false) : base(elements, @readonly) { }
-    protected StringConvertibleArray(IReadOnlyList<T> elements) : base(elements) { }
 
     protected abstract bool Validate(string value, out string errorMessage);

branches/2521_ProblemRefactoring/HeuristicLab.Data/3.3/ValueTypeArray.cs

@@ -138 +138 @@
     }
     protected ValueTypeArray(T[] elements, bool @readonly = false) {
-      if (elements == null) throw new ArgumentNullException(nameof(elements));
+      if (elements == null) throw new ArgumentNullException();
       array = (T[])elements.Clone();
       readOnly = @readonly;
       resizable = true;
       elementNames = new List<string>();
-    }
-    
-    protected ValueTypeArray(IReadOnlyList<T> elements) {
-      if (elements == null) throw new ArgumentNullException(nameof(elements));
-      array = elements.ToArray(); // TODO: array should be an IList<T>
-      readOnly = true;
-      resizable = true; // TODO: really?
-      elementNames = new List<string>(); // TODO: wasteful
     }