Changeset 16928

Timestamp:

05/08/19 15:56:02 (6 years ago)

Author:

chaider

Message:

#2971 Fixed cloning in ProblemDataConstraint

File:

• branches/2971_named_intervals/HeuristicLab.Problems.DataAnalysis/3.4/ProblemDataConstraint.cs (modified) (5 diffs)

branches/2971_named_intervals/HeuristicLab.Problems.DataAnalysis/3.4/ProblemDataConstraint.cs

@@ -23 +23 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using HeuristicLab.Common;
 using HeuristicLab.Core;
@@ -36 +37 @@
                                                   "d'y'/d'x' in [0 .. 10]" + Environment.NewLine +
                                                   "\u2202²'y'/\u2202'x'² in ]-1 .. inf.[";
-     
+
+    private string input;
     [Storable]
-    public string Input { get; set; }
+    public string Input {
+      get => input;
+      set {
+        if (input == value) return;
+        input = value;
+        OnChanged();
+      }
+    }
 
     private IEnumerable<IntervalConstraint> constraints;
@@ -44 +53 @@
     public IEnumerable<IntervalConstraint> Constraints {
       get => constraints;
-      set { 
+      set {
+        if (constraints == value) return;
         constraints = value;
-        OnChanged(EventArgs.Empty);
+        OnChanged();
       }
     }
@@ -58 +68 @@
       : base(original, cloner) {
       this.Input = original.Input;
-      this.constraints = original.Constraints;
-      this.ProblemData = original.ProblemData;
+      this.constraints = original.Constraints.Select(cloner.Clone);
+      this.ProblemData = cloner.Clone(original.ProblemData);
     }
 
@@ -79 +89 @@
 
     public event EventHandler Changed;
-    protected virtual void OnChanged(EventArgs e) {
+    protected virtual void OnChanged() {
       EventHandler handlers = Changed;
       if (handlers != null)
-        handlers(this, e);
+        handlers(this, EventArgs.Empty);
     }
   }