Changeset 16852 for branches/2847_M5Regression/HeuristicLab.Algorithms.DataAnalysis/3.4/M5Regression/Splitting

Timestamp:

04/19/19 15:45:45 (6 years ago)

Author:

gkronber

Message:

#2847: fixed some issues that produced errors when testing

Location:

branches/2847_M5Regression/HeuristicLab.Algorithms.DataAnalysis/3.4/M5Regression/Splitting

Files:

• M5Splitter.cs (modified) (1 diff)
• SplitterBase.cs (modified) (2 diffs)

branches/2847_M5Regression/HeuristicLab.Algorithms.DataAnalysis/3.4/M5Regression/Splitting/M5Splitter.cs

@@ -55 +55 @@
     protected override void AttributeSplit(IReadOnlyList<double> attValues, IReadOnlyList<double> targetValues, int minLeafSize, out int position, out double maxImpurity, out double splitValue) {
       position = 0;
-      maxImpurity = -1E20;
+      maxImpurity = double.NegativeInfinity;
       splitValue = 0.0;
       var length = targetValues.Count;

branches/2847_M5Regression/HeuristicLab.Algorithms.DataAnalysis/3.4/M5Regression/Splitting/SplitterBase.cs

@@ -33 +33 @@
   [Item("SplitterBase", "Abstract base class for splitters")]
   public abstract class SplitterBase : ParameterizedNamedItem, ISplitter {
-    public const string SplittingStateVariableName = "RuleSetState";
+    public const string SplittingStateVariableName = "SplittingState";
 
     #region Constructors & Cloning
@@ -80 +80 @@
 
     protected virtual bool DecideSplit(IRegressionProblemData splitData, int minLeafSize, out string splitAttr, out double splitValue) {
-      var bestPos = 0;
+      var bestPos = -1;
       var bestImpurity = double.MinValue;
       var bestSplitValue = 0.0;