Changeset 16634

Timestamp:

02/28/19 17:20:10 (5 years ago)

Author:

gkronber

Message:

#2971: disabled validation check in NamedIntervalsView because it is problematic when NamedIntervals are updated (e.g. while the algorithm is running)

File:

• branches/2971_named_intervals/HeuristicLab.Problems.DataAnalysis.Views/3.4/Regression/NamedIntervalsView.cs (modified) (4 diffs)

branches/2971_named_intervals/HeuristicLab.Problems.DataAnalysis.Views/3.4/Regression/NamedIntervalsView.cs

@@ -37 +37 @@
 
     public new NamedIntervals Content {
-      get => (NamedIntervals)base.Content; 
-      set => base.Content = value; 
+      get => (NamedIntervals)base.Content;
+      set => base.Content = value;
     }
 
@@ -82 +82 @@
       dataGridView.Rows.AddRange(rows);
 
-      setRowsHeader();
+      SetRowsHeader();
       FillRows();
 
@@ -99 +99 @@
     }
 
-    protected void setRowsHeader() {   
+    protected void SetRowsHeader() {
       for (var i = 0; i < Content.VariableIntervals.Count; ++i) {
         var item = Content.VariableIntervals.ElementAt(i);
@@ -119 +119 @@
       var upperBound = e.ColumnIndex == 1 ? double.Parse(dataGridView.Rows[e.RowIndex].Cells[e.ColumnIndex].Value.ToString()) : Content.VariableIntervals[key].UpperBound;
 
-      Content.VariableIntervals[key] = new Interval(lowerBound, upperBound);
+      // update if there was a change
+      if (lowerBound != Content.VariableIntervals[key].LowerBound ||
+        upperBound != Content.VariableIntervals[key].UpperBound)
+        Content.VariableIntervals[key] = new Interval(lowerBound, upperBound);
     }
 
     private void dataGridView_CellValidating(object sender, DataGridViewCellValidatingEventArgs e) {
-      if (dataGridView.Rows[e.RowIndex].IsNewRow) {
-        return;
-      }
+      // DISABLED VALIDATION OF ENTRIES
+      // because it leads to problems when updating the table
+      // we can assume it's the users fault if he or she enters incorrect values
 
-      if (!double.TryParse(e.FormattedValue.ToString(), out var value)) {
-        e.Cancel = true;
-        dataGridView.Rows[e.RowIndex].ErrorText = "Value must be a double value.";
-      } else {
-        if (e.ColumnIndex == 0 && value > double.Parse(dataGridView.Rows[e.RowIndex].Cells[1].Value.ToString()) ||
-            e.ColumnIndex == 1 && value < double.Parse(dataGridView.Rows[e.RowIndex].Cells[0].Value.ToString())) {
-          e.Cancel = true;
-          dataGridView.Rows[e.RowIndex].ErrorText = "Lower Bound of Interval must be smaller than Upper Bound.";
-        }
-      }
+      // if (dataGridView.Rows[e.RowIndex].IsNewRow) {
+      //   return;
+      // }
+      // 
+      // if (!double.TryParse(e.FormattedValue.ToString(), out var value)) {
+      //   e.Cancel = true;
+      //   dataGridView.Rows[e.RowIndex].ErrorText = "Value must be a double value.";
+      // } else if (string.IsNullOrEmpty(dataGridView.Rows[e.RowIndex].Cells[0].Value.ToString()) ||
+      //   string.IsNullOrEmpty(dataGridView.Rows[e.RowIndex].Cells[1].Value.ToString())) {
+      //   // accept any value if one of the cells is still empty
+      // } else {
+      //   var left = double.Parse(dataGridView.Rows[e.RowIndex].Cells[0].Value.ToString());
+      //   var right = double.Parse(dataGridView.Rows[e.RowIndex].Cells[1].Value.ToString());
+      //   if (e.ColumnIndex == 1 && value < left || e.ColumnIndex == 0 && value > right) {
+      //     e.Cancel = true;
+      //     dataGridView.Rows[e.RowIndex].ErrorText = "Lower bound of interval must be smaller than upper bound.";
+      //   }
+      // }
     }