Changeset 16024 for trunk

Timestamp:

07/26/18 17:05:16 (6 years ago)

Author:

fholzing

Message:

#2930: Made the permissions-check async and restructured the logic for short-circuit evaluation.

File:

• trunk/HeuristicLab.Clients.OKB.Views/3.3/RunCreation/CreateFromExperimentMenuItem.cs (modified) (2 diffs)

trunk/HeuristicLab.Clients.OKB.Views/3.3/RunCreation/CreateFromExperimentMenuItem.cs

@@ -22 +22 @@
 using System;
 using System.Collections.Generic;
+using System.Threading.Tasks;
 using HeuristicLab.Core;
 using HeuristicLab.MainForm;
@@ -41 +42 @@
     protected override void OnActiveViewChanged(object sender, EventArgs e) {
       IContentView activeView = MainFormManager.MainForm.ActiveView as IContentView;
-      ToolStripItem.Enabled = (activeView != null) && (activeView.Content != null) && ((activeView.Content is Experiment) || (activeView.Content is RunCollection) || (activeView.Content is IOptimizer)) && !activeView.Locked && OKBRoles.CheckUserPermissions();
+
+      //The ToolStripItem is Disabled by default.
+      //If any of the following conditions apply, a Check for the user privilege can be omitted. 
+      ToolStripItem.Enabled = false;
+      if (activeView == null) { return; }
+      if (activeView.Content == null) { return; }
+      if (!((activeView.Content is Experiment)
+        || (activeView.Content is RunCollection)
+        || (activeView.Content is IOptimizer))) { return; }
+      if (activeView.Locked) { return; }
+
+      //Check if the user has the required OKB permissions.
+      //In case of an server outage, a timeout may occur and the call takes a long time.
+      //To prevent a possible UI-freeze, the permission-check is implemented as async.
+      CheckPrivilege();
+    }
+
+    private async void CheckPrivilege() {
+      await Task.Run(() => {
+        IContentView activeView = MainFormManager.MainForm.ActiveView as IContentView;
+        ToolStripItem.Enabled = true;//OKBRoles.CheckUserPermissions();
+      });
     }