Changeset 15844 for branches/2817-BinPackingSpeedup

Timestamp:

03/16/18 13:09:14 (7 years ago)

Author:

rhanghof

Message:

#2817:

• Some bug fixes at the placing algorithm

File:

• branches/2817-BinPackingSpeedup/HeuristicLab.Problems.BinPacking/3.3/3D/Packer/BinPackerMinRSLeft.cs (modified) (9 diffs)

branches/2817-BinPackingSpeedup/HeuristicLab.Problems.BinPacking/3.3/3D/Packer/BinPackerMinRSLeft.cs

@@ -95 +95 @@
     }
 
-    
+
 
     /// <summary>
@@ -107 +107 @@
     protected virtual void PackRemainingItems(ref IList<int> remainingIds, ref BinPacking3D packingBin, IList<PackingItem> items, ExtremePointCreationMethod epCreationMethod, bool useStackingConstraints) {
       IExtremePointCreator extremePointCreator = ExtremePointCreatorFactory.CreateExtremePointCreator(epCreationMethod, useStackingConstraints);
-      
+
       var remainingNotWeightSupportedItems = new List<int>();
       foreach (var itemId in new List<int>(remainingIds)) {
@@ -118 +118 @@
         // and try to find positions where they don't waste too much space.
         // If there are no weight supporting items left the non supporting ones have to be treated as a supporting one.
-        if (item.SupportedWeight <= 0 && useStackingConstraints && remainingIds.Any(x => items[x].SupportedWeight > 0)) {
+        if (item.IsStackabel && item.SupportedWeight <= 0 && useStackingConstraints && remainingIds.Any(x => items[x].SupportedWeight > 0)) {
           remainingNotWeightSupportedItems.Add(itemId);
         } else if (!item.IsStackabel) {
@@ -127 +127 @@
             remainingIds.Remove(itemId);
           }
-        } else  {
+        } else {
           PackingPosition position = FindPackingPositionForItem(clonedPackingBin, item, useStackingConstraints);
           // if a valid packing position could be found, the current item can be added to the given bin
@@ -203 +203 @@
         }
       }
-      var d =  rsds.Where(x => packingBin.IsPositionFeasible(x.Item, x.Position, useStackingConstraints)).FirstOrDefault();
+      var d = rsds.FirstOrDefault(x => packingBin.IsPositionFeasible(x.Item, x.Position, useStackingConstraints));
 
       if (d == null) {
         return null;
       }
-
+      
       packingItem.Rotated = orientation.Item2;
       packingItem.Tilted = orientation.Item3;
@@ -255 +255 @@
           $"Item: ({packingItem.Width} {packingItem.Depth} {packingItem.Height})");
       }
-            
+
       var rsds = CalculateResidalSpaceDifferences(packingBin, packingItem, useStackingConstraints).Where(x => x != null);
       var rsd = rsds.FirstOrDefault();
@@ -266 +266 @@
       packingItem.Rotated = rsd.Item.Rotated;
       packingItem.Tilted = rsd.Item.Tilted;
-      
+
       return rsd.Position;
     }
@@ -319 +319 @@
         }
       }
-      return rsds.Where(rsd => packingBin.IsPositionFeasible(rsd.Item, rsd.Position, useStackingConstraints)).FirstOrDefault();
+
+      // If the packer uses line projection it migth happen, that an extreme point right of the disired on will be chosen.
+      // To avoid this, if there is an extreme point on the rigth side available this point will be returned.
+      var possible = rsds.Where(rsd => packingBin.IsPositionFeasible(rsd.Item, rsd.Position, useStackingConstraints));
+      var prevered = possible.FirstOrDefault();
+
+      return possible.Where(x => x.Position.Z == prevered.Position.Z && x.Position.Y == prevered.Position.Y).OrderBy(x => x.Position.X).FirstOrDefault();
     }
 
@@ -401 +407 @@
         return 0;
       }
+
+      public override string ToString() {
+        return string.Format("({1},{2},{3})", X, Y, Z);
+      }
     }