Changeset 15816

Timestamp:

02/26/18 14:13:32 (7 years ago)

Author:

fholzing

Message:

#2904: Cleaned up the method signature (some optional parameters aren't so optional)

File:

• branches/2904_CalculateImpacts/3.4/Implementation/Regression/RegressionSolutionVariableImpactsCalculator.cs (modified) (2 diffs)

branches/2904_CalculateImpacts/3.4/Implementation/Regression/RegressionSolutionVariableImpactsCalculator.cs

@@ -172 +172 @@
     public static double CalculateImpact(string variableName,
       IRegressionSolution solution,
+      IEnumerable<int> rows,
+      IEnumerable<double> targetValues,
+      double originalR2,
       DataPartitionEnum data = DataPartitionEnum.Training,
       ReplacementMethodEnum replacementMethod = ReplacementMethodEnum.Median,
-      FactorReplacementMethodEnum factorReplacementMethod = FactorReplacementMethodEnum.Best,
-      IEnumerable<int> rows = null,
-      IEnumerable<double> targetValues = null,
-    double originalR2 = -1) {
+      FactorReplacementMethodEnum factorReplacementMethod = FactorReplacementMethodEnum.Best) {
 
       double impact = 0;
@@ -219 +219 @@
           if (progressCallback((double)curIdx / count, string.Format("Calculating impact for variable {0} ({1} of {2})", inputVariable, curIdx, count))) { return null; }
         }
-        impacts[inputVariable] = CalculateImpact(inputVariable, solution, data, replacementMethod, factorReplacementMethod, rows, targetValues, originalR2);
+        impacts[inputVariable] = CalculateImpact(inputVariable, solution, rows, targetValues, originalR2, data, replacementMethod, factorReplacementMethod);
       }