Changeset 15729 for trunk/HeuristicLab.Problems.DataAnalysis.Views/3.4/Classification

Timestamp:

02/07/18 13:29:06 (7 years ago)

Author:

fholzing

Message:

#2884: Fixed crossthreading-bug

Location:

trunk/HeuristicLab.Problems.DataAnalysis.Views/3.4/Classification

Files:

• ClassificationSolutionVariableImpactsView.Designer.cs (modified) (3 diffs)
• ClassificationSolutionVariableImpactsView.cs (modified) (10 diffs)

trunk/HeuristicLab.Problems.DataAnalysis.Views/3.4/Classification/ClassificationSolutionVariableImpactsView.Designer.cs

@@ -54 +54 @@
       this.sortByLabel = new System.Windows.Forms.Label();
       this.sortByComboBox = new System.Windows.Forms.ComboBox();
+      this.backgroundWorker = new System.ComponentModel.BackgroundWorker();
       this.SuspendLayout();
       // 
@@ -168 +169 @@
       this.sortByComboBox.TabIndex = 9;
       this.sortByComboBox.SelectedIndexChanged += new System.EventHandler(this.sortByComboBox_SelectedIndexChanged);
+      // 
+      // backgroundWorker
+      // 
+      this.backgroundWorker.DoWork += new System.ComponentModel.DoWorkEventHandler(this.backgroundWorker_DoWork);
+      this.backgroundWorker.RunWorkerCompleted += new System.ComponentModel.RunWorkerCompletedEventHandler(this.backgroundWorker_RunWorkerCompleted);
       // 
       // ClassificationSolutionVariableImpactsView
@@ -202 +208 @@
     private System.Windows.Forms.Label sortByLabel;
     private System.Windows.Forms.ComboBox sortByComboBox;
+    private System.ComponentModel.BackgroundWorker backgroundWorker;
   }
 }

trunk/HeuristicLab.Problems.DataAnalysis.Views/3.4/Classification/ClassificationSolutionVariableImpactsView.cs

@@ -23 +23 @@
 using System.Collections.Generic;
 using System.Linq;
-using System.Threading.Tasks;
 using HeuristicLab.Common;
 using HeuristicLab.Data;
@@ -32 +31 @@
   [Content(typeof(IClassificationSolution))]
   public partial class ClassificationSolutionVariableImpactsView : DataAnalysisSolutionEvaluationView {
+    #region Nested Types
+    private class BackgroundWorkerArguments {
+      internal MainForm.WindowsForms.MainForm mainForm;
+      internal ClassificationSolutionVariableImpactsCalculator.ReplacementMethodEnum replMethod;
+      internal ClassificationSolutionVariableImpactsCalculator.FactorReplacementMethodEnum factorReplMethod;
+      internal ClassificationSolutionVariableImpactsCalculator.DataPartitionEnum dataPartition;
+    }
+
     private enum SortingCriteria {
       ImpactValue,
@@ -37 +44 @@
       VariableName
     }
-
+    #endregion
+
+    #region Fields
     private Dictionary<string, double> rawVariableImpacts = new Dictionary<string, double>();
-
+    #endregion
+
+    #region Getter/Setter
     public new IClassificationSolution Content {
       get { return (IClassificationSolution)base.Content; }
@@ -46 +57 @@
       }
     }
-
+    #endregion
+
+    #region Ctor
     public ClassificationSolutionVariableImpactsView()
       : base() {
@@ -55 +68 @@
       this.sortByComboBox.SelectedItem = SortingCriteria.ImpactValue;
 
+      //Set the default values
       this.dataPartitionComboBox.SelectedIndex = 0;
       this.replacementComboBox.SelectedIndex = 0;
       this.factorVarReplComboBox.SelectedIndex = 0;
     }
-
-    #region events
+    #endregion
+
+    #region Events
     protected override void RegisterContentEvents() {
       base.RegisterContentEvents();
@@ -86 +101 @@
         variableImactsArrayView.Content = null;
       } else {
-        UpdateVariableImpacts();
+        StartBackgroundWorker();
       }
     }
@@ -92 +107 @@
 
     private void dataPartitionComboBox_SelectedIndexChanged(object sender, EventArgs e) {
-      UpdateVariableImpacts();
+      StartBackgroundWorker();
     }
 
     private void replacementComboBox_SelectedIndexChanged(object sender, EventArgs e) {
-      UpdateVariableImpacts();
+      StartBackgroundWorker();
     }
 
@@ -123 +138 @@
       UpdateDataOrdering();
     }
+
+
+    private void backgroundWorker_DoWork(object sender, System.ComponentModel.DoWorkEventArgs e) {
+      variableImactsArrayView.Caption = Content.Name + " Variable Impacts";
+
+      var argument = e.Argument as BackgroundWorkerArguments;
+      if (!(argument is BackgroundWorkerArguments)) {
+        throw new ArgumentException("Argument for Backgroundworker must be of type BackgroundworkerArguments");
+      }
+
+      argument.mainForm.AddOperationProgressToView(this, "Calculating variable impacts for " + Content.Name);
+      try {
+        //Remember the original ordering of the variables
+        var impacts = ClassificationSolutionVariableImpactsCalculator.CalculateImpacts(Content, argument.dataPartition, argument.replMethod, argument.factorReplMethod);
+        var problemData = Content.ProblemData;
+        var inputvariables = new HashSet<string>(problemData.AllowedInputVariables.Union(Content.Model.VariablesUsedForPrediction));
+        var originalVariableOrdering = problemData.Dataset.VariableNames.Where(v => inputvariables.Contains(v)).Where(problemData.Dataset.VariableHasType<double>).ToList();
+
+        rawVariableImpacts.Clear();
+        originalVariableOrdering.ForEach(v => rawVariableImpacts.Add(v, impacts.First(vv => vv.Item1 == v).Item2));
+      } finally {
+        argument.mainForm.RemoveOperationProgressFromView(this);
+      }
+    }
+
+    private void backgroundWorker_RunWorkerCompleted(object sender, System.ComponentModel.RunWorkerCompletedEventArgs e) {
+      UpdateDataOrdering();
+    }
     #endregion
 
     #region Helper Methods
-    private void UpdateVariableImpacts() {
+    private void StartBackgroundWorker() {
+      //Check if the selection is valid
       if (Content == null) { return; }
       if (replacementComboBox.SelectedIndex < 0) { return; }
@@ -132 +176 @@
       if (factorVarReplComboBox.SelectedIndex < 0) { return; }
 
-      variableImactsArrayView.Caption = Content.Name + " Variable Impacts";
-
+      //Prepare arguments
       var mainForm = (MainForm.WindowsForms.MainForm)MainFormManager.MainForm;
       var replMethod = (ClassificationSolutionVariableImpactsCalculator.ReplacementMethodEnum)replacementComboBox.Items[replacementComboBox.SelectedIndex];
       var factorReplMethod = (ClassificationSolutionVariableImpactsCalculator.FactorReplacementMethodEnum)factorVarReplComboBox.Items[factorVarReplComboBox.SelectedIndex];
       var dataPartition = (ClassificationSolutionVariableImpactsCalculator.DataPartitionEnum)dataPartitionComboBox.SelectedItem;
-
-      Task.Factory.StartNew(() => {
-        try {
-          mainForm.AddOperationProgressToView(this, "Calculating variable impacts for " + Content.Name);
-
-          //Remember the original ordering of the variables
-          var impacts = ClassificationSolutionVariableImpactsCalculator.CalculateImpacts(Content, dataPartition, replMethod, factorReplMethod);
-          var problemData = Content.ProblemData;
-          var inputvariables = new HashSet<string>(problemData.AllowedInputVariables.Union(Content.Model.VariablesUsedForPrediction));
-          var originalVariableOrdering = problemData.Dataset.VariableNames.Where(v => inputvariables.Contains(v)).Where(problemData.Dataset.VariableHasType<double>).ToList();
-          rawVariableImpacts.Clear();
-          originalVariableOrdering.ForEach(v => rawVariableImpacts.Add(v, impacts.First(vv => vv.Item1 == v).Item2));
-          UpdateDataOrdering();
-        } finally {
-          mainForm.RemoveOperationProgressFromView(this);
-        }
-      });
+      var args = new BackgroundWorkerArguments() {
+        mainForm = mainForm,
+        replMethod = replMethod,
+        factorReplMethod = factorReplMethod,
+        dataPartition = dataPartition
+      };
+
+      //Let the backgroundWorker do his job (unless he's already running)
+      //fholzing: Possible bug -> A ContentChanged won't update the data if the backgroundworker is already running
+      if (!backgroundWorker.IsBusy) { backgroundWorker.RunWorkerAsync(args); }
     }
 
@@ -193 +229 @@
         ElementNames = orderedEntries.Select(i => i.Key)
       };
-      variableImactsArrayView.Content = (DoubleArray)impactArray.AsReadOnly();
-    }
-    #endregion   
+
+      //Could be, if the View was closed during the BackgroundWorker-run
+      if (!variableImactsArrayView.IsDisposed) {
+        variableImactsArrayView.Content = (DoubleArray)impactArray.AsReadOnly();
+      }
+    }
+    #endregion 
   }
 }