Changeset 15466 for branches/DataPreprocessing Cleanup/HeuristicLab.DataPreprocessing/3.4/Filter

Timestamp:

11/09/17 11:51:37 (7 years ago)

Author:

pfleck

Message:

#2809: Simplified the overall filtering logic as suggested by bburlacu

• changed parameter names to actively reflect that filter means "remaining"
• moved filter combination logic to FilterContent
• simplified/restructured code

File:

• branches/DataPreprocessing Cleanup/HeuristicLab.DataPreprocessing/3.4/Filter/ComparisonFilter.cs (modified) (2 diffs)

branches/DataPreprocessing Cleanup/HeuristicLab.DataPreprocessing/3.4/Filter/ComparisonFilter.cs

@@ -86 +86 @@
     }
 
+    // return remaining rows
     public new bool[] Check() {
       bool[] result = new bool[ConstrainedValue.Rows];
@@ -102 +103 @@
         }
 
-        result[row] = !base.Check(item);
+        result[row] = base.Check(item);
       }