Changeset 15162 for trunk/sources/HeuristicLab.Encodings.BinaryVectorEncoding

Timestamp:

07/06/17 14:42:50 (8 years ago)

Author:

jkarder

Message:

#2730: improved equality comparers

• got rid of one extra comparison
• fixed RealVectorEqualityComparer

File:

• trunk/sources/HeuristicLab.Encodings.BinaryVectorEncoding/3.3/BinaryVectorEqualityComparer.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Encodings.BinaryVectorEncoding/3.3/BinaryVectorEqualityComparer.cs ¶

@@ -28 +28 @@
   public class BinaryVectorEqualityComparer : EqualityComparer<BinaryVector> {
     public override bool Equals(BinaryVector x, BinaryVector y) {
-      if (x == null && y == null) return true;
+      if (ReferenceEquals(x, y)) return true;
       if (x == null || y == null) return false;
-      if (ReferenceEquals(x, y)) return true;
       if (x.Length != y.Length) return false;
       for (var i = 0; i < x.Length; i++)
@@ -36 +35 @@
       return true;
     }
+
     public override int GetHashCode(BinaryVector obj) {
       if (obj == null) throw new ArgumentNullException("obj", "BinaryVectorEqualityComparer: Cannot compute hash value of null.");
       unchecked {
         int hash = 17;
-        foreach (var bit in obj) {
+        foreach (var bit in obj)
           hash = hash * 29 + (bit ? 1231 : 1237);
-        }
         return hash;
       }