Changeset 1516

Timestamp:

04/05/09 13:52:10 (15 years ago)

Author:

svonolfe

Message:

Improved transaction handling and locking (#527)

Location:

trunk/sources

Files:

• HeuristicLab.DataAccess.ADOHelper/DataAdapterBase.cs (modified) (8 diffs)
• HeuristicLab.DataAccess.ADOHelper/Transaction.cs (modified) (1 diff)
• HeuristicLab.Hive.Server.ADODataAccess/ClientAdapter.cs (modified) (2 diffs)
• HeuristicLab.Hive.Server.ADODataAccess/dsHiveServer.cs (modified) (1 diff)

trunk/sources/HeuristicLab.DataAccess.ADOHelper/DataAdapterBase.cs

@@ -38 +38 @@
     private IDataAdapterWrapper<AdapterT, ObjT, RowT> dataAdapter;
 
-    private static Mutex lockersMutex =
-      new Mutex();
-
-    private static IDictionary<object, Mutex> lockers =
-      new Dictionary<object, Mutex>();
-
-    private static IDictionary<object, int> lockCount =
-      new Dictionary<object, int>();
-
     protected DataAdapterBase(
       IDataAdapterWrapper<AdapterT, ObjT, RowT> dataAdapter) {
@@ -52 +43 @@
     }
 
-    protected void LockRow(object id) {
-      Mutex rowLock = null;
-
-      /////begin critical section////
-      lockersMutex.WaitOne();
-
-      if (!lockers.ContainsKey(id)) {
-        lockers[id] = new Mutex();
-        lockCount[id] = 0;
-      }
-      rowLock = lockers[id];
-      lockCount[id]++;
-      
-      lockersMutex.ReleaseMutex();
-      /////end critical section////
-
-      rowLock.WaitOne();
-    }
-
-    protected void UnlockRow(object id) {
-      Mutex rowLock = lockers[id];
-      rowLock.ReleaseMutex();
-
-      /////begin critical section////
-      lockersMutex.WaitOne();
-
-      lockCount[id]--;
-      if (lockCount[id] == 0)
-        lockers.Remove(id);
-
-      lockersMutex.ReleaseMutex();
-      /////end critical section////
-    }
-    
     protected AdapterT Adapter {
       get {
@@ -222 +179 @@
       if (obj != null) {
         RowT row = null;
-        Guid locked = Guid.Empty;
 
         if (obj.Id != Guid.Empty) {
-          LockRow(obj.Id);
-          locked = obj.Id;
-
           row = GetRowById(obj.Id);
         } else {
@@ -237 +190 @@
         }
 
-        if (locked == Guid.Empty) {
-          LockRow(obj.Id);
-          locked = obj.Id;
-        }
-
         ConvertObj(obj, row);
         dataAdapter.UpdateRow(row);
-
-        UnlockRow(locked);
       }
     }
@@ -259 +205 @@
       try {
         doUpdate(obj);
+      }
+      catch (DBConcurrencyException ex) {
+        DataRow row = ex.Row;
+
+        RowT current = GetRowById(obj.Id);
+        if (current != null) {
+          //find out changes
+          for (int i = 0; i < row.ItemArray.Length; i++) {            
+            if (!row[i, DataRowVersion.Current].Equals(
+                 row[i, DataRowVersion.Original])) {
+              current[i] = row[i];
+            }
+          }
+
+          ConvertRow(current, obj);
+          //try updating again
+          Update(obj);
+        }
+        //otherwise: row was deleted in the meantime - nothing to do
       }
       finally {
@@ -283 +248 @@
 
       if (obj != null) {
-        LockRow(obj.Id);
-
         RowT row =
           GetRowById(obj.Id);
@@ -294 +257 @@
           success = true;
         }
-
-        UnlockRow(obj.Id);
       }
 
@@ -311 +272 @@
       try {
         return doDelete(obj);
+      }
+      catch (DBConcurrencyException) {
+        RowT current = GetRowById(obj.Id);
+        if (current != null) {
+          ConvertRow(current, obj);
+          //try deleting again
+          return Delete(obj);
+        } else {
+          //row has already been deleted
+          return false;
+        }
       }
       finally {

trunk/sources/HeuristicLab.DataAccess.ADOHelper/Transaction.cs

@@ -47 +47 @@
             value.Open();
 
-          transaction = value.BeginTransaction(IsolationLevel.RepeatableRead);
+          transaction = value.BeginTransaction(IsolationLevel.ReadCommitted);
         }
       }

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/ClientAdapter.cs

@@ -221 +221 @@
     protected override bool doDelete(ClientInfo client) {
       bool success = false;
-      Guid locked = Guid.Empty;
       
       if (client != null) {
-        if (client.Id != Guid.Empty) {
-          LockRow(client.Id);
-          locked = client.Id;
-        }
-
         dsHiveServer.ClientRow row =
           GetRowById(client.Id);
@@ -238 +232 @@
       }
 
-      if (locked != Guid.Empty) {
-        UnlockRow(locked);
-      }
-
       return success;
     }

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/dsHiveServer.cs

@@ -3 +3 @@
     
     public partial class dsHiveServer {
+      partial class JobDataTable {
+      }
+    
       partial class ClientGroup_ResourceDataTable {
       }