Changeset 1514 for trunk

Timestamp:

04/03/09 15:09:06 (16 years ago)

Author:

epitzer

Message:

Improved 2string decomposers. (#563)

File:

• trunk/sources/HeuristicLab.Persistence/Default/Decomposers/X2StringDecomposer.cs (modified) (10 diffs)

trunk/sources/HeuristicLab.Persistence/Default/Decomposers/X2StringDecomposer.cs

@@ -6 +6 @@
 using System.Globalization;
 using System.Text;
-using System.Collections;
 
 namespace HeuristicLab.Persistence.Default.Decomposers {
@@ -28 +27 @@
       };
 
-    private static readonly Dictionary<Type, MethodInfo> numberParser;  
+    private static readonly Dictionary<Type, MethodInfo> numberParsers;  
 
     static Number2StringDecomposer() {
-      numberParser = new Dictionary<Type, MethodInfo>();
+      numberParsers = new Dictionary<Type, MethodInfo>();
       foreach ( var type in numberTypes ) {
-        numberParser[type] = type
+        numberParsers[type] = type
           .GetMethod("Parse", BindingFlags.Static | BindingFlags.Public,
                      null, new[] {typeof (string)}, null);          
@@ -40 +39 @@
 
     public bool CanDecompose(Type type) {
-      return numberParser.ContainsKey(type);
-    }
-
-    public string SimpleDecompose(object obj) {
+      return numberParsers.ContainsKey(type);
+    }
+
+    public string Format(object obj) {
       if (obj.GetType() == typeof(float))        
         return ((float)obj).ToString("r", CultureInfo.InvariantCulture);
-      else if (obj.GetType() == typeof(double))
+      if (obj.GetType() == typeof(double))
         return ((double)obj).ToString("r", CultureInfo.InvariantCulture);
-      else if (obj.GetType() == typeof(decimal))
+      if (obj.GetType() == typeof(decimal))
         return ((decimal)obj).ToString("r", CultureInfo.InvariantCulture);
-      else
-        return obj.ToString();      
+      return obj.ToString();
     }
 
     public IEnumerable<Tag> DeCompose(object obj) {      
-      yield return new Tag(SimpleDecompose(obj));      
+      yield return new Tag(Format(obj));      
     }
 
@@ -63 +61 @@
 
     public object Parse(string stringValue, Type type) {
-      return numberParser[type]
+      return numberParsers[type]
         .Invoke(null,
             BindingFlags.Static | BindingFlags.PutRefDispProperty,
@@ -120 +118 @@
         sb.Append(a.GetLowerBound(i)).Append(';');
       foreach (var number in a) {        
-        sb.Append(numberDecomposer.SimpleDecompose(number)).Append(';');
+        sb.Append(numberDecomposer.Format(number)).Append(';');
       }
       yield return new Tag("compact array", sb.ToString());
@@ -130 +128 @@
 
     public object Populate(object instance, IEnumerable<Tag> tags, Type type) {      
-      var iter = tags.GetEnumerator();
-      iter.MoveNext();
-      var it = ((string) iter.Current.Value).Split(new[] {';'}, StringSplitOptions.RemoveEmptyEntries).GetEnumerator();
-      it.MoveNext();
-      int rank = int.Parse((string) it.Current);
-      it.MoveNext();
+      var tagIter = tags.GetEnumerator();
+      tagIter.MoveNext();
+      var valueIter = ((string) tagIter.Current.Value)
+        .Split(new[] {';'}, StringSplitOptions.RemoveEmptyEntries)
+        .GetEnumerator();
+      valueIter.MoveNext();
+      int rank = int.Parse((string) valueIter.Current);      
       int[] lengths = new int[rank];
-      int[] lowerBounds = new int[rank];
-      for (int i = 0; i < rank; i++, it.MoveNext())
-        lengths[i] = int.Parse((string) it.Current);
-      for (int i = 0; i < rank; i++, it.MoveNext())
-        lowerBounds[i] = int.Parse((string)it.Current);
-      Array a = Array.CreateInstance(type.GetElementType(), lengths, lowerBounds);
+      int[] lowerBounds = new int[rank];      
+      for (int i = 0; i < rank; i++) {
+        valueIter.MoveNext();
+        lengths[i] = int.Parse((string) valueIter.Current);        
+      }      
+      for (int i = 0; i < rank; i++) {
+        valueIter.MoveNext();
+        lowerBounds[i] = int.Parse((string) valueIter.Current);        
+      }
+      Type elementType = type.GetElementType();
+      Array a = Array.CreateInstance(elementType, lengths, lowerBounds);
       int[] positions = (int[]) lowerBounds.Clone();
-      while (it.MoveNext()) {
+      while (valueIter.MoveNext()) {
         a.SetValue(
-          numberDecomposer.Parse((string)it.Current, type.GetElementType()),          
+          numberDecomposer.Parse((string)valueIter.Current, elementType),          
           positions);
         positions[0] += 1;
@@ -167 +171 @@
       new Number2StringDecomposer();
     
+    private static readonly Dictionary<Type, Type> interfaceCache = new Dictionary<Type, Type>();
+
+    public Type GetGenericEnumerableInterface(Type type) {
+      if (interfaceCache.ContainsKey(type))
+        return interfaceCache[type];
+      foreach (Type iface in type.GetInterfaces()) {
+        if (iface.IsGenericType &&
+          iface.GetGenericTypeDefinition() == typeof(IEnumerable<>) &&
+          numberDecomposer.CanDecompose(iface.GetGenericArguments()[0])) {
+          interfaceCache.Add(type, iface);
+          return iface;
+        }
+      }
+      interfaceCache.Add(type, null);
+      return null;
+    }
+    
     public bool ImplementsGenericEnumerable(Type type) {
-      foreach( Type iface in type.GetInterfaces() ) {
-        if ( iface.IsGenericType &&
-          iface.GetGenericTypeDefinition() == typeof(IEnumerable<>) &&
-          numberDecomposer.CanDecompose(iface.GetGenericArguments()[0]) )
-          return true;
-      }
-      return false;
+      return GetGenericEnumerableInterface(type) != null;
     }
 
@@ -195 +210 @@
 
     public IEnumerable<Tag> DeCompose(object obj) {
-      Type elementType = obj.GetType().GetGenericArguments()[0];
-      Type instantiatedGenericInterface =
-        typeof (IEnumerable<>).MakeGenericType(new[] {elementType});
-      MethodInfo genericGetEnumeratorMethod =
-        instantiatedGenericInterface.GetMethod("GetEnumerator");
-      InterfaceMapping iMap = obj.GetType().GetInterfaceMap(instantiatedGenericInterface);
+      Type type = obj.GetType();
+      Type enumerable = GetGenericEnumerableInterface(type);      
+      InterfaceMapping iMap = obj.GetType().GetInterfaceMap(enumerable);      
       MethodInfo getEnumeratorMethod =
-        iMap.TargetMethods[Array.IndexOf(iMap.InterfaceMethods, genericGetEnumeratorMethod)];
+        iMap.TargetMethods[
+        Array.IndexOf(
+          iMap.InterfaceMethods,
+          enumerable.GetMethod("GetEnumerator"))];
       object[] empty = new object[] {};
       object genericEnumerator = getEnumeratorMethod.Invoke(obj, empty);
@@ -210 +225 @@
       while ( (bool)moveNextMethod.Invoke(genericEnumerator, empty) )
         sb.Append(
-          numberDecomposer.SimpleDecompose(
+          numberDecomposer.Format(
             currentProperty.GetValue(genericEnumerator, null))).Append(';');
       yield return new Tag("compact enumerable", sb.ToString());
@@ -220 +235 @@
 
     public object Populate(object instance, IEnumerable<Tag> tags, Type type) {
-      Type elementType = type.GetGenericArguments()[0];
+      Type enumerable = GetGenericEnumerableInterface(type);
+      Type elementType = enumerable.GetGenericArguments()[0];      
       MethodInfo addMethod = type.GetMethod("Add");      
       var tagEnumerator = tags.GetEnumerator();