Changeset 14400 for trunk/sources/HeuristicLab.Problems.DataAnalysis/3.4/Implementation/Transformations

Timestamp:

11/17/16 15:41:33 (8 years ago)

Author:

gkronber

Message:

#2697: reverse merge of r14378, r14390, r14391, r14393, r14394, r14396

Location:

trunk/sources/HeuristicLab.Problems.DataAnalysis/3.4/Implementation/Transformations

Files:

• LinearTransformation.cs (modified) (2 diffs)
• ShiftStandardDistributionTransformation.cs (modified) (2 diffs)
• ShiftToRangeTransformation.cs (modified) (2 diffs)
• Transformation.cs (modified) (1 diff)

trunk/sources/HeuristicLab.Problems.DataAnalysis/3.4/Implementation/Transformations/LinearTransformation.cs

@@ -52 +52 @@
     public double Multiplier {
       get { return MultiplierParameter.Value.Value; }
-      set {
+      protected set {
         MultiplierParameter.Value.Value = value;
       }
@@ -59 +59 @@
     public double Addend {
       get { return AddendParameter.Value.Value; }
-      set {
+      protected set {
         AddendParameter.Value.Value = value;
       }

trunk/sources/HeuristicLab.Problems.DataAnalysis/3.4/Implementation/Transformations/ShiftStandardDistributionTransformation.cs

@@ -71 +71 @@
 
     public override IEnumerable<double> Apply(IEnumerable<double> data) {
+      ConfigureParameters(data);
       if (OriginalStandardDeviation.IsAlmost(0.0)) {
         return data;
@@ -93 +94 @@
     }
 
-    public override void ConfigureParameters(IEnumerable<double> data) {
+    protected void ConfigureParameters(IEnumerable<double> data) {
       OriginalStandardDeviation = data.StandardDeviation();
       OriginalMean = data.Average();

trunk/sources/HeuristicLab.Problems.DataAnalysis/3.4/Implementation/Transformations/ShiftToRangeTransformation.cs

@@ -44 +44 @@
     }
 
+    public override IEnumerable<double> Apply(IEnumerable<double> data) {
+      ConfigureParameters(data);
+      return base.Apply(data);
+    }
+
     public override bool Check(IEnumerable<double> data, out string errorMsg) {
       ConfigureParameters(data);
@@ -49 +54 @@
     }
 
-    public override void ConfigureParameters(IEnumerable<double> data) {
+    protected void ConfigureParameters(IEnumerable<double> data) {
       double originalRangeStart = data.Min();
       double originalRangeEnd = data.Max();

trunk/sources/HeuristicLab.Problems.DataAnalysis/3.4/Implementation/Transformations/Transformation.cs

@@ -66 +66 @@
     protected Transformation(IEnumerable<string> allowedColumns) : base(allowedColumns) { }
 
-    public virtual void ConfigureParameters(IEnumerable<T> data) {
-      // override in transformations with parameters
-    }
-
     public abstract IEnumerable<T> Apply(IEnumerable<T> data);
-    public IEnumerable<T> ConfigureAndApply(IEnumerable<T> data) {
-      ConfigureParameters(data);
-      return Apply(data);
-    }
 
     public abstract bool Check(IEnumerable<T> data, out string errorMsg);