Changeset 1368

Timestamp:

03/19/09 17:05:34 (15 years ago)

Author:

kgrading

Message:

part three of the awesome "FixTheBug!" Show (#529)

Location:

trunk/sources

Files:

• HeuristicLab.Hive.Client.Core/Core.cs (modified) (8 diffs)
• HeuristicLab.Hive.Client.Core/Heartbeat.cs (modified) (1 diff)
• HeuristicLab.Hive.Client.ExecutionEngine/Executor.cs (modified) (1 diff)
• HeuristicLab.Hive.Client.ExecutionEngine/HeuristicLab.Hive.Client.ExecutionEngine.csproj (modified) (1 diff)
• HeuristicLab.Hive.Client.ExecutionEngine/InvalidStateException.cs (added)
• HeuristicLab.Hive.Contracts/BusinessObjects/HeartBeatData.cs (modified) (1 diff)
• HeuristicLab.Hive.Server.Core/ClientCommunicator.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Hive.Client.Core/Core.cs

@@ -51 +51 @@
   /// </summary>
   public class Core: MarshalByRefObject {
-    public delegate string GetASnapshotDelegate();
-    //Todo: private + getter/setter removen.
-    public static Object Locker { get; set; }
-    //Todo: ev. Rename to "abortRequested"
-    public static bool ShutdownFlag { get; set; }
-    
-    //Todo: Access modifier
-    Dictionary<long, Executor> engines = new Dictionary<long, Executor>();
-    Dictionary<long, AppDomain> appDomains = new Dictionary<long, AppDomain>();
-    Dictionary<long, Job> jobs = new Dictionary<long, Job>();
+    //Todo: Ask wagner
+    public static Object Locker { get; set; }    
+    public static bool abortRequested { get; set; }
+        
+    private Dictionary<long, Executor> engines = new Dictionary<long, Executor>();
+    private Dictionary<long, AppDomain> appDomains = new Dictionary<long, AppDomain>();
+    private Dictionary<long, Job> jobs = new Dictionary<long, Job>();
 
     private WcfService wcfService;
@@ -70 +67 @@
     public void Start() {
       Core.Locker = new Object();
-      ShutdownFlag = false;
+      abortRequested = false;
 
       Logging.GetInstance().Info(this.ToString(), "Hive Client started");
@@ -101 +98 @@
       //Main processing loop     
       //Todo: own thread for message handling
-      while (!ShutdownFlag) {
+      //Rly?!
+      while (!abortRequested) {
         MessageContainer container = queue.GetMessage();
         Debug.WriteLine("Main loop received this message: " + container.Message.ToString());
@@ -113 +111 @@
     /// </summary>
     /// <param name="container">The Container, containing the message</param>
-    private void DetermineAction(MessageContainer container) {
-      //Todo: Threads aus Threadpool verwenden
-      
+    private void DetermineAction(MessageContainer container) {           
       switch (container.Message) {
         //Server requests to abort a job
@@ -131 +127 @@
         //Snapshot is ready and can be sent back to the Server
         case MessageContainer.MessageType.SnapshotReady:
-          Thread ssr = new Thread(new ParameterizedThreadStart(GetSnapshot));
-          ssr.Start(container.JobId);          
+          ThreadPool.QueueUserWorkItem(new WaitCallback(GetSnapshot), container.JobId);
+          //Thread ssr = new Thread(new ParameterizedThreadStart(GetSnapshot));
+          //ssr.Start(container.JobId);          
           break;
         //Pull a Job from the Server
@@ -140 +137 @@
         //A Job has finished and can be sent back to the server
         case MessageContainer.MessageType.FinishedJob:
-          Thread finThread = new Thread(new ParameterizedThreadStart(GetFinishedJob));
-          finThread.Start(container.JobId);          
+          ThreadPool.QueueUserWorkItem(new WaitCallback(GetFinishedJob), container.JobId);
+          //Thread finThread = new Thread(new ParameterizedThreadStart(GetFinishedJob));
+          //finThread.Start(container.JobId);          
           break;     
         //Hard shutdown of the client
         case MessageContainer.MessageType.Shutdown:
-          ShutdownFlag = true;
+          abortRequested = true;
           beat.StopHeartBeat();
           break;
@@ -155 +153 @@
     
     private void GetFinishedJob(object jobId) {
-      long jId = (long)jobId;
-      //Todo: Don't return null, throw exception!
-      byte[] sJob = engines[jId].GetFinishedJob();
-
-      if (WcfService.Instance.ConnState == NetworkEnum.WcfConnState.Loggedin) {
-        wcfService.ProcessJobResultAsync(ConfigManager.Instance.GetClientInfo().ClientId,
-          jId,
-          sJob,
-          1,
-          null,
-          true);
-      } else {
-        //Todo: locking
-        JobStorageManager.PersistObjectToDisc(wcfService.ServerIP, wcfService.ServerPort, jId, sJob);
-        AppDomain.Unload(appDomains[jId]);
-        appDomains.Remove(jId);
-        engines.Remove(jId);
-        jobs.Remove(jId);
+      long jId = (long)jobId;      
+      try {
+        byte[] sJob = engines[jId].GetFinishedJob();
+
+        if (WcfService.Instance.ConnState == NetworkEnum.WcfConnState.Loggedin) {
+          wcfService.ProcessJobResultAsync(ConfigManager.Instance.GetClientInfo().ClientId,
+            jId,
+            sJob,
+            1,
+            null,
+            true);
+        } else {          
+          JobStorageManager.PersistObjectToDisc(wcfService.ServerIP, wcfService.ServerPort, jId, sJob);
+          lock (Core.Locker) {
+            AppDomain.Unload(appDomains[jId]);
+            appDomains.Remove(jId);
+            engines.Remove(jId);
+            jobs.Remove(jId);
+          }
+        }
+      }
+      catch (InvalidStateException ise) {
+        Logging.GetInstance().Error(this.ToString(), "Exception: ", ise);
       }
     }
@@ -224 +227 @@
       }
     }
-
-    //Todo: Remove intellgent stuff from the async event and move it to the main thread (message queue)
+    
     //Todo: Seperate this method into 2: Finished jobs and Snapshots
     void wcfService_SendJobResultCompleted(object sender, ProcessJobResultCompletedEventArgs e) {

trunk/sources/HeuristicLab.Hive.Client.Core/Heartbeat.cs

@@ -73 +73 @@
       Console.WriteLine("tick");  
       ClientInfo info = ConfigManager.Instance.GetClientInfo();
-      // Todo: remove tempfix for free cores. Fix spelling of freeCores (uppercase)
+      // Todo: remove tempfix for free cores.
 
       HeartBeatData heartBeatData = new HeartBeatData {
         ClientId = info.ClientId,
-        freeCores = info.NrOfCores - (ClientStatusInfo.JobsFetched - ClientStatusInfo.JobsProcessed),
-        freeMemory = 1000,
-        jobProgress = ConfigManager.Instance.GetProgressOfAllJobs()
+        FreeCores = info.NrOfCores - (ClientStatusInfo.JobsFetched - ClientStatusInfo.JobsProcessed),
+        FreeMemory = 1000,
+        JobProgress = ConfigManager.Instance.GetProgressOfAllJobs()
       };
       if (wcfService.ConnState == NetworkEnum.WcfConnState.Failed) {

trunk/sources/HeuristicLab.Hive.Client.ExecutionEngine/Executor.cs

@@ -93 +93 @@
       //Job isn't finished!
       if (Job.Running) {
-        return null;
+        throw new InvalidStateException("Job is still running");
       } else {
         return SerializeJobObject();

trunk/sources/HeuristicLab.Hive.Client.ExecutionEngine/HeuristicLab.Hive.Client.ExecutionEngine.csproj

@@ -66 +66 @@
     <Compile Include="Executor.cs" />
     <Compile Include="ExecutionEnginePlugin.cs" />
+    <Compile Include="InvalidStateException.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
   </ItemGroup>

trunk/sources/HeuristicLab.Hive.Contracts/BusinessObjects/HeartBeatData.cs

@@ -33 +33 @@
     public Guid ClientId { get; set; }
     [DataMember]
-    public int freeMemory { get; set; }
+    public int FreeMemory { get; set; }
     [DataMember]
-    public int freeCores { get; set; }
+    public int FreeCores { get; set; }
     [DataMember]
-    public Dictionary<long, double> jobProgress { get; set; } // TODO: define Type 
+    public Dictionary<long, double> JobProgress { get; set; } // TODO: define Type 
   }
 }

trunk/sources/HeuristicLab.Hive.Server.Core/ClientCommunicator.cs

@@ -190 +190 @@
       response.Success = true;
       response.StatusMessage = ApplicationConstants.RESPONSE_COMMUNICATOR_HEARTBEAT_RECEIVED;
-      if (hbData.freeCores > 0 && scheduler.ExistsJobForClient(hbData))
+      if (hbData.FreeCores > 0 && scheduler.ExistsJobForClient(hbData))
         response.ActionRequest.Add(new MessageContainer(MessageContainer.MessageType.FetchJob));
       else
         response.ActionRequest.Add(new MessageContainer(MessageContainer.MessageType.NoMessage));
 
-      if (hbData.jobProgress != null) {
+      if (hbData.JobProgress != null) {
         List<Job> jobsOfClient = new List<Job>(jobAdapter.GetActiveJobsOf(clientAdapter.GetById(hbData.ClientId)));
         if (jobsOfClient == null || jobsOfClient.Count == 0) {
@@ -203 +203 @@
         }
 
-        foreach (KeyValuePair<long, double> jobProgress in hbData.jobProgress) {
+        foreach (KeyValuePair<long, double> jobProgress in hbData.JobProgress) {
           Job curJob = jobAdapter.GetById(jobProgress.Key);
           if (curJob.Client == null || curJob.Client.ClientId != hbData.ClientId) {