Changeset 1340 for trunk/sources/HeuristicLab.Hive.Server.Core

Timestamp:

03/13/09 11:59:36 (15 years ago)

Author:

kgrading

Message:

Code Review changes (#522)

File:

• trunk/sources/HeuristicLab.Hive.Server.Core/ClientCommunicator.cs (modified) (3 diffs)

trunk/sources/HeuristicLab.Hive.Server.Core/ClientCommunicator.cs

@@ -46 +46 @@
       new ReaderWriterLockSlim(LockRecursionPolicy.SupportsRecursion);
 
+    // todo: access modifier!
     IClientAdapter clientAdapter;
     IJobAdapter jobAdapter;
@@ -143 +144 @@
       heartbeatLock.ExitWriteLock();
 
+      // todo: allClients legacy ?
       ICollection<ClientInfo> allClients = clientAdapter.GetAll();
       ClientInfo client = clientAdapter.GetById(clientInfo.ClientId);
@@ -165 +167 @@
     /// <param name="hbData"></param>
     /// <returns></returns>
+    // todo: new name for "SendHeartBeat" e.g. ProcessHeartBeat
     public ResponseHB SendHeartBeat(HeartBeatData hbData) {
       ResponseHB response = new ResponseHB();