Changeset 12839

Timestamp:

08/06/15 11:06:56 (8 years ago)

Author:

bburlacu

Message:

#2453: Ensure similarity value is never greater than 1 in the SymbolicExpressionTreePhenotypicSimilarityCalculator.

File:

• trunk/sources/HeuristicLab.Problems.DataAnalysis.Symbolic/3.4/TreeMatching/SymbolicExpressionTreePhenotypicSimilarityCalculator.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Problems.DataAnalysis.Symbolic/3.4/TreeMatching/SymbolicExpressionTreePhenotypicSimilarityCalculator.cs

@@ -67 +67 @@
       var r = OnlinePearsonsRCalculator.Calculate(v1, v2, out error);
 
-      if (r > 1.0)
-        r = 1.0;
+      var r2 = error == OnlineCalculatorError.None ? r * r : 0;
 
-      return error == OnlineCalculatorError.None ? r*r : 0;
+      if (r2 > 1.0)
+        r2 = 1.0;
+
+      return r2;
     }
 
@@ -89 +91 @@
       var r = OnlinePearsonsRCalculator.Calculate(leftValues, rightValues, out error);
 
-      if (r > 1.0)
-        r = 1.0; // sometimes due to fp errors it can happen that the correlation is over 1 (like 1.0000000009)
+      var r2 = error == OnlineCalculatorError.None ? r * r : 0;
 
-      return error == OnlineCalculatorError.None ? r*r : 0;
+      if (r2 > 1.0)
+        r2 = 1.0;
+
+      return r2;
     }
   }