Changeset 12829

Timestamp:

08/02/15 14:44:48 (9 years ago)

Author:

aballeit

Message:

#2283 MCTS avoid stackoverflow..

Location:

branches/HeuristicLab.Problems.GrammaticalOptimization

Files:

• Evaluation/MainWindow.xaml.cs (modified) (1 diff)
• HeuristicLab.Algorithms.MonteCarloTreeSearch/MonteCarloTreeSearch.cs (modified) (8 diffs)
• HeuristicLab.Algorithms.MonteCarloTreeSearch/MonteCarloTreeSearch_PruneLeaves.cs (modified) (3 diffs)

branches/HeuristicLab.Problems.GrammaticalOptimization/Evaluation/MainWindow.xaml.cs

@@ -43 +43 @@
             this.DataContext = vm = new EvaluationViewModel();
             vm.MaxLen = 100;
-            vm.MaxIterations = 1000000;
-            vm.NrRuns = 10;
+            vm.MaxIterations = 500000;
+            vm.NrRuns = 20;
+            
         }
 

branches/HeuristicLab.Problems.GrammaticalOptimization/HeuristicLab.Algorithms.MonteCarloTreeSearch/MonteCarloTreeSearch.cs

@@ -28 +28 @@
         protected readonly ISimulation simulation;
         protected TreeNode rootNode;
-        protected bool isPaused = false;
-        protected object pauseLock = new object();
         protected int goodSelections;
 
@@ -59 +57 @@
 
         public bool StopRequested { get; set; }
-
-        public bool IsPaused
-        {
-            get { return this.isPaused; }
-        }
-
+        
         public int GoodSelections { get { return this.goodSelections; } }
 
@@ -81 +74 @@
             Reset();
             int selections = 0;
+            TreeNode currentNode;
+            string phrase;
+            string simulatedPhrase;
+            double quality;
+
             for (int i = 0; !StopRequested && i < maxIterations; i++)
             {
-                lock (pauseLock)
-                {
-                    if (isPaused)
-                    {
-                        Monitor.Wait(pauseLock);
-                    }
-                }
-                TreeNode currentNode = rootNode;
+                currentNode = rootNode;
 
                 while (!currentNode.IsLeaf())
@@ -101 +92 @@
                 }
 
-                string phrase = currentNode.phrase;
+                phrase = currentNode.phrase;
 
                 if (!grammar.IsTerminal(phrase) && phrase.Length <= maxLen)
@@ -114 +105 @@
                 if (currentNode.phrase.Length <= maxLen)
                 {
-                    string simulatedPhrase;
-                    double quality = simulation.Simulate(currentNode, out simulatedPhrase);
+                    quality = simulation.Simulate(currentNode, out simulatedPhrase);
                     OnSolutionEvaluated(simulatedPhrase, quality);
 
@@ -126 +116 @@
         {
             // create children on the first visit
+            Sequence newSequence;
+            TreeNode childNode;
             if (treeNode.children == null)
             {
@@ -140 +132 @@
                         foreach (Sequence alternative in grammar.GetAlternatives(symbol))
                         {
-                            Sequence newSequence = new Sequence(phrase);
+                            newSequence = new Sequence(phrase);
                             newSequence.ReplaceAt(i, 1, alternative);
                             if (newSequence.Length <= maxLen)
                             {
-                                TreeNode childNode = new TreeNode(treeNode, newSequence.ToString(),
+                                childNode = new TreeNode(treeNode, newSequence.ToString(),
                                     behaviourPolicy.CreateActionInfo(), treeNode.level + 1);
                                 treeNode.children.Add(childNode);
@@ -350 +342 @@
             return HexConverter(Color.FromArgb(newR, newG, newB));
         }
-
-        public void PauseContinue()
-        {
-            lock (pauseLock)
-            {
-                if (isPaused)
-                {
-                    isPaused = false;
-                    Monitor.Pulse(pauseLock);
-                }
-                else
-                {
-                    isPaused = true;
-                }
-            }
-        }
     }
 }

branches/HeuristicLab.Problems.GrammaticalOptimization/HeuristicLab.Algorithms.MonteCarloTreeSearch/MonteCarloTreeSearch_PruneLeaves.cs

@@ -22 +22 @@
             Reset();
             int selections = 0;
+            TreeNode currentNode;
+            string phrase;
+            string simulatedPhrase;
+            double quality;
             for (int i = 0; !StopRequested && i < maxIterations; i++)
             {
-                lock (pauseLock)
-                {
-                    if (isPaused)
-                    {
-                        Monitor.Wait(pauseLock);
-                    }
-                }
-                TreeNode currentNode = rootNode;
+                currentNode = rootNode;
 
                 while (!currentNode.IsLeaf())
@@ -42 +39 @@
                 }
 
-                string phrase = currentNode.phrase;
+                phrase = currentNode.phrase;
 
                 if (phrase.Length <= maxLen)
@@ -71 +68 @@
                 if (currentNode.phrase.Length <= maxLen)
                 {
-                    string simulatedPhrase;
-                    double quality = simulation.Simulate(currentNode, out simulatedPhrase);
+                    quality = simulation.Simulate(currentNode, out simulatedPhrase);
                     OnSolutionEvaluated(simulatedPhrase, quality);