Changeset 12273

Timestamp:

04/01/15 13:41:01 (10 years ago)

Author:

ascheibe

Message:

#2356 implemented review comments

File:

• trunk/sources/HeuristicLab.Clients.Hive.Slave/3.3/Manager/ConfigManager.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Clients.Hive.Slave/3.3/Manager/ConfigManager.cs

@@ -37 +37 @@
     private const string vmwareNameString = "VMware";
     private const string virtualboxNameString = "VirtualBox";
-    private const int macLength = 12;
+    private const int macLength = 6;
+    private const int macLongLength = 8;
 
     public static ConfigManager Instance {
@@ -196 +197 @@
       }
 
-      string addr = validNic.GetPhysicalAddress().ToString();
-      if (addr.Length != macLength) {
-        throw new Exception("Error generating slave UID: MAC address has to have " + macLength + " digits. Actual MAC address is: " + addr);
-      }
-
-      byte[] b = new byte[8];
-      int j = 2;
-      for (int i = 0; i < macLength; i += 2) {
-        b[j++] = (byte)((ParseNybble(addr[i]) << 4) | ParseNybble(addr[i + 1]));
-      }
+      byte[] addr = validNic.GetPhysicalAddress().GetAddressBytes();
+      if (addr.Length < macLength || addr.Length > macLongLength) {
+        throw new ArgumentException(string.Format("Error generating slave UID: MAC address has to have a length between {0} and {1} bytes. Actual MAC address is: {2}",
+              macLength, macLongLength, addr));
+      }
+
+      if (addr.Length < macLongLength) {
+        byte[] b = new byte[8];
+        Array.Copy(addr, 0, b, 2, addr.Length);
+        addr = b;
+      }
+
       // also get machine name and save it to the first 4 bytes                
-      Guid guid = new Guid(Environment.MachineName.GetHashCode(), 0, 0, b);
+      Guid guid = new Guid(Environment.MachineName.GetHashCode(), 0, 0, addr);
       return guid;
-    }
-
-    /// <summary>
-    /// return numeric value of a single hex-char
-    /// (see: http://stackoverflow.com/questions/854012/how-to-convert-hex-to-a-byte-array)
-    /// </summary>    
-    static int ParseNybble(char c) {
-      if (c >= '0' && c <= '9') {
-        return c - '0';
-      }
-      if (c >= 'A' && c <= 'F') {
-        return c - 'A' + 10;
-      }
-      if (c >= 'a' && c <= 'f') {
-        return c - 'a' + 10;
-      }
-      throw new ArgumentException("Invalid hex digit: " + c);
     }