Changeset 1175 for trunk/sources/HeuristicLab.Hive.Server.ADODataAccess

Timestamp:

01/25/09 11:32:31 (15 years ago)

Author:

svonolfe

Message:

Refactored DAL, avoided possible race conditions (#372)

Location:

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess

Files:

• CachedDataAdapter.cs (modified) (3 diffs)
• ClientAdapter.cs (modified) (6 diffs)
• ClientGroupAdapter.cs (modified) (3 diffs)
• DataAdapterBase.cs (modified) (3 diffs)
• JobAdapter.cs (modified) (3 diffs)
• PermissionOwnerAdapter.cs (modified) (1 diff)
• ResourceAdapter.cs (modified) (1 diff)
• UserAdapter.cs (modified) (3 diffs)
• UserGroupAdapter.cs (modified) (3 diffs)

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/CachedDataAdapter.cs

@@ -227 +227 @@
     public override void Update(ObjT obj) {
       if (obj != null) {
-        RowT row =
-          GetRowById(obj.Id);
+        RowT row = null;
+        long locked = default(long);
+
+        if (obj.Id != default(long)) {
+          LockRow(obj.Id);
+          locked = obj.Id;
+
+          row = GetRowById(obj.Id);
+        }
 
         if (row == null) {
@@ -238 +245 @@
 
           UpdateRow(row);
-        }
-
-        obj.Id = (long)row[row.Table.PrimaryKey[0]];
-        LockRow(obj.Id);
+          obj.Id = (long)row[row.Table.PrimaryKey[0]];
+        }
+
+        if (locked == default(long)) {
+          LockRow(obj.Id);
+          locked = obj.Id;
+        }
 
         ConvertObj(obj, row);
@@ -256 +266 @@
         }
 
-        UnlockRow(obj.Id);
+        UnlockRow(locked);
       }
     }

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/ClientAdapter.cs

@@ -27 +27 @@
 using HeuristicLab.Hive.Contracts.BusinessObjects;
 using System.Linq.Expressions;
-using System.Runtime.CompilerServices;
 
 namespace HeuristicLab.Hive.Server.ADODataAccess {
@@ -79 +78 @@
 
     private void Preprocess(ClientInfo client) {
-      if (client != null) {
-        if (client.Id == default(long)) {
-          ClientInfo found = GetById(client.ClientId);
-          if (found != null)
-            client.Id = found.Id;
-        }
+      if (client != null && client.Id == default(long)) {
+        ClientInfo found = GetById(client.ClientId);
+        if (found != null)
+          client.Id = found.Id;
       }
     }
@@ -215 +212 @@
 
     #region IClientAdapter Members
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public override void Update(ClientInfo client) {
       if (client != null) {
+        Guid locked = Guid.Empty;
+        if (client.ClientId != Guid.Empty) {
+          LockRow(client.ClientId);
+          locked = client.ClientId;
+        }
+
         Preprocess(client);
 
@@ -223 +225 @@
 
         base.Update(client);
+
+        if (locked != Guid.Empty) {
+          UnlockRow(locked);
+        }
       }
     }
@@ -248 +254 @@
     }
 
-    [MethodImpl(MethodImplOptions.Synchronized)]
-    public override bool Delete(ClientInfo client) {      
+    public override bool Delete(ClientInfo client) {
+      bool success = false;
+      Guid locked = Guid.Empty;
+      
       if (client != null) {
+        if (client.ClientId != Guid.Empty) {
+          LockRow(client.ClientId);
+          locked = client.ClientId;
+        }
+
         Preprocess(client);
 
@@ -264 +277 @@
           }
 
-          return base.Delete(client) && 
+          success = base.Delete(client) && 
             ResAdapter.Delete(client);
         }
       }
 
-      return false;
+      if (locked != Guid.Empty) {
+        UnlockRow(locked);
+      }
+
+      return success;
     }
 

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/ClientGroupAdapter.cs

@@ -27 +27 @@
 using HeuristicLab.Hive.Server.Core.InternalInterfaces.DataAccess;
 using HeuristicLab.Hive.Contracts.BusinessObjects;
-using System.Runtime.CompilerServices;
 using System.Data;
 
@@ -233 +232 @@
 
     #region IClientGroupAdapter Members
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public override void Update(ClientGroup group) {
       if (group != null) {
@@ -273 +271 @@
     }
 
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public override bool Delete(ClientGroup group) {
       if (group != null) {

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/DataAdapterBase.cs

@@ -37 +37 @@
       new Mutex();
 
-    private static IDictionary<long, Mutex> lockers =
-      new Dictionary<long, Mutex>();
-
-    private static IDictionary<long, int> lockCount =
-      new Dictionary<long, int>();
-
-    protected void LockRow(long id) {
+    private static IDictionary<object, Mutex> lockers =
+      new Dictionary<object, Mutex>();
+
+    private static IDictionary<object, int> lockCount =
+      new Dictionary<object, int>();
+
+    protected void LockRow(object id) {
       Mutex rowLock = null;
 
@@ -62 +62 @@
     }
 
-    protected void UnlockRow(long id) {
+    protected void UnlockRow(object id) {
       Mutex rowLock = lockers[id];
       rowLock.ReleaseMutex();
@@ -163 +163 @@
     public virtual void Update(ObjT obj) {
       if (obj != null) {
-        RowT row =
-          GetRowById(obj.Id);
+        RowT row = null;
+        long locked = default(long);
+        
+        if (obj.Id != default(long)) {
+           LockRow(obj.Id);
+           locked = obj.Id;
+
+           row = GetRowById(obj.Id);
+        }          
 
         if (row == null) {
           row = InsertNewRow(obj);
           UpdateRow(row);
+
+          obj.Id = (long)row[row.Table.PrimaryKey[0]];
         }
 
-        obj.Id = (long)row[row.Table.PrimaryKey[0]];
-        LockRow(obj.Id);
+        if (locked == default(long)) {
+          LockRow(obj.Id);
+          locked = obj.Id;
+        }
 
         ConvertObj(obj, row);
         UpdateRow(row);
 
-        UnlockRow(obj.Id);
+        UnlockRow(locked);
       }
     }

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/JobAdapter.cs

@@ -27 +27 @@
 using HeuristicLab.Hive.Contracts.BusinessObjects;
 using System.Linq.Expressions;
-using System.Runtime.CompilerServices;
 
 namespace HeuristicLab.Hive.Server.ADODataAccess {
@@ -119 +118 @@
           job.DateCalculated = DateTime.MinValue;
 
-        job.Priority = row.Priority;
+        if (!row.IsPriorityNull())
+          job.Priority = row.Priority;
+        else
+          job.Priority = default(int);
 
         return job;
@@ -332 +334 @@
     }
 
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public override bool Delete(Job job) {
       if (job != null) {

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/PermissionOwnerAdapter.cs

@@ -27 +27 @@
 using HeuristicLab.Hive.Server.Core.InternalInterfaces.DataAccess;
 using HeuristicLab.Hive.Contracts.BusinessObjects;
-using System.Runtime.CompilerServices;
 
 namespace HeuristicLab.Hive.Server.ADODataAccess {

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/ResourceAdapter.cs

@@ -26 +26 @@
 using HeuristicLab.Hive.Server.Core.InternalInterfaces.DataAccess;
 using HeuristicLab.Hive.Contracts.BusinessObjects;
-using System.Runtime.CompilerServices;
 
 namespace HeuristicLab.Hive.Server.ADODataAccess {

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/UserAdapter.cs

@@ -27 +27 @@
 using HeuristicLab.Hive.Server.Core.InternalInterfaces.DataAccess;
 using HeuristicLab.Hive.Contracts.BusinessObjects;
-using System.Runtime.CompilerServices;
 
 namespace HeuristicLab.Hive.Server.ADODataAccess {
@@ -136 +135 @@
     #region IUserAdapter Members
 
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public override void Update(User user) {
       if (user != null) {
@@ -156 +154 @@
     }
 
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public override bool Delete(User user) {
       if (user != null) {

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/UserGroupAdapter.cs

@@ -27 +27 @@
 using HeuristicLab.Hive.Server.Core.InternalInterfaces.DataAccess;
 using HeuristicLab.Hive.Contracts.BusinessObjects;
-using System.Runtime.CompilerServices;
 using System.Data;
 
@@ -234 +233 @@
 
     #region IUserGroupAdapter Members
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public override void Update(UserGroup group) {
       if (group != null) {
@@ -273 +271 @@
     }
 
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public override bool Delete(UserGroup group) {
       if (group != null) {