Changeset 11591 for branches/Breadcrumbs

Timestamp:

11/27/14 09:35:43 (9 years ago)

Author:

jkarder

Message:

#2116: reverted to r10041

Location:

branches/Breadcrumbs

Files:

• HeuristicLab.Clients.Access.Administration/3.3/Views/RoleView.cs (modified) (1 diff)
• HeuristicLab.Clients.Access.Administration/3.3/Views/UserGroupView.cs (modified) (1 diff)
• HeuristicLab.Clients.Access.Administration/3.3/Views/UserView.cs (modified) (1 diff)
• HeuristicLab.Core.Views/3.3/ItemCollectionView.cs (modified) (3 diffs)
• HeuristicLab.Core.Views/3.3/ItemListView.cs (modified) (3 diffs)
• HeuristicLab.Core.Views/3.3/ParameterCollectionView.cs (modified) (2 diffs)
• HeuristicLab.MainForm.WindowsForms/3.3/Controls/BreadcrumbControl.Designer.cs (deleted)
• HeuristicLab.MainForm.WindowsForms/3.3/Controls/BreadcrumbControl.cs (deleted)
• HeuristicLab.MainForm.WindowsForms/3.3/Controls/ViewContextMenuStrip.cs (modified) (4 diffs)
• HeuristicLab.MainForm.WindowsForms/3.3/Controls/ViewHost.Designer.cs (modified) (5 diffs)
• HeuristicLab.MainForm.WindowsForms/3.3/Controls/ViewHost.cs (modified) (12 diffs)
• HeuristicLab.MainForm.WindowsForms/3.3/HeuristicLab.MainForm.WindowsForms-3.3.csproj (modified) (1 diff)
• HeuristicLab.MainForm.WindowsForms/3.3/MainForms/MainForm.cs (modified) (4 diffs)
• HeuristicLab.MainForm.WindowsForms/3.3/Views/View.cs (modified) (2 diffs)
• HeuristicLab.Operators.Views.GraphVisualization.Views/3.3/OperatorGraphView.cs (modified) (2 diffs)
• HeuristicLab.Optimization.Views/3.3/ResultCollectionView.cs (modified) (3 diffs)
• HeuristicLab.Optimization.Views/3.3/RunCollectionViews/RunCollectionView.cs (modified) (3 diffs)
• HeuristicLab.Optimization.Views/3.3/RunView.cs (modified) (3 diffs)

branches/Breadcrumbs/HeuristicLab.Clients.Access.Administration/3.3/Views/RoleView.cs

@@ -47 +47 @@
 
     private void roleNameTextBox_TextChanged(object sender, System.EventArgs e) {
-      if (Content != null && Content.Name != roleNameTextBox.Text)
+      if (Content.Name != roleNameTextBox.Text)
         Content.Name = roleNameTextBox.Text;
     }

branches/Breadcrumbs/HeuristicLab.Clients.Access.Administration/3.3/Views/UserGroupView.cs

@@ -69 +69 @@
 
     private void groupNameTextBox_TextChanged(object sender, System.EventArgs e) {
-      if (Content != null && Content.Name != this.groupNameTextBox.Text)
+      if (Content.Name != this.groupNameTextBox.Text)
         Content.Name = this.groupNameTextBox.Text;
     }

branches/Breadcrumbs/HeuristicLab.Clients.Access.Administration/3.3/Views/UserView.cs

@@ -72 +72 @@
 
     private void fullNameTextBox_TextChanged(object sender, System.EventArgs e) {
-      if (Content != null && Content.FullName != fullNameTextBox.Text)
+      if (Content.FullName != fullNameTextBox.Text)
         Content.FullName = fullNameTextBox.Text;
     }
 
     private void userNameTextBox_TextChanged(object sender, System.EventArgs e) {
-      if (Content != null && Content.UserName != userNameTextBox.Text)
+      if (Content.UserName != userNameTextBox.Text)
         Content.UserName = userNameTextBox.Text;
     }
 
     private void emailTextBox_TextChanged(object sender, System.EventArgs e) {
-      if (Content != null && Content.Email != emailTextBox.Text)
+      if (Content.Email != emailTextBox.Text)
         Content.Email = emailTextBox.Text;
     }

branches/Breadcrumbs/HeuristicLab.Core.Views/3.3/ItemCollectionView.cs

@@ -140 +140 @@
         try {
           return (T)typeSelectorDialog.TypeSelector.CreateInstanceOfSelectedType();
-        } catch (Exception ex) {
+        }
+        catch (Exception ex) {
           ErrorHandling.ShowErrorDialog(this, ex);
         }
@@ -219 +220 @@
     #region ListView Events
     protected virtual void itemsListView_SelectedIndexChanged(object sender, EventArgs e) {
-      removeButton.Enabled = Content != null && !Content.IsReadOnly && !ReadOnly && itemsListView.SelectedItems.Count > 0;
+      removeButton.Enabled = (Content != null) && !Content.IsReadOnly && !ReadOnly && itemsListView.SelectedItems.Count > 0;
       AdjustListViewColumnSizes();
-      if (itemsListView.SelectedItems.Count == 1) {
-        var item = (T)itemsListView.SelectedItems[0].Tag;
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(item, this, true);
-        if (outermostViewHost == null || !outermostViewHost.HotlinkingEnabled) {
-          if (showDetailsCheckBox.Checked) {
-            detailsGroupBox.Enabled = true;
-            viewHost.Content = item;
-          } else {
-            viewHost.Content = null;
-            detailsGroupBox.Enabled = false;
-          }
+      if (showDetailsCheckBox.Checked) {
+        if (itemsListView.SelectedItems.Count == 1) {
+          T item = (T)itemsListView.SelectedItems[0].Tag;
+          detailsGroupBox.Enabled = true;
+          viewHost.Content = item;
+        } else {
+          viewHost.Content = null;
+          detailsGroupBox.Enabled = false;
         }
       }
@@ -249 +246 @@
     protected virtual void itemsListView_DoubleClick(object sender, EventArgs e) {
       if (itemsListView.SelectedItems.Count == 1) {
-        var item = (T)itemsListView.SelectedItems[0].Tag;
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(item, this);
-        if (outermostViewHost != null) {
-          outermostViewHost.ActiveView.ReadOnly = ReadOnly;
-          outermostViewHost.ActiveView.Locked = Locked;
+        T item = itemsListView.SelectedItems[0].Tag as T;
+        if (item != null) {
+          IContentView view = MainFormManager.MainForm.ShowContent(item);
+          if (view != null) {
+            view.ReadOnly = ReadOnly;
+            view.Locked = Locked;
+          }
         }
       }

branches/Breadcrumbs/HeuristicLab.Core.Views/3.3/ItemListView.cs

@@ -146 +146 @@
         try {
           return (T)typeSelectorDialog.TypeSelector.CreateInstanceOfSelectedType();
-        } catch (Exception ex) {
+        }
+        catch (Exception ex) {
           ErrorHandling.ShowErrorDialog(this, ex);
         }
@@ -242 +243 @@
                              (Content != null) && !Content.IsReadOnly && !ReadOnly;
       AdjustListViewColumnSizes();
-      if (itemsListView.SelectedItems.Count == 1) {
-        var item = (T)itemsListView.SelectedItems[0].Tag;
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(item, this, true);
-        if (outermostViewHost != null && outermostViewHost.HotlinkingEnabled) {
-          outermostViewHost.ActiveView.ReadOnly = ReadOnly;
-          outermostViewHost.ActiveView.Locked = Locked;
+
+      if (showDetailsCheckBox.Checked) {
+        if (itemsListView.SelectedItems.Count == 1) {
+          T item = (T)itemsListView.SelectedItems[0].Tag;
+          detailsGroupBox.Enabled = true;
+          viewHost.Content = item;
         } else {
-          if (showDetailsCheckBox.Checked) {
-            detailsGroupBox.Enabled = true;
-            viewHost.Content = item;
-          } else {
-            viewHost.Content = null;
-            detailsGroupBox.Enabled = false;
-          }
+          viewHost.Content = null;
+          detailsGroupBox.Enabled = false;
         }
       }
@@ -272 +267 @@
     protected virtual void itemsListView_DoubleClick(object sender, EventArgs e) {
       if (itemsListView.SelectedItems.Count == 1) {
-        var item = (T)itemsListView.SelectedItems[0].Tag;
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(item, this);
-        if (outermostViewHost != null) {
-          outermostViewHost.ActiveView.ReadOnly = ReadOnly;
-          outermostViewHost.ActiveView.Locked = Locked;
+        T item = itemsListView.SelectedItems[0].Tag as T;
+        if (item != null) {
+          IContentView view = MainFormManager.MainForm.ShowContent(item);
+          if (view != null) {
+            view.ReadOnly = ReadOnly;
+            view.Locked = Locked;
+          }
         }
       }

branches/Breadcrumbs/HeuristicLab.Core.Views/3.3/ParameterCollectionView.cs

@@ -27 +27 @@
 using HeuristicLab.Collections;
 using HeuristicLab.MainForm;
-using HeuristicLab.MainForm.WindowsForms;
 
 namespace HeuristicLab.Core.Views {
@@ -147 +146 @@
       }
     }
-    protected virtual void itemsListView_SelectedIndexChanged(object sender, EventArgs e) {
-      removeButton.Enabled = Content != null && !Content.IsReadOnly && !ReadOnly && itemsListView.SelectedItems.Count > 0;
-      AdjustListViewColumnSizes();
-      if (itemsListView.SelectedItems.Count == 1) {
-        var item = (IParameter)itemsListView.SelectedItems[0].Tag;
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(item, this, true);
-        if (outermostViewHost != null && outermostViewHost.HotlinkingEnabled) {
-          outermostViewHost.ActiveView.ReadOnly = ReadOnly || (item.Hidden && !AllowEditingOfHiddenParameters);
-          outermostViewHost.ActiveView.Locked = Locked;
-        } else {
-          if (showDetailsCheckBox.Checked) {
-            detailsGroupBox.Enabled = true;
-            viewHost.Content = item;
-          } else {
-            viewHost.Content = null;
-            detailsGroupBox.Enabled = false;
-          }
-        }
-      }
+    protected override void itemsListView_SelectedIndexChanged(object sender, EventArgs e) {
+      base.itemsListView_SelectedIndexChanged(sender, e);
+      SetEnabledStateOfControls();
     }
     protected override void itemsListView_DoubleClick(object sender, EventArgs e) {
       if (itemsListView.SelectedItems.Count == 1) {
-        var item = (IParameter)itemsListView.SelectedItems[0].Tag;
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(item, this);
-        if (outermostViewHost != null) {
-          outermostViewHost.ActiveView.ReadOnly = ReadOnly || (item.Hidden && !AllowEditingOfHiddenParameters);
-          outermostViewHost.ActiveView.Locked = Locked;
+        IParameter item = itemsListView.SelectedItems[0].Tag as IParameter;
+        if (item != null) {
+          IContentView view = MainFormManager.MainForm.ShowContent(item);
+          if (view != null) {
+            view.ReadOnly = ReadOnly || (item.Hidden && !AllowEditingOfHiddenParameters);
+            view.Locked = Locked;
+          }
         }
       }

branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms/3.3/Controls/ViewContextMenuStrip.cs

@@ -30 +30 @@
     public ViewContextMenuStrip() {
       InitializeComponent();
-      menuItems = new Dictionary<Type, ToolStripMenuItem>();
-      ignoredViewTypes = new List<Type>();
+      this.menuItems = new Dictionary<Type, ToolStripMenuItem>();
+      this.ignoredViewTypes = new List<Type>();
     }
 
     public ViewContextMenuStrip(IContainer container)
       : base(container) {
-      InitializeComponent();
-      menuItems = new Dictionary<Type, ToolStripMenuItem>();
-      ignoredViewTypes = new List<Type>();
-      ShowBreadcrumbsToolStripMenuItem = new ToolStripMenuItem("Show Breadcrumbs");
-      ShowBreadcrumbsToolStripMenuItem.Click += ShowBreadcrumbsToolStripMenuItem_Click;
-      ShowBreadcrumbsToolStripMenuItem.CheckedChanged += ShowBreadcrumbsToolStripMenuItem_CheckedChanged;
+        InitializeComponent();
+      this.menuItems = new Dictionary<Type, ToolStripMenuItem>();
+      this.ignoredViewTypes = new List<Type>();
     }
 
     private object item;
     public object Item {
-      get { return item; }
+      get { return this.item; }
       set {
-        if (item != value) {
-          item = value;
-          RefreshMenuItems();
+        if (this.item != value) {
+          this.item = value;
+          this.RefreshMenuItems();
         }
       }
@@ -57 +54 @@
     private List<Type> ignoredViewTypes;
     public IEnumerable<Type> IgnoredViewTypes {
-      get { return ignoredViewTypes; }
-      set { ignoredViewTypes = new List<Type>(value); RefreshMenuItems(); }
+      get { return this.ignoredViewTypes; }
+      set { this.ignoredViewTypes = new List<Type>(value); RefreshMenuItems(); }
     }
 
     private Dictionary<Type, ToolStripMenuItem> menuItems;
     public IEnumerable<KeyValuePair<Type, ToolStripMenuItem>> MenuItems {
-      get { return menuItems; }
+      get { return this.menuItems; }
     }
-
-    public ToolStripMenuItem ShowBreadcrumbsToolStripMenuItem { get; private set; }
 
     private void RefreshMenuItems() {
@@ -73 +68 @@
         foreach (ToolStripMenuItem m in menuItems.Values)
           m.Dispose();
-        Items.Clear();
-        menuItems.Clear();
+        this.Items.Clear();
+        this.menuItems.Clear();
 
-        if (item != null) {
+        if (this.item != null) {
           ToolStripMenuItem menuItem;
           IEnumerable<Type> types = MainFormManager.GetViewTypes(item.GetType(), true);
@@ -84 +79 @@
             menuItem.Text = ViewAttribute.GetViewName(t);
 
-            menuItems.Add(t, menuItem);
-            Items.Add(menuItem);
+            this.menuItems.Add(t, menuItem);
+            this.Items.Add(menuItem);
           }
-          if (Items.Count > 0)
-            Items.Add(new ToolStripSeparator());
-          Items.Add(ShowBreadcrumbsToolStripMenuItem);
         }
       }
     }
-
-    public event EventHandler ShowBreadcrumbsChanged;
-    private void OnShowBreadcrumbsChanged() {
-      var handler = ShowBreadcrumbsChanged;
-      if (handler != null) handler(this, EventArgs.Empty);
-    }
-
-    private void ShowBreadcrumbsToolStripMenuItem_CheckedChanged(object sender, EventArgs e) {
-      OnShowBreadcrumbsChanged();
-    }
-
-    private void ShowBreadcrumbsToolStripMenuItem_Click(object sender, EventArgs e) {
-      ShowBreadcrumbsToolStripMenuItem.Checked = !ShowBreadcrumbsToolStripMenuItem.Checked;
-    }
   }
 }

branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms/3.3/Controls/ViewHost.Designer.cs

@@ -52 +52 @@
       this.configurationLabel = new System.Windows.Forms.Label();
       this.helpLabel = new System.Windows.Forms.Label();
-      this.breadcrumbControl = new HeuristicLab.MainForm.WindowsForms.BreadcrumbControl();
       this.SuspendLayout();
       // 
@@ -87 +86 @@
       this.viewContextMenuStrip.Name = "viewContextMenuStrip";
       this.viewContextMenuStrip.Size = new System.Drawing.Size(61, 4);
-      this.viewContextMenuStrip.ShowBreadcrumbsChanged += new System.EventHandler(this.viewContextMenuStrip_ShowBreadcrumbsChanged);
       this.viewContextMenuStrip.ItemClicked += new System.Windows.Forms.ToolStripItemClickedEventHandler(this.viewContextMenuStrip_ItemClicked);
       // 
@@ -116 +114 @@
       this.helpLabel.DoubleClick += new System.EventHandler(this.helpLabel_DoubleClick);
       // 
-      // breadcrumbControl
-      // 
-      this.breadcrumbControl.Anchor = ((System.Windows.Forms.AnchorStyles)(((System.Windows.Forms.AnchorStyles.Top | System.Windows.Forms.AnchorStyles.Left) 
-            | System.Windows.Forms.AnchorStyles.Right)));
-      this.breadcrumbControl.Location = new System.Drawing.Point(0, 0);
-      this.breadcrumbControl.Name = "breadcrumbControl";
-      this.breadcrumbControl.Size = new System.Drawing.Size(202, 15);
-      this.breadcrumbControl.TabIndex = 4;
-      this.breadcrumbControl.ViewHost = null;
-      // 
       // ViewHost
       // 
+      this.AutoScaleDimensions = new System.Drawing.SizeF(6F, 13F);
       this.AutoScaleMode = System.Windows.Forms.AutoScaleMode.Inherit;
-      this.Controls.Add(this.breadcrumbControl);
       this.Controls.Add(this.helpLabel);
       this.Controls.Add(this.viewsLabel);
@@ -136 +124 @@
       this.Name = "ViewHost";
       this.Size = new System.Drawing.Size(227, 184);
-      this.VisibleChanged += new System.EventHandler(this.ViewHost_VisibleChanged);
       this.ResumeLayout(false);
 
@@ -148 +135 @@
     private System.Windows.Forms.Label configurationLabel;
     private System.Windows.Forms.Label helpLabel;
-    private BreadcrumbControl breadcrumbControl;
 
   }

branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms/3.3/Controls/ViewHost.cs

@@ -33 +33 @@
       InitializeComponent();
       startDragAndDrop = false;
-      viewContextMenuStrip.IgnoredViewTypes = new List<Type> { typeof(ViewHost) };
+      viewContextMenuStrip.IgnoredViewTypes = new List<Type>() { typeof(ViewHost) };
 
       viewType = null;
@@ -41 +41 @@
       viewsLabel.Visible = false;
       viewsLabelVisible = true;
-
-      breadcrumbControl.ViewHost = this;
     }
 
@@ -53 +51 @@
           viewsLabel.Visible = value;
           View view = activeView as View;
-          if (view != null) AdjustActiveViewSize();
-        }
-      }
-    }
-
-    public bool HotlinkingEnabled { get; set; }
+          if (view != null) view.Dock = viewsLabelVisible ? DockStyle.None : DockStyle.Fill;
+        }
+      }
+    }
 
     private IContentView cachedView;
@@ -91 +87 @@
             #endregion
 
-            Caption = activeView.Caption;
+            this.Caption = activeView.Caption;
             viewType = activeView.GetType();
             RegisterActiveViewEvents();
@@ -97 +93 @@
             if (view != null) {
               view.Visible = true;
-              AdjustActiveViewSize();
+              if (ViewsLabelVisible) {
+                view.Anchor = AnchorStyles.Bottom | AnchorStyles.Left | AnchorStyles.Top | AnchorStyles.Right;
+                view.Size = new Size(Width - this.viewsLabel.Width - this.viewsLabel.Margin.Left - this.viewsLabel.Margin.Right, this.Height);
+              } else view.Dock = DockStyle.Fill;
               if (!Controls.Contains((view))) Controls.Add(view);
               view.OnShown(new ViewShownEventArgs(view, false));
@@ -126 +125 @@
       }
     }
-
-    public bool ShowBreadcrumbs {
-      get { return viewContextMenuStrip.ShowBreadcrumbsToolStripMenuItem.Checked; }
-      set { viewContextMenuStrip.ShowBreadcrumbsToolStripMenuItem.Checked = value; }
-    }
-
-    public IEnumerable<IContent> Breadcrumbs { get { return breadcrumbControl.Breadcrumbs; } }
 
     protected override void SetEnabledStateOfControls() {
@@ -159 +151 @@
       UpdateLabels();
       UpdateActiveMenuItem();
-      UpdateBreadcrumbControl();
     }
 
@@ -210 +201 @@
       OnChanged();
     }
-    private void ViewHost_VisibleChanged(object sender, EventArgs e) {
-      PerformOutermostViewHostDetection();
-    }
-    private void viewContextMenuStrip_ShowBreadcrumbsChanged(object sender, EventArgs e) {
-      UpdateBreadcrumbControl();
-      AdjustActiveViewSize();
-    }
 
     protected override void OnSizeChanged(EventArgs e) {
@@ -279 +263 @@
     }
 
-    private void UpdateBreadcrumbControl() {
-      breadcrumbControl.Visible = ShowBreadcrumbs && Content != null;
-      if (ShowBreadcrumbs)
-        UpdateBreadcrumbTrail(breadcrumbControl.Breadcrumbs, BuildBreadcrumbTrail());
-    }
-
     private bool ViewCanShowContent(Type viewType, object content) {
       if (content == null) // every view can display null
@@ -296 +274 @@
       IContentView view = MainFormManager.MainForm.ShowContent(this.Content, this.ViewType);
       if (view != null) {
-        view.ReadOnly = ReadOnly;
-        view.Locked = Locked;
+        view.ReadOnly = this.ReadOnly;
+        view.Locked = this.Locked;
       }
     }
@@ -307 +285 @@
     private bool startDragAndDrop;
     private void viewsLabel_MouseDown(object sender, MouseEventArgs e) {
-      if (e.Button == MouseButtons.Right) {
+      if (e.Button == System.Windows.Forms.MouseButtons.Right) {
         Screen screen = Screen.FromControl(viewsLabel);
-        int rightBorder = viewsLabel.PointToScreen(viewsLabel.Location).X + viewContextMenuStrip.Width;
+        int rightBorder = viewsLabel.PointToScreen(viewsLabel.Location).X + viewContextMenuStrip.Width; //
         rightBorder = rightBorder - screen.Bounds.X; //pixel position on active screen
 
@@ -341 +319 @@
     }
     #endregion
-
-    #region Helpers
-    private void AdjustActiveViewSize() {
-      var view = activeView as View;
-      if (view == null) return;
-      int width = viewsLabelVisible ? Width - viewsLabel.Width - viewsLabel.Margin.Left - viewsLabel.Margin.Right : Width;
-      int height = ShowBreadcrumbs ? Height - viewsLabel.Height - viewsLabel.Margin.Top - viewsLabel.Margin.Bottom : Height;
-      view.Location = new Point(0, Height - height);
-      view.Anchor = AnchorStyles.Bottom | AnchorStyles.Left | AnchorStyles.Top | AnchorStyles.Right;
-      view.Size = new Size(width, height);
-    }
-
-    private IEnumerable<IContent> BuildBreadcrumbTrail() {
-      var ll = new LinkedList<IContent>();
-      for (var control = (Control)this; control != null; control = control.Parent) {
-        var viewHost = control as ViewHost;
-        if (viewHost != null && viewHost.Content != null)
-          ll.AddFirst(viewHost.Content);
-      }
-      return ll;
-    }
-
-    public void UpdateBreadcrumbTrail(IEnumerable<IContent> oldCrumbs, IEnumerable<IContent> newCrumbs) {
-      if (!newCrumbs.Any()) return;
-      var ll = new LinkedList<IContent>();
-      if (newCrumbs.Contains(oldCrumbs.LastOrDefault())) {
-        foreach (var c in oldCrumbs) {
-          if (c != newCrumbs.First())
-            ll.AddLast(c);
-          else break;
-        }
-      }
-      foreach (var c in newCrumbs)
-        ll.AddLast(c);
-      breadcrumbControl.Breadcrumbs = ll;
-    }
-
-    private void PerformOutermostViewHostDetection() {
-      var parentContentViews = GetParentViewsOfType<ContentView>();
-      viewContextMenuStrip.ShowBreadcrumbsToolStripMenuItem.Checked = !parentContentViews.Any();
-    }
-    #endregion
   }
 }

branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms/3.3/HeuristicLab.MainForm.WindowsForms-3.3.csproj

@@ -120 +120 @@
   <ItemGroup>
     <Compile Include="ActionUserInterfaceItem.cs" />
-    <Compile Include="Controls\BreadcrumbControl.cs">
-      <SubType>UserControl</SubType>
-    </Compile>
-    <Compile Include="Controls\BreadcrumbControl.Designer.cs">
-      <DependentUpon>BreadcrumbControl.cs</DependentUpon>
-    </Compile>
     <Compile Include="Controls\DragOverTabControl.cs">
       <SubType>Component</SubType>

branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms/3.3/MainForms/MainForm.cs

@@ -223 +223 @@
     }
 
-    public T GetOutermostControlOfType<T>(Control childControl) where T : Control {
-      if (childControl == null) throw new ArgumentNullException("childControl", "ChildControl cannot be null.");
-
-      T outermostControl = null;
-      for (var control = childControl; control != null; control = control.Parent) {
-        var c = control as T;
-        if (c != null) outermostControl = c;
-      }
-      return outermostControl;
-    }
-
     public IContentView ShowContent(IContent content) {
       if (content == null) throw new ArgumentNullException("Content cannot be null.");
@@ -241 +230 @@
     }
 
-    public IContentView ShowContent<T>(T content, bool reuseExistingView, IEqualityComparer<T> comparer = null) where T : class, IContent {
+    public IContentView ShowContent<T>(T content, bool reuseExistingView, IEqualityComparer<T> comparer = null) where T : class,IContent {
       if (content == null) throw new ArgumentNullException("Content cannot be null.");
       if (!reuseExistingView) return ShowContent(content);
@@ -273 +262 @@
         return view;
       }
-    }
-
-    public ViewHost ShowContentInOutermostViewHost(IContent content, Control childControl, bool requireHotlinking = false) {
-      if (content == null) throw new ArgumentNullException("content", "Content cannot be null.");
-      if (childControl == null) throw new ArgumentNullException("childControl", "ChildControl cannot be null.");
-
-      var outermostViewHost = GetOutermostControlOfType<ViewHost>(childControl);
-      if (outermostViewHost == null) return null;
-
-      if (!requireHotlinking || outermostViewHost.HotlinkingEnabled) {
-        var oldCrumbs = outermostViewHost.Breadcrumbs;
-        var newCrumbs = new LinkedList<IContent>();
-        for (var control = childControl; control != null; control = control.Parent) {
-          var vh = control as ViewHost;
-          if (vh != null && vh.Content != null)
-            newCrumbs.AddFirst(vh.Content);
-        }
-        bool showBreadcrumbs = outermostViewHost.ShowBreadcrumbs;
-        outermostViewHost.Content = null;
-        var viewType = MainFormManager.GetDefaultViewType(content.GetType());
-        outermostViewHost.ViewType = viewType;
-        outermostViewHost.Content = content;
-        outermostViewHost.UpdateBreadcrumbTrail(oldCrumbs, newCrumbs.Concat(new[] { content }));
-        outermostViewHost.ShowBreadcrumbs = showBreadcrumbs;
-      }
-      return outermostViewHost;
     }
 
@@ -587 +550 @@
       try {
         ((IActionUserInterfaceItem)item.Tag).Execute();
-      } catch (Exception ex) {
+      }
+      catch (Exception ex) {
         ErrorHandling.ShowErrorDialog((Control)MainFormManager.MainForm, ex);
       }

branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms/3.3/Views/View.cs

@@ -21 +21 @@
 
 using System;
-using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
@@ -262 +261 @@
         ((Control)this).ResumeRepaint(refresh);
     }
-
-    public IEnumerable<T> GetParentViewsOfType<T>() where T : View {
-      for (var view = Parent; view != null; view = view.Parent)
-        if (view is View) yield return view as T;
-    }
   }
 }

branches/Breadcrumbs/HeuristicLab.Operators.Views.GraphVisualization.Views/3.3/OperatorGraphView.cs

@@ -140 +140 @@
           if (shapeInfo != null) {
             IOperator op = this.VisualizationInfo.GetOperatorForShapeInfo(shapeInfo);
-            var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-            var outermostViewHost = mainForm.ShowContentInOutermostViewHost(op, this);
-            if (outermostViewHost != null) {
-              outermostViewHost.ActiveView.ReadOnly = ReadOnly;
-              outermostViewHost.ActiveView.Locked = Locked;
+            IContentView view = MainFormManager.MainForm.ShowContent(op);
+            if (view != null) {
+              view.ReadOnly = this.ReadOnly;
+              view.Locked = this.Locked;
             }
             HandledMouseEventArgs eventArgs = e as HandledMouseEventArgs;
@@ -196 +195 @@
       if (shapeInfo != null) {
         IOperator op = this.VisualizationInfo.GetOperatorForShapeInfo(shapeInfo);
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(op, this);
-        if (outermostViewHost != null) {
-          outermostViewHost.ActiveView.ReadOnly = ReadOnly;
-          outermostViewHost.ActiveView.Locked = Locked;
+        IContentView view = MainFormManager.MainForm.ShowContent(op);
+        if (view != null) {
+          view.ReadOnly = this.ReadOnly;
+          view.Locked = this.Locked;
         }
       }

branches/Breadcrumbs/HeuristicLab.Optimization.Views/3.3/ResultCollectionView.cs

@@ -20 +20 @@
 #endregion
 
+using System;
 using HeuristicLab.Core;
 using HeuristicLab.Core.Views;
 using HeuristicLab.MainForm;
-using HeuristicLab.MainForm.WindowsForms;
 
 namespace HeuristicLab.Optimization.Views {
@@ -33 +33 @@
     public override bool ReadOnly {
       get { return true; }
-      set { /* not needed because results are always readonly */}
+      set { /*not needed because results are always readonly */}
     }
 
@@ -45 +45 @@
       return null;
     }
+
+    protected override void itemsListView_DoubleClick(object sender, EventArgs e) {
+      if (itemsListView.SelectedItems.Count == 1) {
+        IResult result = itemsListView.SelectedItems[0].Tag as IResult;
+        if (result != null) {
+          IContentView view = MainFormManager.MainForm.ShowContent(result, typeof(ResultView));
+          if (view != null) {
+            view.ReadOnly = ReadOnly;
+            view.Locked = Locked;
+          }
+        }
+      }
+    }
   }
 }

branches/Breadcrumbs/HeuristicLab.Optimization.Views/3.3/RunCollectionViews/RunCollectionView.cs

@@ -237 +237 @@
     #region ListView Events
     private void itemsListView_SelectedIndexChanged(object sender, EventArgs e) {
-      removeButton.Enabled = Content != null && !Content.IsReadOnly && !ReadOnly && itemsListView.SelectedItems.Count > 0;
+      removeButton.Enabled = itemsListView.SelectedItems.Count > 0 && (Content != null) && !Content.IsReadOnly && !ReadOnly;
       // for performance reason (multiple selection fires this handler for every selected item)
       if (itemsListView.SelectedIndices.Count <= 1)
         AdjustListViewColumnSizes();
-      if (itemsListView.SelectedItems.Count == 1) {
-        var item = (IRun)itemsListView.SelectedItems[0].Tag;
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(item, this, true);
-        if (outermostViewHost != null && outermostViewHost.HotlinkingEnabled) {
-          outermostViewHost.ActiveView.ReadOnly = ReadOnly;
-          outermostViewHost.ActiveView.Locked = Locked;
+      if (showDetailsCheckBox.Checked) {
+        if (itemsListView.SelectedItems.Count == 1) {
+          IRun item = (IRun)itemsListView.SelectedItems[0].Tag;
+          detailsGroupBox.Enabled = true;
+          viewHost.Content = item;
         } else {
-          if (showDetailsCheckBox.Checked) {
-            detailsGroupBox.Enabled = true;
-            viewHost.Content = item;
-          } else {
-            viewHost.Content = null;
-            detailsGroupBox.Enabled = false;
-          }
+          viewHost.Content = null;
+          detailsGroupBox.Enabled = false;
         }
       }
@@ -273 +266 @@
     private void itemsListView_DoubleClick(object sender, EventArgs e) {
       if (itemsListView.SelectedItems.Count == 1) {
-        var item = (IRun)itemsListView.SelectedItems[0].Tag;
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(item, this);
-        if (outermostViewHost != null) {
-          outermostViewHost.ActiveView.ReadOnly = ReadOnly;
-          outermostViewHost.ActiveView.Locked = Locked;
+        IRun item = itemsListView.SelectedItems[0].Tag as IRun;
+        if (item != null) {
+          IContentView view = MainFormManager.MainForm.ShowContent(item);
+          if (view != null) {
+            view.ReadOnly = ReadOnly;
+            view.Locked = Locked;
+          }
         }
       }
@@ -391 +385 @@
       try {
         RunCollection.Modify();
-      } finally {
+      }
+      finally {
         ReadOnly = false;
       }

branches/Breadcrumbs/HeuristicLab.Optimization.Views/3.3/RunView.cs

@@ -26 +26 @@
 using HeuristicLab.Core.Views;
 using HeuristicLab.MainForm;
-using HeuristicLab.MainForm.WindowsForms;
 
 namespace HeuristicLab.Optimization.Views {
@@ -128 +127 @@
 
     private void listView_SelectedIndexChanged(object sender, EventArgs e) {
-      if (listView.SelectedItems.Count == 1) {
-        var item = (IItem)listView.SelectedItems[0].Tag;
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(item, this, true);
-        if (outermostViewHost != null && outermostViewHost.HotlinkingEnabled) {
-          outermostViewHost.ActiveView.ReadOnly = ReadOnly;
-          outermostViewHost.ActiveView.Locked = Locked;
+      if (showDetailsCheckBox.Checked) {
+        if (listView.SelectedItems.Count == 1) {
+          detailsGroupBox.Enabled = true;
+          viewHost.Content = listView.SelectedItems[0].Tag as IContent;
         } else {
-          if (showDetailsCheckBox.Checked) {
-            detailsGroupBox.Enabled = true;
-            viewHost.Content = item;
-          } else {
-            viewHost.Content = null;
-            detailsGroupBox.Enabled = false;
-          }
+          viewHost.Content = null;
+          detailsGroupBox.Enabled = false;
         }
       }
@@ -148 +139 @@
     private void listView_DoubleClick(object sender, EventArgs e) {
       if (listView.SelectedItems.Count == 1) {
-        var item = (IItem)listView.SelectedItems[0].Tag;
-        var mainForm = MainFormManager.GetMainForm<MainForm.WindowsForms.MainForm>();
-        var outermostViewHost = mainForm.ShowContentInOutermostViewHost(item, this);
-        if (outermostViewHost != null) {
-          outermostViewHost.ActiveView.ReadOnly = ReadOnly;
-          outermostViewHost.ActiveView.Locked = Locked;
+        IItem item = (IItem)listView.SelectedItems[0].Tag;
+        IContentView view = MainFormManager.MainForm.ShowContent(item);
+        if (view != null) {
+          view.ReadOnly = true;
+          view.Locked = Locked;
         }
       }