Changeset 10819 for branches

Timestamp:

05/07/14 15:18:41 (10 years ago)

Author:

pfleck

Message:

• Implemented handling of transformation error messages.

Location:

branches/DataPreprocessing

Files:

• HeuristicLab.DataPreprocessing.Views/3.3/TransformationView.cs (modified) (2 diffs)
• HeuristicLab.DataPreprocessing/3.3/PreprocessingTransformator.cs (modified) (2 diffs)

branches/DataPreprocessing/HeuristicLab.DataPreprocessing.Views/3.3/TransformationView.cs

@@ -22 +22 @@
 using System;
 using System.Windows.Forms;
-using HeuristicLab.Data;
 using HeuristicLab.MainForm;
 using HeuristicLab.MainForm.WindowsForms;
@@ -54 +53 @@
 
       var transformator = new PreprocessingTransformator(Content.Data);
-      bool success = transformator.ApplyTransformations(transformations);
+      string errorMsg;
+      bool success = transformator.ApplyTransformations(transformations, out errorMsg);
       if (success) {
-        //foreach (var transformation in transformations)
-        //  Content.CheckedTransformationCollection.SetItemCheckedState(transformation, false);
         Content.CheckedTransformationCollection.Clear();
         MessageBox.Show(this, "Transformations applied.", "Success", MessageBoxButtons.OK, MessageBoxIcon.Information);
+      } else {
+        MessageBox.Show(this,
+          "Error in Transformation.\nValue is copied when transformion of cell failed.\n" + errorMsg,
+          "Transformation failed", MessageBoxButtons.OK, MessageBoxIcon.Warning);
       }
+
     }
   }

branches/DataPreprocessing/HeuristicLab.DataPreprocessing/3.3/PreprocessingTransformator.cs

@@ -33 +33 @@
     }
 
-    public bool ApplyTransformations(IEnumerable<ITransformation> transformations) {
-      bool success = true;
+    public bool ApplyTransformations(IEnumerable<ITransformation> transformations, out string errorMsg) {
+      bool success;
 
-      preprocessingData.InTransaction(() => {
+      preprocessingData.BeginTransaction(DataPreprocessingChangedEventType.Transformation);
+      try {
         var doubleTransformations = transformations.OfType<Transformation<double>>().ToList();
-        ApplyDoubleTranformations(doubleTransformations, out success);
-      }, DataPreprocessingChangedEventType.Transformation);
-
-      if (!success) {
-        preprocessingData.Undo();
+        ApplyDoubleTranformations(doubleTransformations, out success, out errorMsg);
+      } finally {
+        preprocessingData.EndTransaction();
+        //if (!success)
+        //preprocessingData.Undo();
       }
 
@@ -48 +49 @@
     }
 
-    private void ApplyDoubleTranformations(IEnumerable<Transformation<double>> transformations, out bool success) {
+    private void ApplyDoubleTranformations(IEnumerable<Transformation<double>> transformations, out bool success, out string errorMsg) {
+      errorMsg = string.Empty;
+      success = true;
       foreach (var transformation in transformations) {
         int colIndex = preprocessingData.GetColumnIndex(transformation.Column);
 
         var originalData = preprocessingData.GetValues<double>(colIndex);
-        var transformedData = ApplyDoubleTransformation(transformation, originalData, out success);
-        if (!success) return;
-
+        string errorMsgPart;
+        bool successPart;
+        var transformedData = ApplyDoubleTransformation(transformation, originalData, out successPart, out errorMsgPart);
+        errorMsg += errorMsgPart + Environment.NewLine;
+        //if (!success) return;
+        if (!successPart) success = false;
         preprocessingData.SetValues(colIndex, transformedData.ToList());
         preprocessingData.Transformations.Add(transformation);
       }
-      success = true;
+
     }
 
-    private IEnumerable<double> ApplyDoubleTransformation(Transformation<double> transformation, IEnumerable<double> data, out bool success) {
-      string errorMsg;
-      if (transformation.Check(data, out errorMsg)) {
-        success = true;
-        return transformation.Apply(data);
-      }
-      throw new NotImplementedException("Display Check Result");
+    private IEnumerable<double> ApplyDoubleTransformation(Transformation<double> transformation, IEnumerable<double> data, out bool success, out string errorMsg) {
+      success = transformation.Check(data, out errorMsg);
+      return transformation.Apply(data);
     }
   }