Changeset 10477

Timestamp:

02/20/14 14:14:55 (11 years ago)

Author:

gkronber

Message:

#2106 changed ListExtensions.StableSort to behave in the same way as ArrayExtensions.StableSort() as suggested in the review comments

File:

• trunk/sources/HeuristicLab.Common/3.3/ListExtensions.cs (modified) (3 diffs)

trunk/sources/HeuristicLab.Common/3.3/ListExtensions.cs

@@ -31 +31 @@
 
     public static void StableSort<T>(this List<T> values, int index, int count) {
-      var orderedList = values.Skip(index).Take(count).OrderBy(x => x).ToList();
-      values.Clear();
-      values.AddRange(orderedList);
+      var orderedList = values.Skip(index).Take(count).OrderBy(x => x);
+      int i = index;
+      foreach (var e in orderedList)
+        values[i++] = e;
     }
 
@@ -41 +42 @@
 
     public static void StableSort<T>(this List<T> values, int index, int count, IComparer<T> comparer) {
-      var orderedList = values.OrderBy(x => x, comparer).ToList();
-      values.Clear();
-      values.AddRange(orderedList);
+      var orderedList = values.OrderBy(x => x, comparer);
+      int i = 0;
+      foreach (var e in orderedList)
+        values[i++] = e;
     }
 
@@ -51 +53 @@
 
     public static void StableSort<T>(this List<T> values, int index, int count, Comparison<T> comparison) {
-      var orderedList = values.OrderBy(x => x, new StableSortComparer<T>(comparison)).ToList();
-      values.Clear();
-      values.AddRange(orderedList);
+      var orderedList = values.OrderBy(x => x, new StableSortComparer<T>(comparison));
+      int i = 0;
+      foreach (var e in orderedList)
+        values[i++] = e;
     }