Changeset 10103 for branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms

Timestamp:

11/04/13 10:15:31 (11 years ago)

Author:

jkarder

Message:

#2116:

• fixed issues within the outermost control detection
• fixed visible property assignment of the breadcrumb control in ViewHost

Location:

branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms/3.3

Files:

• Controls/BreadcrumbControl.cs (modified) (1 diff)
• Controls/ViewHost.cs (modified) (6 diffs)
• MainForms/MainForm.cs (modified) (2 diffs)

branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms/3.3/Controls/BreadcrumbControl.cs

@@ -129 +129 @@
         breadcrumbs.RemoveLast();
       var mainForm = MainFormManager.GetMainForm<MainForm>();
-      var outermostViewHost = mainForm.GetOutermostViewOfType<ViewHost>(ViewHost);
+      var outermostViewHost = mainForm.GetOutermostControlOfType<ViewHost>(ViewHost);
       bool showBreadcrumbs = outermostViewHost.ShowBreadcrumbs;
       outermostViewHost.Content = null;

branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms/3.3/Controls/ViewHost.cs

@@ -22 +22 @@
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Drawing;
 using System.Linq;
@@ -41 +42 @@
       viewsLabel.Visible = false;
       viewsLabelVisible = true;
+      IsValidOutermostViewhost = true;
 
       breadcrumbControl.ViewHost = this;
@@ -59 +61 @@
 
     public bool HotlinkingEnabled { get; set; }
+
+    [DefaultValue(true)]
+    public bool IsValidOutermostViewhost { get; set; }
 
     private IContentView cachedView;
@@ -132 +137 @@
     }
 
-    private bool isOutermostViewHost;
     public IEnumerable<IContent> Breadcrumbs { get { return breadcrumbControl.Breadcrumbs; } }
 
@@ -281 +285 @@
 
     private void UpdateBreadcrumbControl() {
-      breadcrumbControl.Visible = ShowBreadcrumbs;
+      breadcrumbControl.Visible = ShowBreadcrumbs && Content != null;
       if (ShowBreadcrumbs)
         UpdateBreadcrumbTrail(breadcrumbControl.Breadcrumbs, BuildBreadcrumbTrail());
@@ -378 +382 @@
 
     private void PerformOutermostViewHostDetection() {
+      if (!IsValidOutermostViewhost) return;
       var mainForm = MainFormManager.GetMainForm<MainForm>();
-      if (mainForm == null) return;
-      var outermostViewHost = mainForm.GetOutermostViewOfType<ViewHost>(this);
-      isOutermostViewHost = outermostViewHost == this;
-      viewContextMenuStrip.ShowBreadcrumbsToolStripMenuItem.Checked = isOutermostViewHost;
+      if (mainForm == null) return; // needed for designer
+      var outermostViewHost = mainForm.GetOutermostControlOfType<ViewHost>(this);
+      viewContextMenuStrip.ShowBreadcrumbsToolStripMenuItem.Checked = outermostViewHost == this;
     }
     #endregion

branches/Breadcrumbs/HeuristicLab.MainForm.WindowsForms/3.3/MainForms/MainForm.cs

@@ -223 +223 @@
     }
 
-    public T GetOutermostViewOfType<T>(Control childControl) where T : class, IView {
+    public T GetOutermostControlOfType<T>(Control childControl) where T : Control {
       if (childControl == null) throw new ArgumentNullException("childControl", "ChildControl cannot be null.");
 
-      T outermostView = null;
+      T outermostControl = null;
       for (var control = childControl; control != null; control = control.Parent) {
-        var vh = control as T;
-        if (vh != null) outermostView = vh;
-      }
-      return outermostView;
+        var c = control as T;
+        if (c != null) outermostControl = c;
+      }
+      return outermostControl;
     }
 
@@ -279 +279 @@
       if (childControl == null) throw new ArgumentNullException("childControl", "ChildControl cannot be null.");
 
-      var outermostViewHost = GetOutermostViewOfType<ViewHost>(childControl);
-      if (outermostViewHost == null)
-        throw new ArgumentException("No outermost ViewHost could be found for the specified child control.", "childControl");
+      var outermostViewHost = GetOutermostControlOfType<ViewHost>(childControl);
+      if (outermostViewHost == null) return null;
 
       if (!requireHotlinking || outermostViewHost.HotlinkingEnabled) {