Changeset 10075 for branches/GrammaticalEvolution/HeuristicLab.Problems.GrammaticalEvolution/Mappers

Timestamp:

10/21/13 11:29:55 (11 years ago)

Author:

sawinkle

Message:

#2109:

• For each newly created node, ResetLocalParameters() has to be called, if possible. Otherwise 'Variable' symbols won't be initialized correctly. (E.g. internal ValueName is null and causes exceptions.)
• Method MapDepthFirstRecursively() of DepthFirstMapper.cs checks subtree boundaries by using the MinimumArity instead of the MaximumArity. Otherwise e.g. adding the 'Addition' symbol will cause very short trees, because this symbol has got a MaximumArity of 255! This would cause, that the tree is immediately full, after insertion of one 'Addition' symbol, if the genotype length is e.g. just 100.
• Several bug fixes.
• Unresolved issues:
  • Changes in the selected grammar are not taken into account during a run (e.g. 'Addition' symbols will be inserted into the tree, although its checkbox was unchecked previously).
  • Exception, if a division by zero is tried.
  • Wrapping mechanism.

Location:

branches/GrammaticalEvolution/HeuristicLab.Problems.GrammaticalEvolution/Mappers

Files:

• DepthFirstMapper.cs (modified) (5 diffs)
• GenotypeToPhenotypeMapper.cs (modified) (2 diffs)

branches/GrammaticalEvolution/HeuristicLab.Problems.GrammaticalEvolution/Mappers/DepthFirstMapper.cs

@@ -25 +25 @@
 using HeuristicLab.Encodings.SymbolicExpressionTreeEncoding;
 using HeuristicLab.Persistence.Default.CompositeSerializers.Storable;
+using HeuristicLab.Random;
 
 namespace HeuristicLab.Problems.GrammaticalEvolution {
@@ -56 +57 @@
       SymbolicExpressionTree tree = new SymbolicExpressionTree();
       var rootNode = (SymbolicExpressionTreeTopLevelNode)grammar.ProgramRootSymbol.CreateTreeNode();
+      if (rootNode.HasLocalParameters) rootNode.ResetLocalParameters(new MersenneTwister());
       var startNode = (SymbolicExpressionTreeTopLevelNode)grammar.StartSymbol.CreateTreeNode();
+      if (startNode.HasLocalParameters) startNode.ResetLocalParameters(new MersenneTwister());
       rootNode.AddSubtree(startNode);
       tree.Root = rootNode;
@@ -96 +99 @@
         var newNode = GetNewChildNode(currentNode, genotype, grammar, genotypeIndex);
 
-        if ((currSubtreeCount + newNode.Symbol.MaximumArity) > maxSubtreeCount) {
+        if ((currSubtreeCount + newNode.Symbol.MinimumArity) > maxSubtreeCount) {
           // TODO: maybe check, if there is any node, which fits in the tree yet
           currentNode.AddSubtree(GetRandomTerminalNode(currentNode, grammar));
@@ -102 +105 @@
           currentNode.AddSubtree(newNode);
           genotypeIndex++;
-          currSubtreeCount += newNode.Symbol.MaximumArity;
+          currSubtreeCount += newNode.Symbol.MinimumArity;
 
-          while (newNode.Symbol.MaximumArity > newNode.SubtreeCount) {
+          while (newNode.Symbol.MinimumArity > newNode.SubtreeCount) {
             MapDepthFirstRecursively(newNode, genotype,
                                      grammar, maxSubtreeCount,
@@ -112 +115 @@
 
       } else {
-        while (currentNode.Symbol.MaximumArity > currentNode.SubtreeCount) {
+        while (currentNode.Symbol.MinimumArity > currentNode.SubtreeCount) {
           var newNode = GetNewChildNode(currentNode, genotype, grammar, genotypeIndex);
           currentNode.AddSubtree(newNode);
           genotypeIndex++;
-          while (newNode.Symbol.MaximumArity > newNode.SubtreeCount) {
+          while (newNode.Symbol.MinimumArity > newNode.SubtreeCount) {
             newNode.AddSubtree(GetRandomTerminalNode(newNode, grammar));
           }

branches/GrammaticalEvolution/HeuristicLab.Problems.GrammaticalEvolution/Mappers/GenotypeToPhenotypeMapper.cs

@@ -52 +52 @@
     protected ISymbolicExpressionTreeNode GetRandomTerminalNode(ISymbolicExpressionTreeNode parentNode,
                                                               ISymbolicExpressionGrammar grammar) {
-      var possibleSymbolsList = from s in grammar.GetAllowedChildSymbols(parentNode.Symbol)
-                                where s.MaximumArity == 0
-                                where s.MinimumArity == 0
-                                select s;
-      // TODO: Check, if symbol list is empty (no terminal nodes found) - what should happen? 
-      return possibleSymbolsList.SelectRandom(new MersenneTwister()).CreateTreeNode();
+      // only select specific symbols, which can be interpreted ...
+      var possibleSymbolsList = (from s in grammar.GetAllowedChildSymbols(parentNode.Symbol)
+                                 where s.InitialFrequency > 0.0
+                                 where s.MaximumArity == 0
+                                 where s.MinimumArity == 0
+                                 select s).ToList();
+      // TODO: Check, if symbol list is empty (no terminal nodes found) - what should happen?
+      var newNode = possibleSymbolsList.SelectRandom(new MersenneTwister()).CreateTreeNode();
+      if (newNode.HasLocalParameters) newNode.ResetLocalParameters(new MersenneTwister());
+      return newNode;
     }
 
@@ -74 +78 @@
                                                           int genotypeIndex) {
 
-      IEnumerable<ISymbol> symbolList = grammar.GetAllowedChildSymbols(parentNode.Symbol);
+      // only select specific symbols, which can be interpreted ...
+      IEnumerable<ISymbol> symbolList = (from s in grammar.GetAllowedChildSymbols(parentNode.Symbol)
+                                         where s.InitialFrequency > 0.0
+                                         select s).ToList();
       int prodRuleCount = symbolList.Count();
       int prodRuleIndex = genotype[genotypeIndex % genotype.Length] % prodRuleCount;
 
-      return symbolList.ElementAt(prodRuleIndex).CreateTreeNode();
+      var newNode = symbolList.ElementAt(prodRuleIndex).CreateTreeNode();
+      if (newNode.HasLocalParameters) newNode.ResetLocalParameters(new MersenneTwister());
+      return newNode;
     }
   }