Changeset 17445

Timestamp:

02/19/20 13:50:24 (4 years ago)

Author:

jkarder

Message:

#3060: catch unhandled exceptions thrown by IOptimizer.StartAsync()

Location:

trunk

Files:

• HeuristicLab.Algorithms.DataAnalysis.Views/3.4/CrossValidationView.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive.Slave/3.3/Executor.cs (modified) (3 diffs)
• HeuristicLab.Clients.Hive/3.3/Tasks/EngineTask.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive/3.3/Tasks/OptimizerTask.cs (modified) (1 diff)
• HeuristicLab.Clients.OKB.Views/3.3/RunCreation/Views/OKBAlgorithmView.cs (modified) (1 diff)
• HeuristicLab.Optimization.Views/3.3/IOptimizerView.cs (modified) (1 diff)

trunk/HeuristicLab.Algorithms.DataAnalysis.Views/3.4/CrossValidationView.cs

@@ -223 +223 @@
 
     private async void startButton_Click(object sender, EventArgs e) {
-      await Content.StartAsync();
+      try {
+        await Content.StartAsync();
+      } catch (Exception ex) {
+        ErrorHandling.ShowErrorDialog(this, ex);
+      }
     }
     private void pauseButton_Click(object sender, EventArgs e) {

trunk/HeuristicLab.Clients.Hive.Slave/3.3/Executor.cs

@@ -46 +46 @@
     public bool IsStopping { get; set; }
     public bool IsPausing { get; set; }
+    public bool HasFailed { get; set; }
 
     public Exception CurrentException;
@@ -84 +85 @@
 
         task.Start();
-        if (!startTaskSem.WaitOne(Settings.Default.ExecutorSemTimeouts)) {
+        if (!startTaskSem.WaitOne(Settings.Default.ExecutorSemTimeouts) && !HasFailed) {
           throw new TimeoutException("Timeout when starting the task. TaskStarted event was not fired.");
         }
@@ -159 +160 @@
     #region Task Events
     private void Task_TaskFailed(object sender, EventArgs e) {
+      HasFailed = true;
       IsStopping = true;
       EventArgs<Exception> ex = (EventArgs<Exception>)e;
       CurrentException = ex.Value;
       executorQueue.AddMessage(ExecutorMessageType.TaskFailed);
+      startTaskSem.Set(); // cancel waiting for startup
     }
 

trunk/HeuristicLab.Clients.Hive/3.3/Tasks/EngineTask.cs

@@ -80 +80 @@
 
     public override async void Start() {
-      Item.Prepare(initialOperation);
-      await Item.StartAsync();
+      try {
+        Item.Prepare(initialOperation);
+        await Item.StartAsync();
+      } catch (Exception e) {
+        engine_ExceptionOccurred(Item, new EventArgs<Exception>(e));
+      }
     }
 

trunk/HeuristicLab.Clients.Hive/3.3/Tasks/OptimizerTask.cs

@@ -101 +101 @@
         OnTaskStopped();
       } else {
-        await Item.StartAsync();
+        try {
+          await Item.StartAsync();
+        } catch (Exception e) {
+          optimizer_ExceptionOccurred(Item, new EventArgs<Exception>(e));
+        }
       }
     }

trunk/HeuristicLab.Clients.OKB.Views/3.3/RunCreation/Views/OKBAlgorithmView.cs

@@ -325 +325 @@
     }
     private async void startButton_Click(object sender, EventArgs e) {
-      await Content.StartAsync();
+      try {
+        await Content.StartAsync();
+      } catch (Exception ex) {
+        ErrorHandling.ShowErrorDialog(this, ex);
+      }
     }
     private void pauseButton_Click(object sender, EventArgs e) {

trunk/HeuristicLab.Optimization.Views/3.3/IOptimizerView.cs

@@ -137 +137 @@
     #region Control events
     protected virtual async void startButton_Click(object sender, EventArgs e) {
-      await Content.StartAsync();
+      try {
+        await Content.StartAsync();
+      } catch (Exception ex) {
+        ErrorHandling.ShowErrorDialog(this, ex);
+      }
     }
     protected virtual void pauseButton_Click(object sender, EventArgs e) {