Changeset 12614

Timestamp:

07/06/15 18:00:54 (9 years ago)

Author:

abeham

Message:

#2274: Fixed bug in cluster visualization view and added nicer bounds in scatter plot

Location:

trunk/sources

Files:

• HeuristicLab.Analysis.Views/3.3/ScatterPlotView.cs (modified) (13 diffs)
• HeuristicLab.Problems.DataAnalysis.Views/3.4/Clustering/ClusteringSolutionVisualizationView.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Analysis.Views/3.3/ScatterPlotView.cs

@@ -37 +37 @@
     protected List<Series> invisibleSeries;
     protected Dictionary<IObservableList<Point2D<double>>, ScatterPlotDataRow> pointsRowsTable;
+    private double xMin, xMax, yMin, yMax;
 
     public new ScatterPlot Content {
@@ -102 +103 @@
         AddScatterPlotDataRows(Content.Rows);
         ConfigureChartArea(chart.ChartAreas[0]);
+        RecalculateMinMaxPointValues();
         RecalculateAxesScale(chart.ChartAreas[0]);
       }
@@ -130 +132 @@
       }
       ConfigureChartArea(chart.ChartAreas[0]);
+      RecalculateMinMaxPointValues();
       RecalculateAxesScale(chart.ChartAreas[0]);
       UpdateYCursorInterval();
@@ -142 +145 @@
           invisibleSeries.Remove(series);
       }
+      RecalculateMinMaxPointValues();
       RecalculateAxesScale(chart.ChartAreas[0]);
     }
@@ -193 +197 @@
     private void RecalculateAxesScale(ChartArea area) {
       // Reset the axes bounds so that RecalculateAxesScale() will assign new bounds
-      foreach (Axis a in area.Axes) {
-        a.Minimum = double.NaN;
-        a.Maximum = double.NaN;
-      }
-      area.RecalculateAxesScale();
+      area.AxisX.Minimum = CalculateMinBound(xMin);
+      area.AxisX.Maximum = CalculateMaxBound(xMax);
+      area.AxisY.Minimum = CalculateMinBound(yMin);
+      area.AxisY.Maximum = CalculateMaxBound(yMax);
       area.AxisX.IsMarginVisible = false;
 
@@ -204 +207 @@
       if (!Content.VisualProperties.YAxisMinimumAuto && !double.IsNaN(Content.VisualProperties.YAxisMinimumFixedValue)) area.AxisY.Minimum = Content.VisualProperties.YAxisMinimumFixedValue;
       if (!Content.VisualProperties.YAxisMaximumAuto && !double.IsNaN(Content.VisualProperties.YAxisMaximumFixedValue)) area.AxisY.Maximum = Content.VisualProperties.YAxisMaximumFixedValue;
-      if (area.AxisX.Minimum >= area.AxisX.Maximum) area.AxisX.Maximum = area.AxisX.Minimum + 1;
-      if (area.AxisY.Minimum >= area.AxisY.Maximum) area.AxisY.Maximum = area.AxisY.Minimum + 1;
+    }
+
+    private static double CalculateMinBound(double min) {
+      double newMin;
+      if (min < 0) {
+        newMin = -Math.Pow(10, Math.Ceiling(Math.Log10(Math.Abs(min))));
+        if (newMin / 1.25 < min) newMin /= 1.25;
+        if (newMin / 1.6 < min) newMin /= 1.6;
+        if (newMin / 2.5 < min) newMin /= 2.5;
+        if (newMin / 2.0 < min) newMin /= 2.0;
+      } else {
+        newMin = Math.Pow(10, Math.Floor(Math.Log10(min)));
+        if (newMin * 1.25 < min) newMin *= 1.25;
+        if (newMin * 1.6 < min) newMin *= 1.6;
+        if (newMin * 2.5 < min) newMin *= 2.5;
+        if (newMin * 2.0 < min) newMin *= 2.0;
+      }
+      return newMin;
+    }
+
+    private static double CalculateMaxBound(double max) {
+      double newMax;
+      if (max < 0) {
+        newMax = -Math.Pow(10, Math.Floor(Math.Log10(Math.Abs(max))));
+        if (newMax * 1.25 > max) newMax *= 1.25;
+        if (newMax * 1.6 > max) newMax *= 1.6;
+        if (newMax * 2.5 > max) newMax *= 2.5;
+        if (newMax * 2.0 > max) newMax *= 2.0;
+      } else {
+        newMax = Math.Pow(10, Math.Ceiling(Math.Log10(max)));
+        if (newMax / 1.25 > max) newMax /= 1.25;
+        if (newMax / 1.6 > max) newMax /= 1.6;
+        if (newMax / 2.5 > max) newMax /= 2.5;
+        if (newMax / 2.0 > max) newMax /= 2.0;
+      }
+      return newMax;
     }
 
@@ -286 +323 @@
         ConfigureSeries(series, row);
         FillSeriesWithRowValues(series, row);
+        RecalculateMinMaxPointValues();
         RecalculateAxesScale(chart.ChartAreas[0]);
       }
@@ -310 +348 @@
             rowSeries.Points.Clear();
             FillSeriesWithRowValues(rowSeries, row);
+            RecalculateMinMaxPointValues();
             RecalculateAxesScale(chart.ChartAreas[0]);
             UpdateYCursorInterval();
@@ -327 +366 @@
             rowSeries.Points.Clear();
             FillSeriesWithRowValues(rowSeries, row);
+            RecalculateMinMaxPointValues();
             RecalculateAxesScale(chart.ChartAreas[0]);
             UpdateYCursorInterval();
@@ -344 +384 @@
             rowSeries.Points.Clear();
             FillSeriesWithRowValues(rowSeries, row);
+            RecalculateMinMaxPointValues();
             RecalculateAxesScale(chart.ChartAreas[0]);
             UpdateYCursorInterval();
@@ -361 +402 @@
             rowSeries.Points.Clear();
             FillSeriesWithRowValues(rowSeries, row);
+            RecalculateMinMaxPointValues();
             RecalculateAxesScale(chart.ChartAreas[0]);
             UpdateYCursorInterval();
@@ -401 +443 @@
         series.Points.Clear();
         invisibleSeries.Add(series);
+        RecalculateMinMaxPointValues();
       } else {
         invisibleSeries.Remove(series);
@@ -409 +452 @@
                      select r).Single();
           FillSeriesWithRowValues(series, row);
+          RecalculateMinMaxPointValues();
           this.chart.Legends[series.Legend].ForeColor = Color.Black;
           RecalculateAxesScale(chart.ChartAreas[0]);
           UpdateYCursorInterval();
+        }
+      }
+    }
+
+    private void RecalculateMinMaxPointValues() {
+      yMin = xMin = double.MaxValue;
+      yMax = xMax = double.MinValue;
+      foreach (var s in chart.Series.Where(x => x.Enabled)) {
+        foreach (var p in s.Points) {
+          double x = p.XValue, y = p.YValues[0];
+          if (xMin > x) xMin = x;
+          if (xMax < x) xMax = x;
+          if (yMin > y) yMin = y;
+          if (yMax < y) yMax = y;
         }
       }

trunk/sources/HeuristicLab.Problems.DataAnalysis.Views/3.4/Clustering/ClusteringSolutionVisualizationView.cs

@@ -81 +81 @@
 
       int idx = 0;
+      var oneDim = reduced.GetLength(1) == 1;
       foreach (var r in range) {
-        rows[classes[r].Item2].Points.Add(new Point2D<double>(reduced[idx, 0], reduced[idx, 1]));
+        Point2D<double> point;
+        point = oneDim ? new Point2D<double>(reduced[idx, 0], 0.0) : new Point2D<double>(reduced[idx, 0], reduced[idx, 1]);
+        rows[classes[r].Item2].Points.Add(point);
         idx++;
       }
@@ -106 +109 @@
       alglib.pcabuildbasis(data, instances.Length, attributes.Length, out info, out variances, out matrix);
 
-      var result = new double[instances.Length, 2];
+      var result = new double[instances.Length, matrix.GetLength(1)];
       int r = 0;
       foreach (var inst in instances) {