= [wiki:ReviewHeuristicLab3.3.0CodeSelection HeuristicLab 3.3.0 Code Review] - HeuristicLab.Selection-3.3 = == Reviewer: abeham == * `Selector` should not implement `ISelector`, all derived classes that are selectors in the sense of `ISelector` should implement this interface instead. Currently `TabuSelector` and probably future custom selectors appear as selectors in the SGA. It is true that `TabuSelector` is a selector (divides subscopes in remaining and selected), but not an `ISelector`. * A related note: Currently `TabuSelector` is the only "Selector" that appears twice in the !SelectorParameter of the SGA. * mkommend: In my opinion one of the classes / interfaces should be renamed (e.g. `IChildrenSelector`). * abeham: Removed `ISelector` from `Selector` in r3129. I leave the other changes for swagner to decide. ----