| | 1 | = [wiki:ReviewHeuristicLab3.3.0Code HeuristicLab 3.3.0 Code Review] - !HeuristicLab.Data-3.3 = |
| | 2 | |
| | 3 | == Reviewer: swinkler == |
| | 4 | |
| | 5 | * Regarding the `Validate` function implemented in several classes: |
| | 6 | * The use of a `StringBuilder` might be unnecessary |
| | 7 | * I would not capitalize the words in the error message. |
| | 8 | * swagner: Words in validation error messages are capitalized as it seems to be the pattern which is also used in Visual Studio (see for example properties, menu items, tool tips). |
| | 9 | * Regarding the classes representing data arrays: |
| | 10 | * In `Columns.Set` I would replace the error message with "The number of columns cannot be changed". |
| | 11 | * swagner: Changed in r2863. |
| | 12 | * Regarding the `GetValue` and `SetValue` functions implemented in several classes: |
| | 13 | * The validity of the given indices is not checked (whereas the validity of the given values is checked) - this might be on purpose. |
| | 14 | * swagner: This is on purpose. If the given indices are not valid, an exception is thrown. |
| | 15 | * In the `Validate` function of `DateTimeData` the required format could be given in the error message (as done in the `Validate` functions of several other classes). |
| | 16 | * swagner: `DateTime.Parse` is very tolerant and accepts many different date/time formats. Furthermore, the valid date/time formats depend on the localization settings of the current machine. Therefore I decided not to give any formatting hint in the error message. |
