Changes between Version 5 and Version 6 of ReviewHeuristicLab3.3.0CodeCore

Timestamp:

05/17/10 02:39:24 (14 years ago)

Author:

swagner

Comment:

--

ReviewHeuristicLab3.3.0CodeCore

@@ -4 +4 @@
 
  * '''General''': Every generic class which implements {{{IItem}}} should provide a better {{{ItemName}}} and {{{ItemDescription}}}, with the generic type parameters specified.
+   * swagner: Done in r3822.
  * '''General''': A refactoring of the deep cloning mechanism should be considered. The method {{{public virtual IDeepCloneable Clone(Cloner cloner)}}} should be split into two different methods, one for creating the object and one which sets all fields. The advantage of this splitting is that dynamically binded methods and with base calls could be used to set the properties.
    * swagner: Usually cloning is done by calling the dynamically bound method `Clone(Cloner cloner)` which makes a base call to set all data members along the inheritance chain. Only in some special cases (e.g. `Variable`) this pattern is not followed to gain performance, as instance creation using `Activator.CreateInstance` (done in `DeepCloneable`) is quite expensive. Therefore, the deep cloning mechanism has not to be refactored in my opinion.