Bug in SampleProportionalWithoutRepetition extension method

[abeham]

The index variable is incremented twice in each iteration

[abeham]

r10407: Fixed bug in sample proportional without repetition

[abeham]

I'll also post the code here with the variant that uses free indices instead of chosen indices. The code is somewhat nicer, but I did not use this because I think it's a waste of resources for most cases when you have a large population where you draw only a couple of samples from (the while loop isn't fully executed as it depends on the outer .Take() that is calling this).

SortedSet<int> freeIndices = new SortedSet<int>(Enumerable.Range(0, sourceArray.Length));
while (freeIndices.Any()) {
  var index = freeIndices.GetEnumerator();
  double ball = 0, sum = random.NextDouble() * total;
  while (index.MoveNext()) {
    ball += valueArray[index.Current];
    if (ball >= sum) break;
  };
  yield return sourceArray[index.Current];
  total -= valueArray[index.Current];
}

[abeham]

mkommend suggested to use a LinkedList<double> instead of a double[] for values and remove the node after yielding it. This doesn't require a hashset at all, but requires some changes to the helper functions.

[gkronber]

r10465: implemented unit test for SampleProportionalWithoutRepetition

[gkronber]

r10466: changed implementation of SampleProportionalWithoutRepetition to use a linked list.

[gkronber]

r10503: minor efficiency tweak (removed unnecessary .ToArray() call)

[abeham]

r10504: fixed bug in biased vrp multi operators that was introduced through the recent changes

[mkommend]

r10474 using RandomEnumerable.SampleProportional in BiasedMultiVRPOperators. This should also be changed in StochasticMultiOperator but is not easily possible because of plugin dependency HeuristicLab.Random -> HeuristicLab.Operators.

was recorded in ticket #2119, but won't be merged in the stable branch, as it has nothing to do with the operator instrumentation. r10504 fixes a bug introduced with r10474 => it shall be released with this ticket.

[abeham]

The implementation looks good now. I took a look at the unit tests and noticed that there are redundant asserts. Also I added some tests with a little variation regarding the bool parameters.

r10646: updated unit tests

[abeham]

I think this can be released

[abeham]

r10743: merged r10407,r10465,r10466,r10474,r10503,r10504,r10646 into stable

r10474 contained an unrelated change of properties on HeuristicLab.HLScript and HeuristicLab.HLScript.Views which could not be merged into stable as Scripting is not yet part of stable.