Changeset 939 for trunk

Timestamp:

12/10/08 14:10:52 (16 years ago)

Author:

svonolfe

Message:

Fixed referential integrity between user and user group (#372)

Location:

trunk/sources

Files:

• HeuristicLab.Hive.Contracts/BusinessObjects/PermissionOwner.cs (modified) (1 diff)
• HeuristicLab.Hive.Server.ADODataAccess/PermissionOwnerAdapter.cs (modified) (1 diff)
• HeuristicLab.Hive.Server.ADODataAccess/UserAdapter.cs (modified) (2 diffs)
• HeuristicLab.Hive.Server.ADODataAccess/UserGroupAdapter.cs (modified) (4 diffs)
• HeuristicLab.Hive.Server.Core/DbTestApp.cs (modified) (4 diffs)
• HeuristicLab.Hive.Server.Core/InternalInterfaces/DataAccess/IUserGroupAdapter.cs (modified) (1 diff)

trunk/sources/HeuristicLab.Hive.Contracts/BusinessObjects/PermissionOwner.cs

@@ -34 +34 @@
     [DataMember]
     public string Name { get; set; }
-    
+
+    public override bool Equals(object obj) {
+      if (obj is PermissionOwner) 
+        return this.PermissionOwnerId.Equals(
+          (obj as PermissionOwner).PermissionOwnerId);
+      else
+        return base.Equals(obj);
+    }
+
+    public override int GetHashCode() {
+      return this.PermissionOwnerId.GetHashCode();
+    }
   }
 }

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/PermissionOwnerAdapter.cs

@@ -152 +152 @@
           if(row != null) {
             data.RemovePermissionOwnerRow(row);
-
+          
             return true;
           }

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/UserAdapter.cs

@@ -39 +39 @@
     private IPermissionOwnerAdapter permOwnerAdapter =
        ServiceLocator.GetPermissionOwnerAdapter();
+
+    private IUserGroupAdapter userGroupAdapter = null;
 
     public UserAdapter() {
@@ -150 +152 @@
 
         if (row != null) {
+          if (userGroupAdapter == null)
+            userGroupAdapter =
+              ServiceLocator.GetUserGroupAdapter();
+
+          ICollection<UserGroup> userGroups =
+            userGroupAdapter.MemberOf(user);
+
+          foreach (UserGroup group in userGroups) {
+            group.Members.Remove(user);
+            userGroupAdapter.UpdateUserGroup(group);
+          }
+
           data.RemoveHiveUserRow(row);
 

trunk/sources/HeuristicLab.Hive.Server.ADODataAccess/UserGroupAdapter.cs

@@ -28 +28 @@
 using HeuristicLab.Hive.Contracts.BusinessObjects;
 using System.Runtime.CompilerServices;
+using System.Data;
 
 namespace HeuristicLab.Hive.Server.ADODataAccess {
@@ -169 +170 @@
         foreach (dsHiveServer.PermissionOwner_UserGroupRow permOwnerUserGroupRow in
           userGroupRows) {
-          PermissionOwner permOwner = userGroup.Members.Single<PermissionOwner>(
-            p => p.PermissionOwnerId == permOwnerUserGroupRow.PermissionOwnerId);
+          PermissionOwner permOwner = null;
+
+          IEnumerable<PermissionOwner> permOwners =
+            from p in
+              userGroup.Members
+            where p.PermissionOwnerId == permOwnerUserGroupRow.PermissionOwnerId
+            select p;
+
+          if (permOwners.Count<PermissionOwner>() == 1)
+            permOwner = permOwners.First<PermissionOwner>();
 
           if (permOwner == null) {
@@ -234 +243 @@
 
       return allUserGroups;
+    }
+
+    public ICollection<UserGroup> MemberOf(PermissionOwner permOwner) {
+      ICollection<UserGroup> userGroups =
+        new List<UserGroup>();
+      
+      if (permOwner != null) {
+        IEnumerable<dsHiveServer.PermissionOwner_UserGroupRow> userGroupRows =
+         from userGroup in
+           permOwnerUserGroupData.AsEnumerable<dsHiveServer.PermissionOwner_UserGroupRow>()
+         where userGroup.PermissionOwnerId == permOwner.PermissionOwnerId
+         select userGroup;
+
+        foreach (dsHiveServer.PermissionOwner_UserGroupRow userGroupRow in
+          userGroupRows) {
+          UserGroup userGroup = 
+            GetUserGroupById(userGroupRow.UserGroupId);
+          userGroups.Add(userGroup);
+        }
+      }
+
+      return userGroups;
     }
 
@@ -249 +280 @@
             permOwnerUserGroupData) {
             if (permOwnerUserGroupRow.UserGroupId == group.PermissionOwnerId || 
-                permOwnerUserGroupRow.PermissionOwnerId == group.PermissionOwnerId) {
+              permOwnerUserGroupRow.PermissionOwnerId == group.PermissionOwnerId) {
               deleted.Add(permOwnerUserGroupRow);
             }

trunk/sources/HeuristicLab.Hive.Server.Core/DbTestApp.cs

@@ -114 +114 @@
       user2.Name = "Martin";
 
+      User user3 =
+        new User();
+      user3.Name = "Heinz";
+
       UserGroup group =
         new UserGroup();
@@ -121 +125 @@
       subGroup.Members.Add(user);
 
+      group.Members.Add(user3);
       group.Members.Add(user2);
       group.Members.Add(subGroup);
@@ -132 +137 @@
         userGroupAdapter.GetAllUserGroups();
 
+      IUserAdapter userAdapter =
+        ServiceLocator.GetUserAdapter();
+
+      userAdapter.DeleteUser(user3);
+      
+      read =
+         userGroupAdapter.GetUserGroupById(group.PermissionOwnerId);
+
       userGroupAdapter.DeleteUserGroup(subGroup);
+
+      read =
+         userGroupAdapter.GetUserGroupById(group.PermissionOwnerId);
 
       userGroups =
         userGroupAdapter.GetAllUserGroups();
-
-      read =
-        userGroupAdapter.GetUserGroupById(group.PermissionOwnerId);
 
       userGroupAdapter.DeleteUserGroup(group);
@@ -144 +157 @@
       userGroups =
         userGroupAdapter.GetAllUserGroups();
-
-      IUserAdapter userAdapter =
-        ServiceLocator.GetUserAdapter();
 
       userAdapter.DeleteUser(user);

trunk/sources/HeuristicLab.Hive.Server.Core/InternalInterfaces/DataAccess/IUserGroupAdapter.cs

@@ -51 +51 @@
 
     /// <summary>
+    /// Gets all user groups where the permission owner is member of
+    /// </summary>
+    /// <param name="permOwner"></param>
+    /// <returns></returns>
+    ICollection<UserGroup> MemberOf(PermissionOwner permOwner);
+
+    /// <summary>
     /// Deletes the user group
     /// </summary>