Changeset 9219 for trunk/sources/HeuristicLab.Clients.Hive/3.3/ConcurrentTaskDownloader.cs

Timestamp:

02/18/13 10:34:23 (11 years ago)

Author:

ascheibe

Message:

#2005 merged Hive Job Unloading branch back into trunk

Location:

trunk/sources

Files:

• . (modified) (1 prop)
• HeuristicLab.Clients.Hive/3.3/ConcurrentTaskDownloader.cs (modified) (6 diffs)

trunk/sources/HeuristicLab.Clients.Hive/3.3/ConcurrentTaskDownloader.cs

@@ -30 +30 @@
   /// Downloads and deserializes jobs. It avoids too many jobs beeing downloaded or deserialized at the same time to avoid memory problems
   /// </summary>
-  public class ConcurrentTaskDownloader<T> where T : class, ITask {
+  public class ConcurrentTaskDownloader<T> : IDisposable where T : class, ITask {
     private bool abort = false;
     // use semaphore to ensure only few concurrenct connections and few SerializedJob objects in memory
@@ -39 +39 @@
       downloadSemaphore = new Semaphore(concurrentDownloads, concurrentDownloads);
       deserializeSemaphore = new Semaphore(concurrentDeserializations, concurrentDeserializations);
-      TaskScheduler.UnobservedTaskException += new EventHandler<UnobservedTaskExceptionEventArgs>(TaskScheduler_UnobservedTaskException);
     }
 
@@ -69 +68 @@
 
     private Task DownloadTask(object taskId) {
-      return HiveServiceLocator.Instance.CallHiveService(s => s.GetTask((Guid)taskId));
+      Task t = null;
+      HiveClient.TryAndRepeat(() => {
+        t = HiveServiceLocator.Instance.CallHiveService(s => s.GetTask((Guid)taskId));
+      }, Settings.Default.MaxRepeatServiceCalls, "Failed to download task.");
+      return t;
     }
 
@@ -78 +81 @@
     protected Tuple<Task, TaskData> DownloadTaskData(Task task) {
       downloadSemaphore.WaitOne();
-      TaskData result;
+      TaskData result = null;
       try {
         if (abort) return null;
-        result = HiveServiceLocator.Instance.CallHiveService(s => s.GetTaskData(task.Id));
-      } finally {
+        HiveClient.TryAndRepeat(() => {
+          result = HiveServiceLocator.Instance.CallHiveService(s => s.GetTaskData(task.Id));
+        }, Settings.Default.MaxRepeatServiceCalls, "Failed to download task data.");
+      }
+      finally {
         downloadSemaphore.Release();
       }
@@ -95 +101 @@
         taskData.Item2.Data = null; // reduce memory consumption.
         return new Tuple<Task, T>(taskData.Item1, deserializedJob);
-      } finally {
+      }
+      finally {
         deserializeSemaphore.Release();
       }
-    }
-
-    private void TaskScheduler_UnobservedTaskException(object sender, UnobservedTaskExceptionEventArgs e) {
-      e.SetObserved(); // avoid crash of process because task crashes. first exception found is handled in Results property
-      OnExceptionOccured(new HiveException("Unobserved Exception in ConcurrentTaskDownloader", e.Exception));
     }
 
@@ -110 +112 @@
       if (handler != null) handler(this, new EventArgs<Exception>(exception));
     }
+
+    #region IDisposable Members
+    public void Dispose() {
+      deserializeSemaphore.Dispose();
+      downloadSemaphore.Dispose();
+    }
+    #endregion
   }
 }