Changeset 9173

Timestamp:

01/18/13 10:26:25 (11 years ago)

Author:

ascheibe

Message:

#2005

• fixed naming of event handlers that were forgotten when the naming from experiment to job was changed
• fixed some more memory leaks

Location:

branches/UnloadJobs

Files:

• HeuristicLab.Clients.Hive.JobManager/3.3/Views/HiveJobManagerView.cs (modified) (3 diffs)
• HeuristicLab.Clients.Hive.JobManager/3.3/Views/RefreshableHiveJobView.cs (modified) (5 diffs)
• HeuristicLab.Clients.Hive.Views/3.3/TreeView/HiveTaskItemTreeView.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive/3.3/HiveClient.cs (modified) (2 diffs)
• HeuristicLab.Clients.Hive/3.3/HiveTasks/HiveTask.cs (modified) (9 diffs)
• HeuristicLab.Clients.Hive/3.3/HiveTasks/OptimizerHiveTask.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive/3.3/RefreshableJob.cs (modified) (2 diffs)
• HeuristicLab.Clients.Hive/3.3/ServiceClients/HiveItemCollection.cs (modified) (1 diff)

branches/UnloadJobs/HeuristicLab.Clients.Hive.JobManager/3.3/Views/HiveJobManagerView.cs

@@ -55 +55 @@
       Content.Refreshed += new EventHandler(Content_Refreshed);
       Content.HiveJobsChanged += new EventHandler(Content_HiveJobsChanged);
-
     }
 
@@ -131 +130 @@
           Content.Jobs.ItemsRemoved -= new CollectionItemsChangedEventHandler<RefreshableJob>(HiveExperiments_ItemsRemoved);
           Content.ClearHiveClient();
+          Content = null;
         }
       }
@@ -143 +143 @@
     private void Content_HiveJobsChanged(object sender, EventArgs e) {
       if (Content.Jobs != null) {
+        Content.Jobs.ItemsRemoved -= new CollectionItemsChangedEventHandler<RefreshableJob>(HiveExperiments_ItemsRemoved);
         Content.Jobs.ItemsRemoved += new CollectionItemsChangedEventHandler<RefreshableJob>(HiveExperiments_ItemsRemoved);
       }

branches/UnloadJobs/HeuristicLab.Clients.Hive.JobManager/3.3/Views/RefreshableHiveJobView.cs

@@ -100 +100 @@
         progressView = null;
       }
+      DeregisterHiveExperimentEvents();
+      DeregisterHiveTasksEvents();
       base.DeregisterContentEvents();
     }
@@ -111 +113 @@
     }
 
-    private void RegisterHiveJobEvents() {
+    private void RegisterHiveTasksEvents() {
       Content.HiveTasks.ItemsAdded += new CollectionItemsChangedEventHandler<HiveTask>(HiveTasks_ItemsAdded);
       Content.HiveTasks.ItemsRemoved += new CollectionItemsChangedEventHandler<HiveTask>(HiveTasks_ItemsRemoved);
       Content.HiveTasks.CollectionReset += new CollectionItemsChangedEventHandler<HiveTask>(HiveTasks_CollectionReset);
     }
-    private void DeregisterHiveJobEvents() {
+    private void DeregisterHiveTasksEvents() {
       Content.HiveTasks.ItemsAdded -= new CollectionItemsChangedEventHandler<HiveTask>(HiveTasks_ItemsAdded);
       Content.HiveTasks.ItemsRemoved -= new CollectionItemsChangedEventHandler<HiveTask>(HiveTasks_ItemsRemoved);
@@ -131 +133 @@
           resourceNamesTextBox.Text = string.Empty;
           isPrivilegedCheckBox.Checked = false;
-          logView.Content = null;
           refreshAutomaticallyCheckBox.Checked = false;
           lock (runCollectionViewLocker) {
             runCollectionViewHost.Content = null;
           }
+          logView.Content = null;
+          jobsTreeView.Content = null;
+          hiveExperimentPermissionListView.Content = null;
+          stateLogViewHost.Content = null;
         } else {
           nameTextBox.Text = Content.Job.Name;
@@ -286 +291 @@
         if (Content != null && Content.HiveTasks != null) {
           jobsTreeView.Content = Content.HiveTasks;
-          RegisterHiveJobEvents();
+          RegisterHiveTasksEvents();
         } else {
           jobsTreeView.Content = null;
@@ -435 +440 @@
 
     private void nameTextBox_Validated(object sender, EventArgs e) {
-      if (!SuppressEvents && Content.Job.Name != nameTextBox.Text)
+      if (!SuppressEvents && Content.Job != null && Content.Job.Name != nameTextBox.Text)
         Content.Job.Name = nameTextBox.Text;
     }
 
     private void resourceNamesTextBox_Validated(object sender, EventArgs e) {
-      if (!SuppressEvents && Content.Job.ResourceNames != resourceNamesTextBox.Text)
+      if (!SuppressEvents && Content.Job != null && Content.Job.ResourceNames != resourceNamesTextBox.Text)
         Content.Job.ResourceNames = resourceNamesTextBox.Text;
     }

branches/UnloadJobs/HeuristicLab.Clients.Hive.Views/3.3/TreeView/HiveTaskItemTreeView.cs

@@ -35 +35 @@
       get { return (ItemCollection<HiveTask>)base.Content; }
       set { base.Content = value; }
+    }
+
+    protected override void OnContentChanged() {
+      if (Content == null) {
+        foreach (var t in Content) {
+          t.Dispose();
+        }
+      }
+      base.OnContentChanged();
     }
 

branches/UnloadJobs/HeuristicLab.Clients.Hive/3.3/HiveClient.cs

@@ -46 +46 @@
 
     #region Properties
-    private ItemCollection<RefreshableJob> jobs;
-    public ItemCollection<RefreshableJob> Jobs {
+    private HiveItemCollection<RefreshableJob> jobs;
+    public HiveItemCollection<RefreshableJob> Jobs {
       get { return jobs; }
       set {
@@ -87 +87 @@
 
     public void ClearHiveClient() {
+      Jobs.ClearWithoutHiveDeletion();
       foreach (var j in Jobs) {
         if (j.RefreshAutomatically) {
           j.RefreshAutomatically = false; // stop result polling
-          j.Dispose();
-        }
+        }
+        j.Dispose();
       }
       Jobs = null;
+
       if (onlinePlugins != null)
         onlinePlugins.Clear();

branches/UnloadJobs/HeuristicLab.Clients.Hive/3.3/HiveTasks/HiveTask.cs

@@ -36 +36 @@
   [Item("Hive Task", "Represents a hive task.")]
   [StorableClass]
-  public class HiveTask : NamedItem, IItemTree<HiveTask> {
+  public class HiveTask : NamedItem, IItemTree<HiveTask>, IDisposable {
     protected static object locker = new object();
     protected ReaderWriterLockSlim childHiveTasksLock = new ReaderWriterLockSlim(LockRecursionPolicy.SupportsRecursion);
@@ -67 +67 @@
       set {
         if (task != value) {
-          DeregisterJobEvents();
+          DeregisterTaskEvents();
           task = value;
-          RegisterJobEvents();
+          RegisterTaskEvents();
           IsFinishedTaskDownloaded = false;
           OnTaskChanged();
@@ -93 +93 @@
           itemTaskLock.EnterWriteLock();
           try {
-            DergisterItemTaskEvents();
+            DeregisterItemTaskEvents();
             itemTask = value;
             RegisterItemTaskEvents();
@@ -177 +177 @@
       this.childHiveTasks = new ItemList<HiveTask>();
       syncTasksWithOptimizers = true;
-      RegisterChildHiveJobEvents();
+      RegisterChildHiveTasksEvents();
     }
 
@@ -198 +198 @@
       this.childHiveTasks = new ItemList<HiveTask>();
       this.syncTasksWithOptimizers = true;
-      RegisterChildHiveJobEvents();
+      RegisterChildHiveTasksEvents();
     }
 
@@ -226 +226 @@
       }
     }
-    protected virtual void DergisterItemTaskEvents() {
+    protected virtual void DeregisterItemTaskEvents() {
       if (ItemTask != null) {
         ItemTask.ComputeInParallelChanged -= new EventHandler(ItemJob_ComputeInParallelChanged);
@@ -233 +233 @@
     }
 
-    protected virtual void RegisterChildHiveJobEvents() {
+    protected virtual void RegisterChildHiveTasksEvents() {
       this.childHiveTasks.ItemsAdded += new CollectionItemsChangedEventHandler<IndexedItem<HiveTask>>(OnItemsAdded);
       this.childHiveTasks.ItemsRemoved += new CollectionItemsChangedEventHandler<IndexedItem<HiveTask>>(OnItemsRemoved);
       this.childHiveTasks.CollectionReset += new CollectionItemsChangedEventHandler<IndexedItem<HiveTask>>(OnCollectionReset);
     }
-    protected virtual void DeregisterChildHiveJobEvents() {
+    protected virtual void DeregisterChildHiveTasksEvents() {
       this.childHiveTasks.ItemsAdded -= new CollectionItemsChangedEventHandler<IndexedItem<HiveTask>>(OnItemsAdded);
       this.childHiveTasks.ItemsRemoved -= new CollectionItemsChangedEventHandler<IndexedItem<HiveTask>>(OnItemsRemoved);
@@ -342 +342 @@
     }
 
-    private void RegisterJobEvents() {
+    private void RegisterTaskEvents() {
       if (task != null)
         task.PropertyChanged += new PropertyChangedEventHandler(task_PropertyChanged);
     }
 
-    private void DeregisterJobEvents() {
+    private void DeregisterTaskEvents() {
       if (task != null)
         task.PropertyChanged += new PropertyChangedEventHandler(task_PropertyChanged);
@@ -526 +526 @@
       this.ItemTask.Item = null;
     }
+
+    public void Dispose() {
+      DeregisterChildHiveTasksEvents();
+      DeregisterTaskEvents();
+      DeregisterItemTaskEvents();
+      childHiveTasksLock.Dispose();
+      itemTaskLock.Dispose();
+    }
   }
 

branches/UnloadJobs/HeuristicLab.Clients.Hive/3.3/HiveTasks/OptimizerHiveTask.cs

@@ -107 +107 @@
       }
     }
-    protected override void DergisterItemTaskEvents() {
-      base.DergisterItemTaskEvents();
+    protected override void DeregisterItemTaskEvents() {
+      base.DeregisterItemTaskEvents();
       if (ItemTask != null) {
         if (ItemTask.Item is Optimization.Experiment) {

branches/UnloadJobs/HeuristicLab.Clients.Hive/3.3/RefreshableJob.cs

@@ -562 +562 @@
 
     public Guid Id {
-      get { return job.Id; }
+      get {
+        if (job == null) return Guid.Empty;
+        return job.Id;
+      }
       set { job.Id = value; }
     }
@@ -614 +617 @@
         jobDownloader = null;
       }
+      if (jobResultPoller != null) {
+        DeregisterResultPollingEvents();
+        jobResultPoller = null;
+      }
+      if (hiveTasks != null) {
+        DisposeTasks();
+      }
       if (job != null) {
         DeregisterJobEvents();
         job = null;
       }
-      if (hiveTasks != null) {
-        DeregisterHiveTasksEvents();
-        hiveTasks.Clear(); // this should remove the item_StateLogChanged event handlers
-        hiveTasks = null;
-      }
-      if (jobResultPoller != null) {
-        DeregisterResultPollingEvents();
-        jobResultPoller = null;
-      }
+    }
+
+    private void DisposeTasks() {
+      DeregisterHiveTasksEvents();
+      foreach (var task in hiveTasks) {
+        task.Dispose();
+      }
+      hiveTasks.Clear(); // this should remove the item_StateLogChanged event handlers
+      hiveTasks = null;
     }
     #endregion

branches/UnloadJobs/HeuristicLab.Clients.Hive/3.3/ServiceClients/HiveItemCollection.cs

@@ -52 +52 @@
     }
 
+    public void ClearWithoutHiveDeletion() {
+      if (list.Count > 0) {
+        T[] items = list.ToArray();
+        list.Clear();
+        OnPropertyChanged("Count");
+        //don't call OnCollectionReset directly as it would delete the job
+        base.OnCollectionReset(list, items);
+      }
+    }
+
     private void RemoveItems(IEnumerable<T> items, out IEnumerable<T> successful, out IEnumerable<T> unsuccessful, out Exception exception) {
       List<T> removed = new List<T>();