Changeset 9169 for branches/UnloadJobs/HeuristicLab.Clients.Hive/3.3/RefreshableJob.cs

Timestamp:

01/16/13 11:13:18 (11 years ago)

Author:

ascheibe

Message:

#2005

• renamed some events and methods
• fixed some memory leaks

File:

• branches/UnloadJobs/HeuristicLab.Clients.Hive/3.3/RefreshableJob.cs (modified) (8 diffs)

branches/UnloadJobs/HeuristicLab.Clients.Hive/3.3/RefreshableJob.cs

@@ -31 +31 @@
 
 namespace HeuristicLab.Clients.Hive {
-  public class RefreshableJob : IHiveItem, IDeepCloneable, IContent, IComparable<RefreshableJob> {
+  public class RefreshableJob : IHiveItem, IDeepCloneable, IContent, IComparable<RefreshableJob>, IDisposable {
     private JobResultPoller jobResultPoller;
     private ConcurrentTaskDownloader<ItemTask> jobDownloader;
@@ -48 +48 @@
             throw new ArgumentNullException();
 
-          if (job != null) DergisterJobEvents();
+          if (job != null) DeregisterJobEvents();
           job = value;
           if (job != null) {
@@ -66 +66 @@
       set {
         if (hiveTasks != value) {
-          if (hiveTasks != null) DeregisterHiveJobsEvents();
+          if (hiveTasks != null) DeregisterHiveTasksEvents();
           hiveTasks = value;
-          if (hiveTasks != null) RegisterHiveJobsEvents();
+          if (hiveTasks != null) RegisterHiveTasksEvents();
           OnHiveTasksChanged();
         }
@@ -240 +240 @@
       if (jobResultPoller != null && jobResultPoller.IsPolling) {
         jobResultPoller.Stop();
+        DeregisterResultPollingEvents();
       }
     }
@@ -358 +359 @@
     }
 
-    private void DergisterJobEvents() {
+    private void DeregisterJobEvents() {
       job.ToStringChanged -= new EventHandler(OnToStringChanged);
       job.PropertyChanged -= new PropertyChangedEventHandler(job_PropertyChanged);
@@ -473 +474 @@
 
     #region HiveTasks Events
-    private void RegisterHiveJobsEvents() {
+    private void RegisterHiveTasksEvents() {
       this.hiveTasks.ItemsAdded += new CollectionItemsChangedEventHandler<HiveTask>(hivetasks_ItemsAdded);
       this.hiveTasks.ItemsRemoved += new CollectionItemsChangedEventHandler<HiveTask>(hiveTasks_ItemsRemoved);
@@ -479 +480 @@
     }
 
-    private void DeregisterHiveJobsEvents() {
+    private void DeregisterHiveTasksEvents() {
       this.hiveTasks.ItemsAdded -= new CollectionItemsChangedEventHandler<HiveTask>(hivetasks_ItemsAdded);
       this.hiveTasks.ItemsRemoved -= new CollectionItemsChangedEventHandler<HiveTask>(hiveTasks_ItemsRemoved);
@@ -605 +606 @@
       return this.ToString().CompareTo(other.ToString());
     }
+
+    #region IDisposable Members
+    public void Dispose() {
+      if (jobDownloader != null) {
+        jobDownloader.ExceptionOccured -= new EventHandler<EventArgs<Exception>>(jobDownloader_ExceptionOccured);
+        jobDownloader.Dispose();
+        jobDownloader = null;
+      }
+      if (job != null) {
+        DeregisterJobEvents();
+        job = null;
+      }
+      if (hiveTasks != null) {
+        DeregisterHiveTasksEvents();
+        hiveTasks.Clear(); // this should remove the item_StateLogChanged event handlers
+        hiveTasks = null;
+      }
+      if (jobResultPoller != null) {
+        DeregisterResultPollingEvents();
+        jobResultPoller = null;
+      }
+    }
+    #endregion
   }
 }